347514 - Wrong placement of tab drop indicator in RTL locales

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect)

Description

[Behnam Esfahbod [:zwnj]]

Place of marker is wrong for the first place.

Comment 1

[Behnam Esfahbod [:zwnj]]

Attachment: Screenshot

Comment 2

[(not reading, please use [e-mail] instead)]

benham, which build are you using?

Comment 3

[Behnam Esfahbod [:zwnj]]

I use a GTK build from CVS (about 4 days ago) with pango enabled.

Configure arguments
--enable-application=browser --prefix=/home/behnam/opt/mozilla/firefox-2.0-fa --enable-pango 

Comment 4

[yanivabir]

I see this as well in 1.5.0.5, plus when you close a tab Firefox automatically opens the next tab instead of the previous tab, as it does in LTR locales (in other words, it opens the tab to the left, as it does in LTR, although it should open the tab to the right)

Comment 5

[yanivabir]

I'm sorry, I was wrong. I have not problems with the tab drop indicator. I do have another problem that is visible in your screenshots - the tab isn't flipped horizontally as it should be - i.e. the straight edge is on the left while the curved one in on the right.

Comment 6

[Behnam Esfahbod [:zwnj]]

The problem do exist yet.

Comment 7

[Peter Kasting]

If the marker is placed wrong, it makes tab drag and drop much harder to use in RTL locales.  Nominating for driver consideration.

Comment 8

[Mike Connor [:mconnor]]

unable to reproduce, Mano says this looks fine.

unsure if pango might affect it, but unless someone can reproduce in a stock build, there's no way we're blocking on this.

Comment 9

[Behnam Esfahbod [:zwnj]]

Attachment: Wrong Marker (Updated Screenshot)

Comment 10

[Behnam Esfahbod [:zwnj]]

Attachment: Right position on the left end

As you can see, the marker for the left end is all right.

Comment 11

[Behnam Esfahbod [:zwnj]]

These are screenshot of today's nightly build of tbox.

Comment 12

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).

Comment 13

[(no longer active)]

This has been fixed on trunk.  Resolving as WFM because the 2.0 branch isn't getting any more updates...