Closed Bug 347813 Opened 18 years ago Closed 18 years ago

Sunbird Preferences window misses numerous accesskeys

Categories

(Calendar :: Preferences, defect)

Sunbird 0.3a2
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Sunbird 0.3

People

(Reporter: cedric.corazza, Assigned: cedric.corazza)

Details

(Keywords: access)

Attachments

(4 files, 6 obsolete files)

The Pref window in Sunbird misses many accesskeys. Preferences items should have some
Attached patch Accesskeys for General pane (obsolete) — — Splinter Review
Attachment #232691 - Flags: first-review?
Attached patch Accesskeys for Alarms pane (obsolete) — — Splinter Review
Attachment #232697 - Flags: first-review?
Attached patch Accesskeys for Categories pane (obsolete) — — Splinter Review
I'm wondering : add.label, edit.label and remove.label are only used by Sunbird in the Categories pane and nowhere else.
Lightning uses an edit entity but one of its own : lightning.sidebar.edit.label
So, why not remove these 3 entities from global.dtd to put them in categories.dtd?
I also added ellipses for the Add button and the Edit button.
Attachment #232699 - Flags: first-review?
Attached file Accesskeys for Views pane (obsolete) —
NOTE : This patch depends on attachment #232699 [details] [diff] [review] as global.dtd is modified in both ones.
Regarding bug 314785 : it appears we should have to suffix almost all the entities in views.dtd with ".label". right ?
Attachment #232705 - Flags: first-review?
Comment on attachment 232691 [details] [diff] [review]
Accesskeys for General pane

Matt should do the first review here since he organized most of this code.  I'll take care of the peer-bit.

(same for all patches)
Attachment #232691 - Flags: second-review?(jminta)
Attachment #232691 - Flags: first-review?(mattwillis)
Attachment #232691 - Flags: first-review?
Attachment #232697 - Flags: second-review?(jminta)
Attachment #232697 - Flags: first-review?(mattwillis)
Attachment #232697 - Flags: first-review?
Attachment #232699 - Flags: second-review?(jminta)
Attachment #232699 - Flags: first-review?(mattwillis)
Attachment #232699 - Flags: first-review?
Attachment #232705 - Flags: second-review?(jminta)
Attachment #232705 - Flags: first-review?(mattwillis)
Attachment #232705 - Flags: first-review?
Comment on attachment 232691 [details] [diff] [review]
Accesskeys for General pane

 <!ENTITY pref.defaultlength.label "Default Event Length:" >
+<!ENTITY pref.defaultlength.label "E">
Two entities with the same name seems like trouble...
Comment on attachment 232697 [details] [diff] [review]
Accesskeys for Alarms pane

Why does a caption need an access key?  Users can't interact with it.
Comment on attachment 232699 [details] [diff] [review]
Accesskeys for Categories pane

Totally. 2r=jminta
Attachment #232699 - Flags: second-review?(jminta) → second-review+
Attachment #232691 - Attachment is obsolete: true
Attachment #232691 - Flags: second-review?(jminta)
Attachment #232691 - Flags: first-review?(mattwillis)
Attachment #232759 - Attachment description: Fix according to comment #6 → Fix according to comment #6 Accesskeys for General pane
Attachment #232759 - Flags: second-review?(jminta)
Attachment #232759 - Flags: first-review?(mattwillis)
Attachment #232697 - Attachment is obsolete: true
Attachment #232774 - Flags: first-review?(mattwillis)
Attachment #232697 - Flags: second-review?(jminta)
Attachment #232697 - Flags: first-review?(mattwillis)
Attachment #232759 - Attachment is obsolete: true
Attachment #232788 - Flags: first-review?(mattwillis)
Attachment #232759 - Flags: second-review?(jminta)
Attachment #232759 - Flags: first-review?(mattwillis)
Attachment #232793 - Flags: first-review?(mattwillis)
Attachment #232788 - Attachment description: Accesskeys for Alarms pane; adding control attribute → Accesskeys for General pane; adding control attribute
Attachment #232705 - Attachment is obsolete: true
Attachment #232705 - Attachment is patch: false
Attachment #232705 - Flags: second-review?(jminta)
Attachment #232705 - Flags: first-review?(mattwillis)
Comment on attachment 232788 [details] [diff] [review]
Accesskeys for General pane; adding control attribute

Looks good.
r=lilmatt
Attachment #232788 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 232793 [details] [diff] [review]
Accesskeys for Views pane; adding control attribute

-<!-- Month Names -->
+<!-- Day Names -->
Nice catch :)

-<!ENTITY day.1.Ddd "Sun" >
-<!ENTITY day.2.Ddd "Mon" >
-<!ENTITY day.3.Ddd "Tue" >
-<!ENTITY day.4.Ddd "Wed" >
-<!ENTITY day.5.Ddd "Thu" >
-<!ENTITY day.6.Ddd "Fri" >
-<!ENTITY day.7.Ddd "Sat" >
Let's not delete these just to line them up with the accesskeys. Doing so screws up cvs blame. Instead, please insert each accesskey after its label.

+<!-- LOCALISATION NOTE : Accesskeys for day.1.Ddd to day.7.Ddd are currently
+only used in Preferences > Views > Workweek groupbox -->
<!-- LOCALIZATION NOTE : Accesskeys for day.1.Ddd to day.7.Ddd are currently
   - only used in Preferences > Views > Workweek groupbox -->
I made a slight spelling and formatting adjustment.

r=lilmatt with those nits fixed
Attachment #232793 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 232774 [details] [diff] [review]
Accesskeys for Alarms pane; adding control attribute

Looks good.
r=lilmatt

Giving r2 to jminta
Attachment #232774 - Flags: second-review?(jminta)
Attachment #232774 - Flags: first-review?(mattwillis)
Attachment #232774 - Flags: first-review+
Comment on attachment 232699 [details] [diff] [review]
Accesskeys for Categories pane

add.label and add.accesskey are too generic and may end up colliding with the charset tools in toolkit.
Please fix that by using more specific names for both the label and the accesskey. My suggestion is something like pref.categories.addButton.label.

Please move these labels and accesskeys into calendar/locales/en-US/chrome/calendar/preferences/categories.dtd, rather than global.dtd.

Please use the actual ellipsis character (…) rather than 3 periods. On the Add and Edit buttons. You should be able to copy and paste it from the "WARNING" atop categories.dtd.

r=lilmatt with all that
Attachment #232699 - Flags: first-review?(mattwillis) → first-review+
Comment on attachment 232788 [details] [diff] [review]
Accesskeys for General pane; adding control attribute

Giving r2 to jminta
Attachment #232788 - Flags: second-review?(jminta)
Comment on attachment 232793 [details] [diff] [review]
Accesskeys for Views pane; adding control attribute

Giving r2 to jminta
Attachment #232793 - Flags: second-review?(jminta)
First-review+=mattwillis. Fixing spelling and formatting nits.
Attachment #232793 - Attachment is obsolete: true
Attachment #232890 - Flags: second-review?(jminta)
Attachment #232793 - Flags: second-review?(jminta)
This also removes DOCTYPE overlay preferences.dtd and global.dtd, as discussed on IRC.
Attachment #232699 - Attachment is obsolete: true
(In reply to comment #19)
> Created an attachment (id=232890) [edit]
> Accesskeys for Views pane; addressing comment #14
> 
> First-review+=mattwillis. Fixing spelling and formatting nits.

This patch checked in on MOZILLA_1_8_BRANCH and trunk.
(In reply to comment #21)
> (In reply to comment #19)
> > Created an attachment (id=232890) [edit]
> > Accesskeys for Views pane; addressing comment #14
> > 
> > First-review+=mattwillis. Fixing spelling and formatting nits.
> 
> This patch checked in on MOZILLA_1_8_BRANCH and trunk.

Ignore this. I meant I checked in the "categories pane" patch.
Comment on attachment 232774 [details] [diff] [review]
Accesskeys for Alarms pane; adding control attribute

2r=jminta
Attachment #232774 - Flags: second-review?(jminta) → second-review+
Comment on attachment 232788 [details] [diff] [review]
Accesskeys for General pane; adding control attribute

2r=jminta
Attachment #232788 - Flags: second-review?(jminta) → second-review+
Comment on attachment 232890 [details] [diff] [review]
Accesskeys for Views pane; addressing comment #14

2r=jminta
Attachment #232890 - Flags: second-review?(jminta) → second-review+
Comment on attachment 232788 [details] [diff] [review]
Accesskeys for General pane; adding control attribute

Patch checked in on branch and trunk.
Comment on attachment 232774 [details] [diff] [review]
Accesskeys for Alarms pane; adding control attribute

Patch checked in on branch and trunk.
Comment on attachment 232890 [details] [diff] [review]
Accesskeys for Views pane; addressing comment #14

Patch checked in on branch and trunk.
Attachment #232890 - Flags: first-review+
All patches have landed.

Thanks!

-> FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
works fine for text fields however does not for checkbox - so, reopen

some problem with swiching tabs but I found out that the same is in Firefox so, need to check it, but at least checkbox are still not supported
(In reply to comment #30)
> works fine for text fields however does not for checkbox - so, reopen

Bug 348254 was already filed for this.
verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060929 Sunbird/0.3
Status: RESOLVED → VERIFIED
Blocks: 373530
No longer blocks: 373530
Component: Sunbird Only → Preferences
QA Contact: sunbird → preferences
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: