ko Search Feature Tracking for Firefox 2

RESOLVED FIXED

Status

Mozilla Localizations
ko / Korean
--
critical
RESOLVED FIXED
12 years ago
6 years ago

People

(Reporter: chris hofmann, Assigned: channy)

Tracking

({fixed1.8.1})

unspecified
fixed1.8.1
Dependency tree / graph
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: BD OK with Daum, Naver)

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
tracking bug to make sure we get things on the list below working correctly for
each locale:

Full Default Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not
(Reporter)

Updated

12 years ago
Summary: ko-KR → ko-KR Search Feature Tracking for Firefox 2
(Assignee)

Updated

12 years ago
Blocks: 349850
(Assignee)

Updated

12 years ago
No longer blocks: 349850
Depends on: 349850
(Assignee)

Updated

12 years ago
Blocks: 349850
No longer depends on: 349850
(Assignee)

Updated

12 years ago
No longer blocks: 349850
Depends on: 349850
(Assignee)

Updated

12 years ago
Depends on: 349390
(Assignee)

Updated

12 years ago
Depends on: 349389

Updated

12 years ago
Blocks: 350048
(Reporter)

Comment 1

11 years ago
just a note to make sure the yahoo code is correct
fr=moz1      %IDENTIFIER% when Yahoo is in the #1 search position
fr=moz2      %IDENTIFIER% when Yahoo is in the #2 search position
(Reporter)

Comment 2

11 years ago
Hi Channy,  I notice that Amazon search generates this query  http://www.amazon.com/gp/search/103-9872877-2921428?search-alias=aps&keywords=test
and points at the us-en Amazon site.  I guess we have done that in the past, but I'm wondering if there would be better subsitutions for on-line shopping in the ko build.   We might not be able to make these changes for 2.0, but should be thinking about what makes the most sense.
Whiteboard: bizdev-future look at amazon.com?
(Reporter)

Comment 3

11 years ago
Created attachment 236182 [details]
v1 ko search box test
(Reporter)

Comment 4

11 years ago
current search codes for daum and naver

http://search.daum.net/cgi-bin/nsp/search.cgi?q=test&w=tot&nil_ch=ffsr

http://search.naver.com/search.naver?query=test&where=j&frm=ff
(Reporter)

Comment 5

11 years ago
Created attachment 236185 [details]
update with daum and naver search query examples.

Channy/Mic, do you know if we have contact info, review, and approval on file for Daum and Naver?
(Reporter)

Comment 6

11 years ago
I know Asa made a recent presention to them on a visit to Korea. He might have contact info too.
(Reporter)

Updated

11 years ago
Flags: blocking-firefox2?
Whiteboard: bizdev-future look at amazon.com? → blocking on yahoo fr=moz1 code
Flags: blocking-firefox2? → blocking-firefox2+

Comment 7

11 years ago
Any news on the contact info for Daum and Naver?

Mic, if we don't get that info in time, we wouldn't block on that right? As the two already shipped in 1.5?
Severity: normal → critical
No longer depends on: 349389, 349390
OS: Windows XP → All
Hardware: PC → All
Summary: ko-KR Search Feature Tracking for Firefox 2 → ko Search Feature Tracking for Firefox 2
(Assignee)

Updated

11 years ago
Depends on: 346863
(Assignee)

Comment 8

11 years ago
(In reply to comment #1)
> just a note to make sure the yahoo code is correct
> fr=moz1      %IDENTIFIER% when Yahoo is in the #1 search position
> fr=moz2      %IDENTIFIER% when Yahoo is in the #2 search position
> 

Sorry for my delay. I have two things to fix in yahoo-kr.xml. One is suggestion url  , the other is to fix to fr=moz1. Right?
(Assignee)

Updated

11 years ago
QA Contact: admin
(Assignee)

Comment 9

11 years ago
(In reply to comment #5)
> Created an attachment (id=236185) [edit]
> update with daum and naver search query examples.
> 
> Channy/Mic, do you know if we have contact info, review, and approval on file
> for Daum and Naver?
> 

I have a contact point. 
Daum: Channy Yun, channy@daumcorp.com
Naver: Jaekwang Lee, leesop@nhncorp.com
(Assignee)

Comment 10

11 years ago
Created attachment 237679 [details] [diff] [review]
yahoo-kr.xml patch to fix search suggestion url and parameter.
(Assignee)

Comment 11

11 years ago
Created attachment 237680 [details] [diff] [review]
yahoo-kr.xml patch to fix search suggestion url and parameter.
Attachment #237680 - Flags: review?
Attachment #237680 - Flags: approval-l10n?
(Assignee)

Updated

11 years ago
Attachment #237679 - Attachment is obsolete: true

Updated

11 years ago
Depends on: 351817

Comment 12

11 years ago
hey all
BD has reviewed and we are good to go for FF2
Channy thanks for contacts at Daum and Naver, have you been in touch with them recently, can you confirm they are aware that we ship with their plug-ins
best
mic

Comment 13

11 years ago
Comment on attachment 237680 [details] [diff] [review]
yahoo-kr.xml patch to fix search suggestion url and parameter.

The parameter was fixed by benjamin in another bug, please make sure that you keep that.

r+ on the change of the suggest url.
Attachment #237680 - Flags: review?
Attachment #237680 - Flags: review+
Attachment #237680 - Flags: approval-l10n?
Attachment #237680 - Flags: approval-l10n+
(Assignee)

Comment 14

11 years ago
(In reply to comment #13)
> (From update of attachment 237680 [details] [diff] [review] [edit])
> The parameter was fixed by benjamin in another bug, please make sure that you
> keep that.
> 
> r+ on the change of the suggest url.
> 

I did it only for suggestion url. Is there another issues?
(Assignee)

Comment 15

11 years ago
(In reply to comment #2)
> Hi Channy,  I notice that Amazon search generates this query 
> http://www.amazon.com/gp/search/103-9872877-2921428?search-alias=aps&keywords=test
> and points at the us-en Amazon site.  I guess we have done that in the past,
> but I'm wondering if there would be better subsitutions for on-line shopping in
> the ko build.   We might not be able to make these changes for 2.0, but should
> be thinking about what makes the most sense.
> 

Chris, thanks for your comment. I contacted several korean shopping sites. But, I didn't get responses. (Also most of them are broken in Firefox because of non-standard web page.) So my community decided to contact web site to offer price comparision service such as http://danawa.co.kr. If they don't responce to me till RC1 lockdown, we will give up it.

Comment 16

11 years ago
Yahoo is fixed, list is ok.

Talking about Korea and shopping, is there any progress on the secure http front? Is it still mostly that special non-https protocol? If so, do you have any news on the implementation of that that we heard about a while ago?

Just asking because adding a non-secure shopping site would so not be Firefox.

Regardless, I'm closing this bug down now. If you get feedback from danawa in time, feel free to reopen.

Please test all plugins on a fresh profile in a nightly and VERIFY.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: blocking on yahoo fr=moz1 code → BD OK with Daum, Naver
Axel, should this be marked fixed1.8.1?

Comment 18

11 years ago
Note that:

http://lxr.mozilla.org/l10n-mozilla1.8/source/ko/browser/searchplugins/yahoo-kr.xml

Shows fr as set *twice* - once hardcoded and once using MozParam.  We should remove the hardcoded version...

Comment 19

11 years ago
(In reply to comment #14)
> (In reply to comment #13)
> > (From update of attachment 237680 [details] [diff] [review] [edit] [edit])
> > The parameter was fixed by benjamin in another bug, please make sure that you
> > keep that.
> > 
> > r+ on the change of the suggest url.
> > 
> 
> I did it only for suggestion url. Is there another issues?

Hrm. You did add the fr=moz1 hardocded parameter in this check-in. I reverted that in CVS now, please do a cvs diff -u before you commit changes and make sure that only those changes show up that are supposed to happen. That's a good practice in general, btw.

Reopening until I verified that my check-in does the right thing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 20

11 years ago
FIXED, please check all plugins on a nightly build and a fresh profile to VERIFY that they work as expected.
Status: REOPENED → RESOLVED
Last Resolved: 11 years ago11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
(Assignee)

Comment 21

11 years ago
(In reply to comment #20)
> FIXED, please check all plugins on a nightly build and a fresh profile to
> VERIFY that they work as expected.
> 

okay. i'll do that.
You need to log in before you can comment on or make changes to this bug.