Closed Bug 348860 Opened 19 years ago Closed 19 years ago

Display name used for addresses not in address book

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird2.0

People

(Reporter: bc, Assigned: mscott)

References

Details

(Keywords: fixed1.8.1, regression)

Attachments

(2 files)

the fix
760 bytes, patch
Bienvenu
: superreview+
Details | Diff | Splinter Review
[checked in on the branch] fix bad merge to the branch
1.05 KB, patch
Bienvenu
: superreview+
Details | Diff | Splinter Review
I had set Show only display name for people in my address book, however just noticed a mortgage spam mail whose email address was not displayed in mail preview even though they were not in my address book. This regressed at least since tb15.
this may have been broken by 251279.
good catch bob.
Blocks: 251279
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird2.0
Attached patch the fix — — Splinter Review
fix the regression we introduced in Bug 251279. Only set the display name as the label for the node if it is someone we know.
Attachment #234064 - Flags: superreview?(bienvenu)
Attachment #234064 - Flags: superreview?(bienvenu) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Mea culpa. Sorry.
This isn't quite fixed completely as the same problem exists in today's builds for newsgroups as well.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
and in normal mail as well. I looked at the history for mozilla/mail/base/content/msgHdrViewOverlay.js and nothing would cause the regression again.
Still broken in 2a1-0901; working correctly in 3a1-0831.
I still see this too on the branch.
Status: REOPENED → ASSIGNED
*** Bug 351830 has been marked as a duplicate of this bug. ***
the cvs-commit tool I use for landing on the trunk and the branch seems to have done a bad job with this patch. Either that or it was pilot error :). In any case, properly land the previous fix on the branch.
Attachment #237376 - Flags: superreview?(bienvenu)
Attachment #237376 - Flags: superreview?(bienvenu) → superreview+
fixed on the branch again.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Attachment #237376 - Attachment description: fix bad merge to the branch → [checked in on the branch] fix bad merge to the branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: