348975 - Tab strip color does not match OS theme

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060816 Minefield/3.0a1
Build Identifier: 

Looks like the new Winstripe tab strip goes together with Luna only. I suggest to use semi-transparent pngs to overlay the native color.

Reproducible: Always

Comment 1

[Dão Gottwald [:dao]]

Attachment: actual vs. expected appearance

Comment 2

[Dão Gottwald [:dao]]

Other examples where it looks odd:
http://img81.imageshack.us/img81/4144/crappygobuttoncu0.png
http://img53.imageshack.us/img53/4818/alltabod8.jpg

Comment 3

[ronin.achilles]

I agree.
While the effect of 'Depth' on the Tabstrip looks good, the color itself should be derived from the native background color of the theme/OS.

Comment 4

[Peter Kasting]

Neither of the problems in comment 2 seem like this bug.

The first issue is, in theory, fixed by the checkin for bug 347416 (haven't tested that).

The second issue I haven't seen a bug for; it should probably be filed as a separate bug.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> Neither of the problems in comment 2 seem like this bug.

There are other problems, too. Nevertheless, the tab strip color doesn't match the OS.

Comment 6

[Ria Klaassen (not reading all bugmail)]

Attachment: Screenshot of the problem

The new tabbox color makes a mismatch with the beige color of my toolbars.
It is color 240 240 230 in the middle and it changes gradually into color 239 236 217 on the right side.

Comment 7

[Jesse Maloney (jtmal0723 [at] gmail for email)]

Attachment: Non-Theme-Matching Tab Strip on Windows Classic

This is a screenshot showing the hard-coded tab strip color on Classic. I think there's a problem with the tabs too, are they supposed to be white, or should they match the theme more?

Comment 8

[Jesse Maloney (jtmal0723 [at] gmail for email)]

I think it's safe to say this can be marked as confirmed. Can someone do so please? I don't have the privs as of yet. Thank you

Comment 9

[Bryan]

Also the double horizontal lines under the tab and behind each tab look wrong.  Is that intentional?  The bottom horizontal line doesn't match OS theme color either.

~B

Comment 10

[Jesse Maloney (jtmal0723 [at] gmail for email)]

I don't believe anything in this new tab bar is os theme native.

and whoops... been forgetting the user agent
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060817 BonEcho/2.0b1 ID:2006081703

Comment 11

[Matt Cosentino]

Attachment: Semi-transparent Tab Strip Background

Here is an edit of the tab strip background to use semi-transparency instead of the Luna background color.

Comment 12

[Dão Gottwald [:dao]]

What has to be taken into account, too, is that WinXP themes tend to use gradients for toolbars:
http://img46.imageshack.us/img46/18/sshot1cf0.jpg

Hence it's not simply a native color + non-native semi-transparent image. Now I wonder, is there a container (with the native appearance) that can be *overlayed* (e.g. with attachment 234310 [details]) or does the new tab strip actually *replace* the native background?

Comment 13

[Dave Townsend [:mossop]]

*** Bug 351150 has been marked as a duplicate of this bug. ***

Comment 14

[Ria Klaassen (not reading all bugmail)]

The current tabstrip color (grey) matches the WinXP style Luna Silver fine (because the toolbars are also grey ), but does not go together with WinXP style Luna Blue (where the toolbars are beige by default).

Comment 15

[Dão Gottwald [:dao]]

(In reply to comment #14)

FWIW, this has become a meta bug, please see blocking bugs.

Comment 16

[Mike Connor [:mconnor]]

Fixed now.  We might still tweak, but this is resolved as long as it doesn't regress.