349859 - groupboxes don't follow native theming

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Robert Kaiser]

In current [win|gnome]stripe theme, groupboxes are always in a flat, rounded, XP Luna style, while they 1) should follow WinClassic when native theming can't be picked up if bug 313388 is still the way we want to go, and 2) they should follow the native theme where possible.

1) is easy to do, it's just some style rules in toolkit/themes/winstripe/global/groupbox.css - I'm sure some people would be upset once again though, just like they were in bug 313388

2) is probably the harder part, but it's also the part I'm completely unable to look on as I don't nearly understand any of the code.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Robert, this bug looks like a dupe of bug 236107.

Comment 2

[Robert Kaiser]

Henrik:
Actually not, bug 236107 looks more like a subset of this to me, it only talks about the color of the caption, while this bug is about appearance of the whole groupbox.

Comment 3

[Ryan A. C.]

for 2) We should probably be using GetThemeColor to get the BorderColorHint of Groupbox. (on windows at least, I don't know about the other platforms)

Comment 4

[[e-mail]]

Attachment: Make groupboxes square again on Windows 2000

Using the new :-moz-system-metric(windows-default-theme) selector, so that the Luna/Aero look only applies under, well, Luna or Aero ;-)

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 314584 [details] [diff] [review]
Make groupboxes square again on Windows 2000

This should be pretty safe.

Comment 6

[[e-mail]]

Checked in attachment 314584 [details] [diff] [review], although I don't think this is a complete fix.

Comment 7

[Dão Gottwald [:dao]]

Note that bug 403753 fixed this for Linux. A complete fix would probably involve native theming, on Windows at least.

Comment 8

[Szabolcs Horvát]

Currently group boxes have the correct look for both Windows XP style (rounded) and Windows Classic style (square).

But they have the incorrect look for Media Center style (square, while they should be rounded).  Is Firefox going to get back the correct rounded group-boxes for Media Center style?

Comment 10

[Kai Liu]

Comment 0 in this bug talked about making groupboxes look native on Windows Classic, and a patch to do precisely that has been checked in.  Any objections to me marking this bug resolved?  Bug 433566 can be used as the general implement-groupboxes-in-nsNativeThemeWin.cpp bug.

Comment 11

[Adam Guthrie]

Sounds reasonable. Assigning to Neil and marking as FIXED (since he fixed it). (Hopefully Neil is OK with this.)

Comment 12

[Robert Kaiser]

Reopening, as I filed it and I _intended_ to have it as exactly what the summary said, WinClassic was merely an example of where we aren't following it. We also should pull it from nsITheme on other themes or even Linux, for example, not hardcoding an appearance in the theme but coding it on nsITheme and possibly enabling us to pull in, say, Qt theme groupbox style if we ever support Qt, as we are already pulling stuff from nsITheme via -moz-appearance and not hardcoding stuff in the CSS theme, which is IMHO plainly wrong.

Comment 13

[Dão Gottwald [:dao]]

(In reply to comment #0)
> In current [win|gnome]stripe theme, groupboxes are always in a flat, rounded,
> XP Luna style, while they 1) should follow WinClassic when native theming can't
> be picked up if bug 313388 is still the way we want to go,

This has been fixed here.

> and 2) they should
> follow the native theme where possible.

There's now bug 433566 for that.