352971 - using_firebird.xhtml: wrong size of images urlbar.png and searchbar.png

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Francesco Lodolo [:flod]]

After this change https://bugzilla.mozilla.org/show_bug.cgi?id=346888, images are displayed with the wrong size.

For urlbar.png: 320x30 instead of 308x24
http://www.mozilla.org/projects/firefox/help/2.0/urlbar.png

For searchbar.png: 134x30 instead of 236x95
http://www.mozilla.org/projects/firefox/help/2.0/searchbar.png

Comment 1

[Mark Tyndall]

Attachment: alters sizes noted

Comment 2

[Steffen Wilberg]

Comment on attachment 238825 [details] [diff] [review]
alters sizes noted

We should remove the width and height attributes altogether so we can replace the images in the future, even post-release, without having to use the exact same dimensions.
(For instance, I regard the searchbar image as pretty large.)

The document will shift slightly when the images are loaded, but only the first time since the images are cached. This is different from Help in Firefox 1.0, where the documents would've jumped heavily because of the screenshots of the options dialogs and extensions/theme manager.

Comment 3

[Steffen Wilberg]

Must-fix for Firefox 2. Patch is simple, just remove the width and height attributes.

Comment 4

[Reed Loden [:reed]]

Attachment: Remove width and height attribs

As per comment #2 / comment #3, just remove the width and height attributes altogether.

Comment 5

[Steffen Wilberg]

Comment on attachment 239035 [details] [diff] [review]
Remove width and height attribs

Thanks, r=me.

Comment 6

[Axel Hecht [:Pike]]

(In reply to comment #3)
> Must-fix for Firefox 2. Patch is simple, just remove the width and height
> attributes.

... and affects each and every locale at the same size. Wouldn't it be easier to redo the screenshots to have the old size? Maybe just pad them with transparency.

Comment 7

[Francesco Lodolo [:flod]]

> Wouldn't it be easier to redo the screenshots to have the old size? Maybe just 
> pad them with transparency.

If you change size of online images this will affect at least italian locale: since we were so close to the cvs freeze, I saw the first patch proposed and changed using_firebird.xhtml with updated sizes.

Comment 8

[Steffen Wilberg]

Other locales are not affected unless they take the change from bug 346888 from 4 days ago, which changed the base URI of the help images. And if they take that, they should take this change as well.

Here are searches for the old dimensions:
http://lxr.mozilla.org/l10n-mozilla1.8/search?string=width%3D%2522320
http://lxr.mozilla.org/l10n-mozilla1.8/search?string=width%3D%2522134

(in reply to comment 7)
Francesco, this is getting relly difficult to fix if some (almost all) locales hardcode the old size and others (yours) the new size...

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 239035 [details] [diff] [review]
Remove width and height attribs

a=mconnor on behalf of drivers for 1.8 branch checkin.

Comment 10

[Mike Connor [:mconnor]]

gavin landed this branch and trunk

Comment 11

[timeless]

Comment on attachment 239035 [details] [diff] [review]
Remove width and height attribs

mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml 	1.41

MOZILLA_1_8_BRANCH:
mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml 	1.29.2.14

Comment 12

[Francesco Lodolo [:flod]]

(In reply to comment #8)
> Francesco, this is getting relly difficult to fix if some (almost all) locales
> hardcode the old size and others (yours) the new size...

I know... Unfortunately this is an inevitable consequence of the short time (4 days) left to localizers to make such big updates on the documentation (also en-US documentation is not perfect, see bug 352968 still marked as NEW).

Even this is not the right place, I think it's time to make some serious reflections about moving help out of the build process (I've already made my suggestions in a discussion on mozilla.dev.l10n).