Closed Bug 353141 Opened 13 years ago Closed 13 years ago

In Options/Preferences window, Globe (Content) icon image has top and right cutoff.

Categories

(Firefox :: Preferences, defect)

2.0 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3 alpha1

People

(Reporter: chengkhoon, Assigned: dao)

References

Details

(Keywords: regression, verified1.8.1.1, Whiteboard: [Fx2 theme change][Fx2.0.0.1])

Attachments

(5 files, 10 obsolete files)

15.07 KB, image/png
Details
21.06 KB, image/jpeg
Details
60.88 KB, image/png
Details
19.62 KB, image/png
moco
: review+
beltzner
: ui-review+
beltzner
: approval1.8.1-
Details
18.58 KB, image/png
moco
: review+
beltzner
: ui-review+
beltzner
: approval1.8.1-
Details
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060917 BonEcho/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060917 BonEcho/2.0

This is a regression of bug 352669. Since the globe image is replaced, the top and right is cutoff.

Reproducible: Always

Steps to Reproduce:
1. Goto Menu > Tools > Options..
2. Observe globe image on the 'Contents' tab
Actual Results:  
Globe image has top and right cutoff

Expected Results:  
Globe image should be round.
Blocks: NewTheme
Depends on: 352669
Keywords: regression
Whiteboard: [Fx2 theme change]
Version: unspecified → 2.0 Branch
Status: UNCONFIRMED → NEW
Ever confirmed: true
Adding a few more keywords to the summary, as I couldn't originally find this bug. It also exists on Mac OS X, so -> All/All
OS: Windows XP → All
Hardware: PC → All
Summary: In Options window, Globe image has top and right cutoff. → In Options/Preferences window, Globe (Content) icon image has top and right cutoff.
*** Bug 354052 has been marked as a duplicate of this bug. ***
This is not caused by CSS rules; it's cut off in the original image: chrome://browser/skin/preferences/Options.png.

A new image is going to be needed to fix this.
Attached image winstripe Options.png (obsolete) —
Attached image screenshot: fixed winstripe Options.png (obsolete) —
Attachment #239935 - Flags: review?
Attachment #239935 - Flags: approval1.8.1?
Attached image pinstripe Options.png (obsolete) —
I cannot test this.
Attachment #239937 - Flags: review?
Attachment #239937 - Flags: approval1.8.1?
I'll test your pinstripe one on the mac trunk.
Attached image pinstripe Options.png with drop shadow (obsolete) —
Actually, the drop shadow was already missing in the cut off image.
Attachment #239937 - Attachment is obsolete: true
Attachment #239939 - Flags: review?
Attachment #239939 - Flags: approval1.8.1?
Attachment #239937 - Flags: review?
Attachment #239937 - Flags: approval1.8.1?
dao, thanks for generating that first pinstripe image.

the globe looks better, but all the images are darker, and this is especially noticable on hover (over the globe)

compare your image to http://lxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/preferences/Options.png
the second pinstripe Options.png is also darker.  do you see what I mean?

(fyi:  I like the drop shadow!)
Attachment #239939 - Attachment is obsolete: true
Attachment #239940 - Flags: review?
Attachment #239940 - Flags: approval1.8.1?
Attachment #239939 - Flags: review?
Attachment #239939 - Flags: approval1.8.1?
(In reply to comment #12)
> the second pinstripe Options.png is also darker.  do you see what I mean?

Not sure.
The hover/selected icon is darker; and both icons are darker than the winstripe ones. But I think this was the case with the old icons, too.
missed comment 11 ...

(In reply to comment #11)
> compare your image to
> http://lxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/preferences/Options.png

I'm still not sure. I don't see much of a difference. But I'll lighten the hover image.
Attached image pinstripe Options.png (obsolete) —
Attachment #239940 - Attachment is obsolete: true
Attachment #239945 - Flags: review?
Attachment #239945 - Flags: approval1.8.1?
Attachment #239940 - Flags: review?
Attachment #239940 - Flags: approval1.8.1?
dao, thanks for the new version of Options.png for pinstripe, but it still appears to be darker than the current version.  At least, it is noticable on my mac.  (See the screen shot I just attached.)

the only reason I'm being such a stickler here on brightness, is I remember there being a lot of attention paid to these icons during the theme refresh.

I can't find a relevant bug with a discussion about the brightness, and it might have concerned the brightness of Toolbar.png (http://lxr.mozilla.org/mozilla1.8/source/browser/themes/pinstripe/browser/Toolbar.png) and not Options.png, but I still think we want to be mindful of the brightness level.

jay / mconnor:  can you weigh in here?
Assignee: nobody → bugzilla
Attached image pinstripe Options.png (obsolete) —
okay, what about this?
Attachment #239945 - Attachment is obsolete: true
Attachment #240043 - Flags: review?
Attachment #240043 - Flags: approval1.8.1?
Attachment #239945 - Flags: review?
Attachment #239945 - Flags: approval1.8.1?
Attached image pinstripe Options.png (obsolete) —
brighter again
Attachment #240043 - Attachment is obsolete: true
Attachment #240046 - Flags: review?
Attachment #240046 - Flags: approval1.8.1?
Attachment #240043 - Flags: review?
Attachment #240043 - Flags: approval1.8.1?
Status: NEW → ASSIGNED
Comment on attachment 240046 [details]
pinstripe Options.png

Seth, if this is the same brightness, request approval.

Dao, please only request approval after you've confirmed that it's the one you want to sub in.
Attachment #240046 - Flags: review?(sspitzer)
Attachment #240046 - Flags: review?
Attachment #240046 - Flags: approval1.8.1?
Attachment #240046 - Flags: approval1.8.1-
Comment on attachment 240046 [details]
pinstripe Options.png

> Seth, if this is the same brightness, request approval.

unfortunately, the brightness is not the same.
Attachment #240046 - Flags: review?(sspitzer) → review-
Attachment #239935 - Flags: approval1.8.1?
(In reply to comment #22)
> unfortunately, the brightness is not the same.

You mean all the icons, not just the globe. Right? I think I've only just understood the problem.
Attachment #240046 - Attachment is obsolete: true
Attachment #240452 - Flags: review?
Attachment #239935 - Attachment is obsolete: true
Attachment #239936 - Attachment is obsolete: true
Attachment #240453 - Flags: review?
Attachment #239935 - Flags: review?
Attachment #240453 - Attachment filename: Options-win.png → Options.png
> You mean all the icons, not just the globe. Right? 

yes, sorry for not clarifying.

in your last pinstripe Options.png, the image looks good, except that the globe is now too bright (the rest of the icons match.)

I'm comparing to:
http://lxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/preferences/Options.png
(In reply to comment #26)
> I'm comparing to:
> http://lxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/preferences/Options.png

Assuming that image is being used now, the hovered globe is way too dark me thinks
Attached image pinstripe Options.png, darker (obsolete) —
Attachment #240540 - Flags: review?
Attached image pinstripe Options.png, fainter (obsolete) —
This is probably the closest one to http://lxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/preferences/Options.png

If you ask me, the previous one fits better. But it's up to you.
Attachment #240541 - Flags: review?
Attachment #240541 - Attachment filename: Options_.png → Options.png
> If you ask me, the previous one fits better. But it's up to you.

I think you are right, the brighter one fits better.  

I'll test it out in my build, and if it looks good, and land it on the trunk.

thanks for your patience, as always!
Attachment #240452 - Flags: ui-review?(beltzner)
Attachment #240452 - Flags: review?
Attachment #240452 - Flags: review+
Attachment #240453 - Flags: ui-review?(beltzner)
Attachment #240453 - Flags: review?
Attachment #240453 - Flags: review+
Flags: blocking-firefox2?
Attachment #240453 - Flags: ui-review?(beltzner) → ui-review+
Flags: blocking-firefox2? → blocking-firefox2-
Whiteboard: [Fx2 theme change] → [Fx2 theme change][rc ridealong]
fixed on the trunk.  thanks again, Dao!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 alpha1
Why now fx3a1 as target milestone? beltzner added [rc ridealong] to the status whiteboard.
Attachment #240452 - Flags: approval1.8.1?
Attachment #240453 - Flags: approval1.8.1?
Whiteboard: [Fx2 theme change][rc ridealong] → [Fx2 theme change]
Comment on attachment 240452 [details]
pinstripe Options.png, correct gamma chunk

mconnor and schrep say "nein" to image changes this late in the game. Maybe we can get it in a 1.8.1.1 release?
Attachment #240452 - Flags: ui-review?(beltzner)
Attachment #240452 - Flags: ui-review+
Attachment #240452 - Flags: approval1.8.1?
Attachment #240452 - Flags: approval1.8.1-
Attachment #240453 - Flags: approval1.8.1? → approval1.8.1-
Attachment #240452 - Flags: approval1.8.1.1?
Attachment #240453 - Flags: approval1.8.1.1?
Not blocking 2.0? Are you joking?
Does "approval1.8.1.1?" make this bug appear on an appropriate list? Or should this bug reopened therefor? Or is there anyone I can ask directly for approval?
Flags: blocking1.8.1.1?
Whiteboard: [Fx2 theme change] → [Fx2 theme change][fix in hand, already on trunk][Fx2.0.0.1]
Flags: blocking1.8.1.1? → blocking1.8.1.1+
Comment on attachment 240452 [details]
pinstripe Options.png, correct gamma chunk

approved for 1.8 branch, a=dveditz for drivers
Attachment #240452 - Flags: approval1.8.1.1? → approval1.8.1.1+
Attachment #240453 - Flags: approval1.8.1.1? → approval1.8.1.1+
mozilla/browser/themes/pinstripe/browser/preferences/Options.png 1.4.4.6

I suppose the winstripe image is already in (I copied it over here but didn't get it listed on commit)?
Mano or Seth: can one of you land these?
Whiteboard: [Fx2 theme change][fix in hand, already on trunk][Fx2.0.0.1] → [Fx2 theme change][need branch landing][Fx2.0.0.1]
mozilla/browser/themes/winstripe/browser/preferences/Options.png 	1.3.8.5
Keywords: fixed1.8.1.1
Whiteboard: [Fx2 theme change][need branch landing][Fx2.0.0.1] → [Fx2 theme change][Fx2.0.0.1]
Verified fixed for 1.8.1.1. on Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1 ID:2006120418 and Linux Fedora FC6
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.