353590 - extra space in info text in updater (between text and ellipsis) ex: "a few moments ..."

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[(not reading, please use [e-mail] instead)]

extra space in info text in updater (between text and ellipsis)  ex:  "a few moments ..." 

This comes from bug #305390

for tbird, the string is in:

/mail/locales/en-US/updater/updater.ini, line 4 -- Info=Thunderbird is installing your updates and will start in a few moments ...

for firefox, the string is in:

/browser/locales/en-US/updater/updater.ini, line 4 -- Info=Firefox is installing your updates and will start in a few moments ...

I don't think we want the space between moments and ..., right?

assigning to beltzner for string ui-r.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot from tbird

Comment 2

[Scott MacGregor]

Yeah that space doesn't look right. Thunderbird isn't under a string freeze so I can still fix this for thunderbird if beltzner says it's ok.

Comment 3

[(not reading, please use [e-mail] instead)]

scott, see bug #353679 for the same issue, but for firefox

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix for thunderbird

removes the extra space before "..."

Comment 5

[Scott MacGregor]

Comment on attachment 239782 [details] [diff] [review]
proposed fix for thunderbird

I'll check this in. Thanks for the patch!

Comment 6

[Scott MacGregor]

fixed on the branch and trunk. Thanks Magnus!

Comment 7

[Ton [:Tonnes]]

Happy to see this change. However, and it may sound weird, so far I've found this space to be useful for the nl locale (at least possibly, and for some platforms) as its string was almost too wide to fit the pane, which seems to have a fixed width. To be precise: chances now are that the last word including the dots move to a next non-displayable line for this locale, while otherwise only the dots would, making it look less bad or not even be noticed. (See attachment 219867 [details] from another bug to get an impression)

Considering the fact this 'solution' was critical anywyay, but even more because several locales appear to be using strings here that are even longer than the one for nl, I'd like to see the current pane either to be made a little wider, higher (capable of showing 2 lines), auto-resizing, or its width made localizable. Is this worth a new bug or is it best to add this comment to bug 324758, even though nobody is working on that yet?

Comment 8

[(not reading, please use [e-mail] instead)]

Ton, see bug #336528: "software update installation progress dialog doesn't stretch to fit contents (cut short, text is truncated)"