355547 - tag color not always showing up in thread pane

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[(not reading, please use [e-mail] instead)]

tag color not always showing up in thread pane

I'll attach a screen shot.

I'm using version 2 beta 1 (20061005) tbird on mac os x.  but I see the same bug on recent branch build on windows.

the way I first noticed this was I was tagging message in my inbox and the thread pane was not reflecting any of the tags colors.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: screen shot from tbird windows xp (latest nightly off the 2.0 branch)

Comment 3

[(not reading, please use [e-mail] instead)]

it appears that things work better for me with mail on a local folder, compared to my secure imap inbox on mail.mozilla.com.

Comment 4

[David :Bienvenu]

Ah, that could be because the moco imap server returns all keywords in upper case - see bug 354726

Comment 5

[(not reading, please use [e-mail] instead)]

thanks for the info david.  

I'll wait until the fix for bug #354726 lands to see if this is fixed.

Comment 6

[(not reading, please use [e-mail] instead)]

david, since bug #354726 was fixed yesterday, tbird version 2 beta 1 (20061006) nightly should have your fix, right?  I'm still seeing this bug.

Comment 7

[(not reading, please use [e-mail] instead)]

> I'm still seeing this bug.

actually, tbird on windows xp seems ok (version 2 beta 1 (20061008).  I'll re-check my mac.

david, is it possible that I could have the incorrect cased tag stored in my .msf file for certain messages, which is why I still see this on my mac?

Comment 8

[David :Bienvenu]

with the changes I checked in to ignore the case of the keywords, what's stored in the .msf file shouldn't matter, at least w.r.t. the case of the keywords.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: screen shot from my windows tbird (notice the one tagged important message without color)

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of that message, notice that the thread pane has "Important", but their is no "Tags:" header in the UI

Comment 11

[(not reading, please use [e-mail] instead)]

david, please see those last two screen shots from the latest branch nightly.

unfortunately, I just checked on the latest branch tbird nightly on my mac, and only for some instances (where the row color doesn't match the tag color) is it a case of a "missing" (?) tag.

on my mac, i have messages where the "Tags:" header matches the tag column, yet the row is still not the tag color.

any ideas?  anything I can do to help you figure out?  Should I move my .msf to the side?

Comment 12

[David :Bienvenu]

actually, the first thing to do could be to generate an imap protocol log of a session where you click on that folder, so I can see what the server says...although, if you're not on the new MoCo server yet, then that won't tell me anything (and moving away the .msf file will lose all your tags...)

Have you been adding and removing tags? Or just applying tags? I'm wondering if we're getting into a situation where there are leading or trailing spaces in the keywords, such that we have " Important" or "Important ". Without debugging it, I couldn't tell for sure.

Comment 13

[(not reading, please use [e-mail] instead)]

I'm on the new moco server.  I'll go get you a imap log and attach it.

Comment 14

[(not reading, please use [e-mail] instead)]

Attachment: log where I start up with the imap inbox selected (with the problem message), and then I click on a "good" message with a tag and then the "bad" message with the tag problem.

Comment 15

[(not reading, please use [e-mail] instead)]

> Have you been adding and removing tags? Or just applying tags?

I don't think I've created or removed any tags, but I may have when this feature originally landed, to try it out.  but that would have a been a while ago.

for this bug, i have just been applying (and removing) them.

Comment 16

[David :Bienvenu]

so both messages have the $label1 flag set on the server, which is "Important".  Moving aside the .msf file will probably fix your problem. But I don't know what's going on. Since this is the new moco server, does that mean this profile has only been accessed with TB 2.0? I'm trying to think how it could be some confusion between old-style labels and new style tags...hmm, oooh, I wonder if the code that tries to see if we already have a $label style keyword does so in a case-insensitively way...

Comment 17

[Marcia Knous [:marcia]]

I am seeing this when I test the Tbird 2 Beta 1 candidate on the Mac. Here are my steps to repro:

1. Download the Tbird 1507 build.
2. Tag messages in my IMAP folder, newsgroups, and blogs
3. Move to Tbird 2  Beta 1 build

Result: My tags for important mail are there in theory, but have lost their color highlighting (red for important) I do not see the same thing with the tags I have applied to my newsgroups and blog posts. Like Seth, I am using my mozilla.com IMAP account.

Comment 18

[David :Bienvenu]

Attachment: possible fix

make looking for labels case-insensitive...

Comment 19

[David :Bienvenu]

ok, this fix landed on the 1.8.1 branch and trunk...let me know if it doesn't fix this issue.

Comment 20

[Reid D Rivenburgh]

I'm currently using: version 2 beta 1 (20061218).  I haven't been a big user of tags, but I just made a new one and created a filter to auto-tag messages.  I noticed the same problem with the tag color not always being used.  As with the original reporter, some are colored properly but some are not (the messages in question definitely all appear to have the same tag).  I'm not sure if it's just a coincidence, but some messages I have that are marked "To Do" appear to all be colored correctly.  Maybe it's only custom tags?

I'm using an IMAP server, which reports this when I telnet to it:  Cyrus IMAP4 v2.2.12-CCN-5-RPM-2.2.12-2.  If that helps....  Rebuilding the folder's index didn't do anything.  

Comment 21

[Tristan Harward]

I have just seen this again in Thunderbird 2 Beta 2 (Build 20070116). I'm not sure if this fix made it in, or if the bug still exists with the fix applied.

Seems that the problem is only with the coloring, as the tag is picked up correctly and displayed in the "Tags" column, the message headers, shows up in searches, and even in the view for the tag. The coloring is simply not there.

Just tested on another TB2.0b2 client on my laptop, the same exact problem occurs with the same exact messages. Tags are persisted over the IMAP server and onto the new client, but coloring doesn't show up.

After fiddling with the tags, adding new ones, removing some, I could get some (previously problematic) messages to be colored again. However the problem still happens with other messages even when I can get one to work correctly. Note that most messages (~75%) all tags color normally.

Also, this seems to be a problem with a couple specific tags, in the screenshot it was 7 and 8 labeled "School" and "Tara". The rest, and sometimes (sometimes not) newly created tags colored correctly. I have also noticed as in #20 above that the five original tags (regardless of their names, I have renamed them) work perfectly on all affected messages.

I am using Courier IMAP on my own server, so I can do tests on both ends if needed. First, does someone know if the patch above is in this build? But somehow I do not think it's related to the tag case; the tag works in all other respects but this.

Comment 22

[Tristan Harward]

Attachment: Screenshot of 2.0b2 non-colored tags.

Comment 23

[Tristan Harward]

Forgot to mention, OS is Windows XP SP2, this isn't Mac specific.

Comment 24

[Karsten Düsterloh]

That's probably bug 366503, bug 368370 or some variation of those.

Comment 25

[Tristan Harward]

That doesn't change the fact that this isn't resolved and the patch did not have any effect on the problem...

If everything is taken care of upstream at those bugs, should I worry about reopening this one? I'm guessing no...

Comment 26

[Tristan Harward]

Can someone please answer my question? If that gets fixed in 366503 will it get ported to TB? If not, can we PLEASE re-open this bug as it has still not been resolved?

Comment 27

[Karsten Düsterloh]

When I fix 366503, I'll fix it for both SM and TB. I hope to get to it this week.

Comment 28

[Tristan Harward]

Excellent, thank you :-)

Comment 29

[Scott MacGregor]

flag cleanup

Comment 30

[Marcia Knous [:marcia]]

verified fixed on the 1.8 branch using the Tbird cand build, version 2.0.0.0 (20070326). I tested on both my PPC mac with an older Tbird profile as well as an Intel Mac with a newer profile. In both cases I can see the tag colors in the thread pane. Add branch verified keyword.