35606 - incorrect usage of mouseup on xul widgets

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Kathleen :Brade]

I was talking with joki about event handling and he reminded me that clicking on 
controls and links should actually trigger on mouseclick rather than mouseup.  I 
happened to later notice that in xulBindings.xml there is code like this:

  <handler type="mouseup" value="this.checked = !this.checked;" />

joki confirmed that this is a bug (as written above).

Comment 1

[John Morrison]

*** Bug 37151 has been marked as a duplicate of this bug. ***

Comment 2

[Yossi Oren]

*** Bug 40553 has been marked as a duplicate of this bug. ***

Comment 3

[don]

Hmmm, this might be bad.  Real bad.  We should fix this for beta 2.

Comment 4

[Peter Trudelle]

[need info] What will the user see that is bad?

Comment 5

[John Morrison]

A standard use case is for a user to mousedown on a checkbox or radio, change
their mind, drag away from the control and mouseup -- result is no change to 
the state of the control.

The problem is that when they mouseup "just somewhere else" and that is over
a checkbox/radio or its label, they have now changed this other control's state 
-- likely _without_realizing_ that they have done so (try it out in some of
the mail pref dialogs).

That's not good (especially as this contradicts a standard UI behaviour).

Comment 6

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

fixed

Comment 8

[Blake Ross]

wfm on 60608 win98, win2k and linux.  waiting for mac verification...

Comment 9

[John Morrison]

verified on mac. Thanks Blake.

Comment 10

[Blake Ross]

*** Bug 43760 has been marked as a duplicate of this bug. ***