Closed Bug 360573 Opened 19 years ago Closed 1 year ago

Lack of license information for images used in Camino

Categories

(Camino Graveyard :: General, defect)

Product:
Camino Graveyard
Component:
General
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: reikonmusha, Assigned: alqahira)

References

Details

(Whiteboard: [needs readmes from ss])

Attachments

(4 files, 1 obsolete file)

Image archaeology and inventory
7.10 KB, text/plain
Details
removal of image groups 2 and 3 (with project changes for 3) [checked in]
13.05 KB, patch
stuart.morgan+bugzilla
: superreview+
Details | Diff | Splinter Review
Draft README text + project change
10.20 KB, patch
Details | Diff | Splinter Review
README v2
1.86 KB, patch
alqahira
: review-
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061110 Camino/1.1a1+ Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061110 Camino/1.1a1+ every image file should have an accompanying license file in the same directory that relates to it Reproducible: Always Steps to Reproduce: 1. Try to find a license file for the perty images 2. Cry because it doesn't exist :P Actual Results: Repressed anxiety, aggression and a desire to raid the fridge for foodstuffs.
Confirming, because we've discussed this situation before. I don't think we need 1 per image, just one per folder. In theory all the non-logo images are tri-licensed, but that may not be the case.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Camino1.2
I consider the fact that the licensing status of our images is up in the air to be a serious problem, and I'd really like this to be resolved soon. I feel pretty strongly that everything but the icon should be tri-licensed. Jasper, can you give us an official statement the licensing please?
Jasper emailed me about this recently and we're going to sync up in the next month or so and get official licensing information.
Assignee: nobody → samuel.sidler
I actually did some CVS archaeology on the images a while back; not all of them are his, or clearly his (due to our absolutely awful sucky checkin comments without bug numbers or image authors). Anything that's substantially one person's work but also changed but not completely changed is listed with both authors. Any bit of info that's not clear has a question mark next to it. There are probably a dozen unused images we need to CVS remove, and a few chrome images that are living in toolbar that should be moved at some point.
The idea, at least to me, is to make that I'm marked as the creator of the images but that all of the images (inlcuding the source photoshop) files will be transfered to the Camino project. Enabling anyone to use them with the terms of the project. As I will be attending the Camino Meat-up after WWDC I think it might be a good to try and talk this over then.
Mass un-setting milestone per 1.6 roadmap. Filter on RemoveRedonkulousBuglist to remove bugspam. Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.
Target Milestone: Camino1.6 → ---
I need comments from the following people confirming that they approve of their graphics/icons being licensed under the tri-license (MPL/GPL/LGPL), excluding the logo: * Simon Fraser * Jasper Hauser * Jon Hicks * Stuart Morgan * Mike Pinkerton * "Cole who sites next to Stuart" To meet compliance, we can simply add one text file that states the license for all graphics. Additionally, we should remove any unused graphics. When you comment, please say something like the following (or just copy and paste it): "I confirm that any and all graphics I've made and contributed to the Mozilla/Camino project are licensed under the tri-license."
I confirm that any and all graphics I've made and contributed to the Mozilla/Camino project are licensed under the tri-license!
Same here. I confirm that any and all graphics I've made and contributed to the Mozilla/Camino project are licensed under the tri-license!
I spoke to Cole, and he confirmed that all graphics he made and that I contributed on his behalf to the Mozilla/Camino project are licensed under the tri-license.
I confirm that any and all graphics I've made and contributed to the Mozilla/Camino project are licensed under the tri-license.
I confirm that any and all graphics I've made and contributed to the Mozilla/Camino project are licensed under the tri-license.
Attached file List of unused files (obsolete) —
Can we confirm that the files listed in this attachment are no longer used? And, if so, we'll need a project patch to remove them.
Comment on attachment 278437 [details] List of unused files You have 4 different sets of images in that list: 1. Images already cvs removed since my initial list: resources/images/chrome/SearchCancel_small.tiff resources/images/chrome/SearchLeft_small.tiff resources/images/chrome/SearchMiddle_small.tiff resources/images/chrome/SearchPopUp_small.tiff resources/images/chrome/SearchRight_small.tiff 2. Images which are unused and not packaged and just need cvs removal: resources/images/toolbar/bm_del.tif resources/images/toolbar/bm_info.tif resources/images/toolbar/bookicon.tif resources/images/toolbar/searchWeb.tif resources/images/toolbar/search_the_web.tif resources/images/toolbar/showall.tif PreferencePanes/Personal/Personal.tiff § 3. Images which are unused and need a *project patch* + cvs removal: resources/images/toolbar/bm_book.tif resources/images/toolbar/bm_reveal.tif 4. Images which *are used* but live in the wrong place in the cvs hierarchy: resources/images/toolbar/addressbook_icon.tif should be in chrome resources/images/toolbar/bm_folder.tif should be in chrome resources/images/toolbar/bookmarkmenu_icon.tif should be in chrome resources/images/toolbar/bookmarktoolbar_icon.tif should be in chrome resources/images/toolbar/brokenbookmark_icon.tif should be in chrome† resources/images/toolbar/historyicon.tif should be in chrome resources/images/toolbar/rendezvous_icon.tif should be in chrome resources/images/toolbar/top10_icon.tif should be in chrome resources/images/toolbar/bm_sep.tif should be in chrome‡ § The entire Personal prefPane directory contents should be cvs removed † This could probably be renamed site_error_icon.tif ‡ originally listed as unused; that was in error Images in 4 should probably be handled in a separate bug. 2 and 3 can be done here (and 1 is already done, of course).
Attachment #278437 - Attachment is obsolete: true
> PreferencePanes/Personal/Personal.tiff § [...] > § The entire Personal prefPane directory contents should be cvs removed I filed bug 393901 on cvs removing the Personal prefPane detritus.
(In reply to comment #14) > Images in 4 should probably be handled in a separate bug. Bug 398589 filed on that.
(In reply to comment #14) > 4. Images which *are used* but live in the wrong place in the cvs hierarchy: [...] > resources/images/toolbar/bm_sep.tif should be in chrome‡ > > ‡ originally listed as unused; that was in error No, I was correct to begin with; somehow I got that confused with bm_separator when doing all the double-checking. This one is the 0.8-era "add a separator" button that *is* unused; it's part of group 2 (revised below). 2. Images which are unused and not packaged and just need cvs removal: resources/images/toolbar/bm_del.tif resources/images/toolbar/bm_info.tif resources/images/toolbar/bm_sep.tif resources/images/toolbar/bookicon.tif resources/images/toolbar/searchWeb.tif resources/images/toolbar/search_the_web.tif resources/images/toolbar/showall.tif
I'll get a patch up for 2 & 3 in the next few days. (4's historyicon.tif should really be named history_icon.tif to be in sync with the other manager collection icons, but it's also used elsewhere in code, so it'll need a new bug if we want to fix it.)
Comment on attachment 284678 [details] [diff] [review] removal of image groups 2 and 3 (with project changes for 3) [checked in] rs=smorgan
Attachment #284678 - Flags: superreview? → superreview+
Comment on attachment 284678 [details] [diff] [review] removal of image groups 2 and 3 (with project changes for 3) [checked in] Landed on the trunk and MOZILLA_1_8_BRANCH. At this point, all the unused images should be gone from those two branches, and all the images should live (more-or-less) in the right place. The only thing left here, I think, is for Sam to draw up a text file to live in resources/images explaining the images are tri-licensed with the exception of the logo/app icon (we can also ship it in the bundle if we want, I suppose). I'll move comment 18 into one of our existing "rename images" bugs.
Attachment #284678 - Attachment description: removal of image groups 2 and 3 (with project changes for 3) → removal of image groups 2 and 3 (with project changes for 3) [checked in]
Status: NEW → ASSIGNED
Whiteboard: [needs readmes from ss]
We should finish this for 1.6.
Flags: camino1.6?
This doesn't need to block, but we really should get Sam to write that README ;)
Flags: camino1.6? → camino1.6-
Here's a draft readme file to live at the root of our resources/images/ folder; the text is a first stab to get us going, so please be liberal with comments and requirements. The file is named README to facilitate mxr's auto-display when browsing (see http://mxr.mozilla.org/mozilla/source/camino/flashblock/ for an example) and the OS should do the right thing when it ends up on a user's disk. The patch also includes project changes to ship the README file in Contents/Resources so that anyone browsing the bundle for image files can easily become aware of the licensing. This should cover anyone obtaining the images via cvs, the tarball, mxr/lxr, and the app itself.
Assignee: samuel.sidler → alqahira
Attachment #303905 - Flags: review?(samuel.sidler)
Comment on attachment 303905 [details] [diff] [review] Draft README text + project change Er, this doesn't exactly cover our PreferencePanes/ hierarchy or resources/package/; we need to decide what to do there, too.
Attached patch README v2 — — Splinter Review
I think need to use the full license header (albeit, modified) and list all contributors. Something more like this.
Attachment #304412 - Flags: review?(alqahira)
Comment on attachment 304412 [details] [diff] [review] README v2 I don't know that we need to use the full license headers; of the themes in the tree, toolkit/themes and browser/themes just use a LICENSE: All files in this directory are assumed to be licensed under the tri-license (MPL/GPL/LGPL) used throughout this codebase. (http://mxr.mozilla.org/mozilla/source/browser/themes/LICENSE) and Classic and Modern still have the old readmes from ben@netscape and pixeljockeys@netscape berating people not to fubar the themes. I'd propose instead a LICENSE file that looks mostly like mine (which, unlike browser/toolkit, provides a link to the tri-license), with the addition of a list of the contributors.
Comment on attachment 304412 [details] [diff] [review] README v2 This isn't going to work, since it doesn't account for the logo images being different.
Attachment #304412 - Flags: review?(alqahira) → review-
Comment on attachment 303905 [details] [diff] [review] Draft README text + project change This likely won't apply any more, and it doesn't address the issue of the PreferencePanes/ hierarchy or resources/package/; we need to decide what to do there, too.
Attachment #303905 - Flags: review?(samuel.sidler)
Also, if we're going to be listing image contributors individually, 1) we'll need to remember to update this file with every new/removed (and possibly changed, as well) image, and 2) how do we determine "contributors"? * people submitting new, original files (e.g. bug 201723) * people submitting new files based derived from editing an existing file (e.g. bug 287709, bug 419378) * people making some degree of tweaks to existing files (e.g. bug 348065, bug 423474, bug 374623) * some of the above * all of the above
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: