361568 - [cocoa-cairo] 8px or 16px wide icons/images mis-rendered on 10.3.9 (favicons, close buttons, tab edges)

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Stefan [:stefanh]]

Firefox/SeaMonkey trunk, Mac OS 10.3.9 ppc.

After the switch to cairo, icons in menus etc are mis-rendered. Looking at the  icons, it seems that the first 20-25% of the image is cut off and added to the right.

This is probably 10.3.9-only.

Comment 1

[Stefan [:stefanh]]

Attachment: Screenshot of Firefox window

Note the favicon, the tab icons and the search menu icons.

Comment 2

[Hiro]

Does bug361299 relate?

Comment 3

[Stefan [:stefanh]]

(In reply to comment #2)
> Does bug361299 relate?
> 

Might be. Do you see the issue as well? Not that many people are on 10.3.9 anymore.

Comment 4

[Hiro]

(In reply to comment #3)
> Might be. Do you see the issue as well? Not that many people are on 10.3.9
> anymore.
Yes, I use 10.3.9.
This problem has reproduced. 

Comment 5

[Alfred Kayser]

Yes, bug 361299 does related, so DUP to that one.
See Comment #3 (https://bugzilla.mozilla.org/show_bug.cgi?id=361299#c3) in there on why this is failing.

*** This bug has been marked as a duplicate of 361299 ***

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This doesn't have anything to do with the icon decoder.  The icon decoder decodes an internal format used for images that we get from the OS (things like icons for a specific file type, or icons that go on an OK/Cancel button).

Comment 7

[jonathan chetwynd]

David, 

this bug may not be a dupe of 361299, but hasn't this bug been fixed?

description and comments #1 #3 #4 all suggest it is 10.3.9 specific.

cheers

propose resolving as fixed, unless there is further comment...

Comment 8

[Stefan [:stefanh]]

(In reply to comment #7)
> David, 
> 
> this bug may not be a dupe of 361299, but hasn't this bug been fixed?
> 
> description and comments #1 #3 #4 all suggest it is 10.3.9 specific.
> 
> cheers
> 
> propose resolving as fixed, unless there is further comment...
> 

If you read the comments in bug 361299 you would have noticed that this bug isn't fixed...

Comment 9

[Stefan [:stefanh]]

Attachment: Testcase, unordered list with "list-style-image" set

So, this is not restricted to the ui. It can also be seen in plain xhtml (and html I guess). We display images in xul menus et al with the css property "list-style-image". It seems that those images are mis-rendered. This can also be seen in Camino.

Comment 10

[Stefan [:stefanh]]

Attachment: testcase image, 16x16

I'm just going to attach a few images to use in a new testcase...

Comment 11

[Stefan [:stefanh]]

Attachment: 32x32 image

Comment 12

[Stefan [:stefanh]]

Attachment: 64x64 image

Comment 13

[Stefan [:stefanh]]

Attachment: Testcase, 3 images of different size

It looks like only 16x16 images are rendered wrong. I checked 6x6 and 10x10 and they look OK.

Comment 14

[Stefan [:stefanh]]

OK, my bad :-(

It seems that all 16x16 icons/images (png/gif tested) is misrendered. Not just icons in lists. One can see it by just loading http://www.mozilla.org/images/mozilla-16.png ... Sigh, sorry for all the spam. I'll be really careful before I say anything from now on.

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: screenshot of 16x43 gif

Not just 16x16 images, apparently :(  This is a 16x43 GIF that I encountered tonight.

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: actual image displayed in Attachment #255658

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Apparently it's being 16px wide that's the issue; rotating that image to 43x16px produces an image that displays properly,

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

8px-wide images, too; see http://english.aljazeera.net/news/images/topNewsblts.gif

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Adding some UI features which exhibit this bug back to the summary to help catch dupes.

Comment 21

[Hiro]

In Cairo 1.4.10, this problem disappeared. 

Mac OS X 10.3.9
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a6pre) Gecko/20070630 Minefield/3.0a6pre

Comment 22

[Hiro]

The support of 10.3.x did drop by bug 385221. 
INVALID?