362798 - [Mac] Ctrl+click on Home button loads home page in addition to showing context menu

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Ctrl+click the Home button.

Expected: A context menu appears (with items like "Customize...").

Actual: A context menu appears, and the home page is loaded in the current tab.

See bug 361240 for discussion of the event-handling change that caused this regression and other regressions where Ctrl+click does something other than opening a context menu.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: "Fix" v.1

Comment 2

[Jesse Ruderman]

The reload button and back/forward buttons have a similar problem.  Do you want to fix them all with a single patch?

Comment 3

[Phil Ringnalda (:philor)]

"Lets wait and see how the approach in attachment 247507 [details] [diff] [review] does in review."

I'm perfectly capable of turning checkForMiddleClick() into checkForMiddleClickOrIfdefXP_MACOSXThenCheckForMetaKeyToo(), but a world where I didn't have to (a world where I also wouldn't have to personally contact the author of any toolbar-button-adding extension I wanted to use, to ask that he alter it to work with the way I right-click) would be a prettier, shinier, happier world.

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 247507 [details] [diff] [review]
"Fix" v.1

Gah, first fix it correctly, *then* make fun of it.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: "Fix" v.2

Not looking for review yet, since I have renewed hope that we won't have to fix every single click receiver one by one.

Comment 6

[Phil Ringnalda (:philor)]

Fixed by bug 362812