Closed
Bug 362812
Opened 18 years ago
Closed 18 years ago
Don't pass clicks down to controls for ctrl+click
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: philor, Assigned: jaas)
References
Details
Attachments
(1 file)
|
3.88 KB,
patch
|
asaf
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Bug 361240 comment 7 forestalled a fix that would have made ctrl+click indistinguishable from right-click, asking "What if some control wants to respond to proper right clicks but do not want ctrl-click associated with it?"
I strongly disagree. I have a one button mouse, and ctrl-click is how I right click. I'm completely unable to imagine any control doing anything that would please me by deciding that my right-click wasn't good enough for it, but I'm *very* able to imagine code, both in extensions and in app code written and reviewed by non-Mac users, which doesn't remember that every click must now be examined to determine whether or not it came from a Mac user (good luck, extension developers without #ifdef XP_MACOSX) who had the ctrl key down. We can fix the current problems in our various apps' code, and we can fix the future problems in our apps' code, but are we going to give every addons.m.o reviewer a Mac and a one-button mouse, so they'll catch every problem there?
Attachment #247516 -
Flags: review?
Attachment #247516 -
Flags: review? → review?(mano)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 247516 [details] [diff] [review]
fix v1.0
r=mano
Attachment #247516 -
Flags: review?(mano) → review+
Attachment #247516 -
Flags: superreview?(mikepinkerton)
|
||
Comment 3•18 years ago
|
||
Sounds good to me. Note that in bug 361240 comment 7 I was referring to a distinction in cocoa between right-click and "menu clicks", but if it's not possible to send a "context menu event" from the widget code, then this fix is definitely preferred.
|
||
Comment 4•18 years ago
|
||
Comment on attachment 247516 [details] [diff] [review]
fix v1.0
sr=pink
Attachment #247516 -
Flags: superreview?(mikepinkerton) → superreview+
fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 6•18 years ago
|
||
Verified with everything I know of that was confused before. Thanks, Josh.
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Comment 7•18 years ago
|
||
*** Bug 362394 has been marked as a duplicate of this bug. ***
|
|
Reporter | |
Comment 8•18 years ago
|
||
*** Bug 363631 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•