366673 - Remove remaining contents.rdf from Suiterunner (stop using installed-chrome.txt)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Mark Banner (:standard8)]

Similar to ff's bug 295235 - I think that there's probably not too many places where we are still using contents.rdf for suiterunner builds.

It'd be good if we could elimante the need for this (and hence get chrome tidier) before the first tinderbox trunk builds (whenever they are).

Comment 1

[Mark Banner (:standard8)]

Attachment: Patch for mailnews v1

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 251217 [details] [diff] [review]
Patch for mailnews v1

The patch seems to work ok, requesting reviews...

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 251217 [details] [diff] [review]
Patch for mailnews v1

Cancelling reviews, we're going to hold off on this for a while and get the moves done first - at least for mailnews.

Comment 4

[Caio Tiago Oliveira (asrail)]

Sorry Mark,

I'm not receiving all bugmail :(, so I hadn't read the your comment on bug 371298 relating it to this bug.

At least I started with Venkman and Chatzilla, so I think you won't bother.
They are attached to bug 371298.


Using contents.rdf requires write permissions to create an app-chrome.manifest file on the appdir.

I will try to confirm that your patch fixes the issue for mailnews tomorrow, but using manifests fixed the issue for CZ and Venkman.

Comment 5

[Robert Kaiser]

Could you please file separate bugs for chatzilla and venkman, in the right bugzilla components and make them dependent on this one here?

We probably have reviews from the respective products to do those changes, and that should be done in their projects' bugzilla components.

Comment 6

[Mark Banner (:standard8)]

Attachment: Fix extensions/sroaming

On irc (see also bug 378647) we've basically decided to keep extensions/sroaming alive for now (even though it won't work on suiterunner), but it needs work for suiterunner.

I'd like to at least get its contents.rdf files removed from suiterunner so that we can hopefully reduce our need for installed-chrome.txt before we switch (or if not, soon after). Its only a small patch so doesn't take much time.

If Robert wants me to I'll raise another bug pending for moving the locales/chrome if we do fix it up.

Comment 7

[[e-mail]]

Comment on attachment 262676 [details] [diff] [review]
Fix extensions/sroaming

It doesn't work, I get assertions instead of sroaming preferences.

Comment 8

[Mark Banner (:standard8)]

(In reply to comment #7)
> (From update of attachment 262676 [details] [diff] [review])
> It doesn't work, I get assertions instead of sroaming preferences.

Neil, is that for xpfe or suiterunner? We're expecting problems with sroaming on suiterunner anyway, though I thought the prefs did still display at least. Have you tried your suiterunner without the patch? 

Comment 9

[[e-mail]]

(In reply to comment #8)
>(In reply to comment #7)
>>(From update of attachment 262676 [details] [diff] [review] [details])
>>It doesn't work, I get assertions instead of sroaming preferences.
>Neil, is that for xpfe or suiterunner?
Suiterunner of course.
>We're expecting problems with sroaming on suiterunner anyway, though I
>thought the prefs did still display at least.
Well they didn't.
>Have you tried your suiterunner without the patch?
Yes, and the prefs show up as they do in xpfe.

Comment 10

[Mark Banner (:standard8)]

(In reply to comment #9)
> (In reply to comment #8)
> >We're expecting problems with sroaming on suiterunner anyway, though I
> >thought the prefs did still display at least.
> Well they didn't.

Opps, looks like I got the uris the wrong way round on this line:

% overlay chrome://communicator/content/pref/preftree.xul chrome://sroaming/content/prefs/prefsOverlay.xul

should be:

% overlay chrome://sroaming/content/prefs/prefsOverlay.xul chrome://communicator/content/pref/preftree.xul

Comment 11

[[e-mail]]

I suddenly realised that toolkit converts installed-chrome.txt to app-chrome.manifest so you can compare the generated lines:

>grep sroaming app-chrome.manifest
overlay chrome://communicator/content/pref/preftree.xul chrome://sroaming/content/prefs/prefsOverlay.xul
content sroaming jar:sroaming.jar!/content/sroaming/
locale sroaming en-US jar:sroaming.jar!/locale/en-US/sroaming/
skin sroaming modern/1.0 jar:sroaming.jar!/skin/modern/sroaming/
skin sroaming classic/1.0 jar:sroaming.jar!/skin/classic/sroaming/

>cat sroaming.manifest
skin sroaming modern/1.0 jar:sroaming.jar!/skin/modern/sroaming
content sroaming jar:sroaming.jar!/content/sroaming
locale sroaming en-US jar:sroaming.jar!/locale/en-US/sroaming
skin sroaming classic/1.0 jar:sroaming.jar!/skin/classic/sroaming
overlay chrome://communicator/content/pref/preftree.xul chrome://sroaming/content/prefs/prefsOverlay.xul

So you're missing /s at the end of the lines.

Comment 12

[Mark Banner (:standard8)]

Attachment: Fix extensions/sroaming v2 (checked in)

Fix all the problems...

Comment 13

[Mark Banner (:standard8)]

Attachment: Fix content/xslt/tests/buster/jar.mn (checked in)

This will fix the tests buster jar.mn for content/xslt.

Comment 14

[Mark Banner (:standard8)]

Comment on attachment 262908 [details] [diff] [review]
Fix content/xslt/tests/buster/jar.mn (checked in)

I just checked this in.

Comment 16

[Mark Banner (:standard8)]

FWIW I believe this just needs the remaining two blockers fixing hence there shouldn't be any work to do on this bug, except for removing installed-chrome.txt from the installers etc once they are fixed. Hence dropping of my immediate radar for now.

Comment 17

[Karsten Düsterloh]

Attachment: fix wallet locales (checked in)

Wallet is broken without this on latest trunk, hence password manager is not shown in the Tools menu, which is doubleplus ungood this close to SM2a1. (I blame Pike and his JarMaker.py!)
This patch fixes this, has r+/a+=kairo over IRC and is already checked in on wallet trunk aka 1.9.0.

Comment 18

[Mark Banner (:standard8)]

Attachment: Remove the last remnants (checked in)

This gets rid of the last few bits

Comment 19

[Robert Kaiser]

Comment on attachment 340216 [details] [diff] [review]
Remove the last remnants (checked in)

Thanks for doing this, It's good to see those files going away finally (even though a bit rushed now) :)

Comment 20

[Mark Banner (:standard8)]

Comment on attachment 340216 [details] [diff] [review]
Remove the last remnants (checked in)

Checked in, changeset id: 459:f8499aaeeba1