368634 - Importer (Win Eudora, Address Book). Unable to import if Eudora is using '.nnt' format

Status: RESOLVED FIXED

(Thunderbird :: Migration, defect)

Description

[Matt Dudziak]

The problem is that it is not possible to import Address Books from Eudora if Eudora is using the '.nnt' file format. The Penelope importer does not recognize this file format.

To reproduce:

- Set Eudora to hide Address Book files from simple viruses
- Attempt to import the Address Book into Penelope 
- Note error in Penelope:
"No address books were found to import".

Comment 1

[Geoffrey C. Wenger]

Attachment: Patch that fixes bug. Note patch was not created with CVS.

Comment 2

[David :Bienvenu]

Comment on attachment 260603 [details] [diff] [review]
Patch that fixes bug. Note patch was not created with CVS.

I'll try to port this to the trunk after I've finished getting rid of nsFileSpec...

Comment 3

[David :Bienvenu]

Standard8 points out that the patch has tabs in it - in general, we want spaces instead of tabs, and a 2 or 4 space indent, depending on the prevailing code. (Yeah, I realize that the import code is *full* of tabs, but we don't want to add more)

Since I'm going to have to apply this patch by hand, it's not such a big deal, but in the future

Comment 4

[Geoffrey C. Wenger]

We can chat in #penelope or via AIM tomorrow (Thurs.) regarding this. I realize that typically spaces would normally be used, but assumed that since the importer code has almost no use of spaces (i.e. tabs are pretty much all that is used) I shouldn't introduce a few lines with spaces (mixing tabs and spaces can be ugly depending on the settings of the person viewing your code). Sorry for the incorrect assumption and trouble here.

Comment 5

[Wayne Mery (:wsmwk)]

Matt, you might also take a look at bug 280006 and bug 274021 

Comment 6

[David :Bienvenu]

Attachment: fix I'm going to check in

This is what I'm going to land on the trunk - it uses nsIFile instead of nsfilespec.

Comment 7

[David :Bienvenu]

fixed on trunk