369303 - Restore "Get new messages" to context menu

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Windows XP SP 2 - Thunderbird 2 Beta 2 de-DE

Compared to 1.5.0.*, the menu item "Get new messages" has been removed (not available for mail, rss and newsgroup). If this is an error, please fix it. If it has been removed, it would be nice if you could tell a preference to enable it again.

Comment 1

[Magnus Melin [:mkmelin]]

It got removed intentionally in some context menu cleanup, there is no option to turn it back on. (Though an extension could do it.)

Have to say I missed it for a while myself, still wouldn't mind having it there.

Comment 2

[Chris Ilias [:cilias]]

(In reply to comment #1)
> It got removed intentionally in some context menu cleanup, 

What bug number?

Comment 3

[Magnus Melin [:mkmelin]]

Seems it was checked in as part of bug 251296.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I miss this feature sorely, so much so that my muscle memory is causing me to "open" accounts when I really want to just get new mail for them. I guess I'll get used to it's disappearance eventually... :/

Comment 5

[Scott MacGregor]

Let's add it back for Gavin's sanity...

Comment 6

[Magnus Melin [:mkmelin]]

I'll take this...

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Adds a "Get Messages" context menu item as first item of the context menu. 

In 1.5 it was "Get Messages for Account", but given it's a context menu I don't see much reason to include the "for Account". And this looks better...

Comment 8

[Scott MacGregor]

Comment on attachment 263001 [details] [diff] [review]
proposed fix

I like "Get Messages" a lot more too. Thanks Magnus.

Hopefully this will make Gavin a happy tbird user again :).

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Thanks a bunch, Magnus and Scott! :)

I gues it might be too much to ask for this to land on the branch for the next 2.0.0.x release?

mozilla/mail/base/content/mailWindowOverlay.xul 	1.205
mozilla/mail/locales/en-US/chrome/messenger/messenger.dtd 	1.63

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Oh, didn't notice the string change. I guess that makes this unsuitable for the branch.

Comment 11

[Magnus Melin [:mkmelin]]

Yeah, even if we had used the old string, i'm not sure that exists for all of the shipped locales in 2.0 vs 1.5.

Comment 12

[Mike Cowperthwaite]

Hate to niggle about this, but I would have liked this better if the menu item were displayed only for clicks on account nodes.  The implication of "Get Messages" on a folder is that only messages for that folder will be fetched.

Comment 13

[Magnus Melin [:mkmelin]]

Attachment: proposed additional fix

Only show the "Get Messages" item for account nodes. Also enable it for individual newsgroups (where it seems it fetches the headers for only that group). 

I don't know why it used to be disabled for news account nodes. Ok, it doesn't really "get" the actual messages, but does check for new for all groups - so I think it's reasonable to have it enabled there.

Comment 14

[Magnus Melin [:mkmelin]]

Ugh, realized for RSS we actually have per folder "Get messages". 

Comment 15

[Magnus Melin [:mkmelin]]

Attachment: proposed additional fix, v2

Show it for feed folders too...

Comment 16

[Magnus Melin [:mkmelin]]

Attachment: (checked in) proposed additional fix, v3

Correct white space too... Sorry for the spam.

Comment 17

[Phil Ringnalda (:philor)]

Comment on attachment 267061 [details] [diff] [review]
(checked in) proposed additional fix, v3

mail/base/content/mailContextMenus.js 1.24

Comment 18

[Phil Ringnalda (:philor)]

Y'all do realize that piling on additional fixes in the old bug like this is the reason I lost the bug 400000 sweepstakes, don't you?