370509 - Shift-Delete does not honor mail.imap.expunge_after_delete=true

Status: NEW

(MailNews Core :: Networking: IMAP, defect)

Description

[Tim K]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: version 2 beta 2 (20070116)

If I set mail.imap.expunge_after_delete=true via about:config it does what it's meant to do when I click on the Delete button or use the Delete key: the email is moved to Trash, deleted from Inbox and the Inbox expunged right away.

But if I use Shift-Delete which bypasses the Trash, the email is deleted but the Inbox is not expunged, the email is left in the "deleted" state.

Reproducible: Always

Steps to Reproduce:
1. Enable mail.imap.expunge_after_delete=true via about:config
2. Hit Shift-Delete on an email in an IMAP Inbox
3. The message will be left in "deleted" state, the Inbox is NOT expunged
Actual Results:  
The message will be left in "deleted" state, the Inbox is NOT expunged

Expected Results:  

IMAP Inbox should be expunged even when using Shift-Delete

Comment 1

[taomyn]

I've been experiencing the same thing for months now since enabling the option on my webclient (WorldClient for MDaemon) to show me IMAP deleted messages - I couldn't figure out why empty folders stated they had messages in them.

I concur that the Shift-Delete function is ignoring the config value which makes no sense if the setting is there - why would you want it working in two different ways at the same time.

In fact if shift-delete is supposed to delete a message with no chance of recovery, I would expect the "expunge" to happen regardless of the config setting. Personally I don't care which, but in my opinion the current coding is wrong.

Please can this be fixed.

Reproduced with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.3pre) Gecko/20070314 Thunderbird/2.0pre - Build ID: 2007031404

Comment 2

[taomyn]

Could this be placed under a different category as "Installer" may mean this is getting ignored. How about under "Mail Window Front End"?

Still happens in Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.4pre) Gecko/20070427 Thunderbird/2.0.0.4pre - Build ID: 2007042703

Comment 3

[WADA:World Anti-bad-Duping Agency]

David Bienvenu says next in Bug 220064 Comment #14 on 2007-02-06.
> there's a hidden pref in 2.0 that will turn on expunge after every single
> delete: "mail.imap.expunge_after_delete"
> if you set this to true, we'll issue an expunge after every delete.
Regression? Lack of support logic of this pref in official Tb 2.0.0 release?
Or simply one of many IMAP related problems of Tb 2.0.0.0?

Can you get IMAP protocol log and attach log file to this bug ( mime-type = text/plain, if size is accepted ), in order to see whether failure of EXPUNGE or no EXPUNGE?
"SET NSPR_LOG_MODULES=imap:5" is sufficient for initial analysis.
 - http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html#imap

Changing to Core/Networking IMAP.

Comment 4

[WADA:World Anti-bad-Duping Agency]

Another question. Is the problem recreated with latest-trunk nightly?
 - http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-trunk/
Test with new profile(or after backup of profile) is recommended. 

Comment 5

[taomyn]

Strange, I shift-delete an email in my inbox and get:

5292[4ae7740]: 3bacb80:mail.star-one.co.uk:S-INBOX:ProcessCurrentURL: entering
5292[4ae7740]: 3bacb80:mail.star-one.co.uk:S-INBOX:ProcessCurrentURL:imap://[e-mail]:993/Expunge%3E/INBOX:  = currentUrl
5292[4ae7740]: 3bacb80:mail.star-one.co.uk:S-INBOX:SendData: 15 expunge

5292[4ae7740]: ReadNextLine [stream=46070c8 nb=15 needmore=0]
5292[4ae7740]: 3bacb80:mail.star-one.co.uk:S-INBOX:CreateNewLineFromSocket: * 979 EXPUNGE

5292[4ae7740]: ReadNextLine [stream=46070c8 nb=25 needmore=0]
5292[4ae7740]: 3bacb80:mail.star-one.co.uk:S-INBOX:CreateNewLineFromSocket: 15 OK EXPUNGE completed

5292[4ae7740]: 3bacb80:mail.star-one.co.uk:S-INBOX:SendData: 16 UID fetch 3467:* (FLAGS)

5292[4ae7740]: ReadNextLine [stream=46070c8 nb=39 needmore=0]
5292[4ae7740]: 3bacb80:mail.star-one.co.uk:S-INBOX:CreateNewLineFromSocket: * 1009 FETCH (UID 3466 FLAGS (\Seen))

5292[4ae7740]: ReadNextLine [stream=46070c8 nb=23 needmore=0]
5292[4ae7740]: 3bacb80:mail.star-one.co.uk:S-INBOX:CreateNewLineFromSocket: 16 OK FETCH completed

0[25fd08]: 411b1b8:mail.star-one.co.uk:A:TellThreadToDie: close socket connection
2128[45fc348]: ImapThreadMainLoop leaving [this=411b1b8]
0[25fd08]: 3baad88:mail.star-one.co.uk:A:TellThreadToDie: close socket connection
4480[4ae7888]: ImapThreadMainLoop leaving [this=3baad88]
0[25fd08]: 3bacb80:mail.star-one.co.uk:S-INBOX:TellThreadToDie: close socket connection
5292[4ae7740]: ImapThreadMainLoop leaving [this=3bacb80]

the email is gone.

then shift-delete another in a sub folder and get:

3552[50c5370]: 46536a8:mail.star-one.co.uk:S-INBOX:ProcessCurrentURL: entering
3552[50c5370]: 46536a8:mail.star-one.co.uk:S-INBOX:ProcessCurrentURL:imap://[e-mail]:993/Expunge%3E/INBOX:  = currentUrl
3552[50c5370]: 46536a8:mail.star-one.co.uk:S-INBOX:SendData: 16 expunge

3552[50c5370]: ReadNextLine [stream=4d78148 nb=25 needmore=0]
3552[50c5370]: 46536a8:mail.star-one.co.uk:S-INBOX:CreateNewLineFromSocket: 16 OK EXPUNGE completed

3552[50c5370]: 46536a8:mail.star-one.co.uk:S-INBOX:SendData: 17 UID fetch 3467:* (FLAGS)

3552[50c5370]: ReadNextLine [stream=4d78148 nb=39 needmore=0]
3552[50c5370]: 46536a8:mail.star-one.co.uk:S-INBOX:CreateNewLineFromSocket: * 1009 FETCH (UID 3466 FLAGS (\Seen))

3552[50c5370]: ReadNextLine [stream=4d78148 nb=23 needmore=0]
3552[50c5370]: 46536a8:mail.star-one.co.uk:S-INBOX:CreateNewLineFromSocket: 17 OK FETCH completed

0[25fd08]: 4652e18:mail.star-one.co.uk:S-INBOX/Alt-N/MDaemon Beta:TellThreadToDie: close socket connection
4700[4b76250]: ImapThreadMainLoop leaving [this=4652e18]
0[25fd08]: 4653f38:mail.star-one.co.uk:A:TellThreadToDie: close socket connection
4740[50c5748]: ImapThreadMainLoop leaving [this=4653f38]
0[25fd08]: 4651cf8:mail.star-one.co.uk:A:TellThreadToDie: close socket connection
4904[50c54b8]: ImapThreadMainLoop leaving [this=4651cf8]
0[25fd08]: 46536a8:mail.star-one.co.uk:S-INBOX:TellThreadToDie: close socket connection
3552[50c5370]: ImapThreadMainLoop leaving [this=46536a8]

and this one is still there.

Comment 6

[WADA:World Anti-bad-Duping Agency]

JFY.
Bug 359281 Comment #10 says Bug 265472 introduced mail.imap.expunge_after_delete.  

Comment 7

[Nikolay Shopik]

version 3.0a1pre (2008042403) doesn't honor mail.imap.expunge_after_delete

Comment 8

[Nikolay Shopik]

this depends on bug 399475 

Comment 9

[Magnus Melin [:mkmelin]]

Should shitf-del really expunge after? I don't know if there is any "selective expunge/compact" - if there isn't all the other deleted msgs would also get removed. 

Comment 10

[Nikolay Shopik]

If I correctly understood this can be possible done using UIDPLUS extension, look for RFC4315

Comment 13

[Gerald]

Bug is still present in Thunderbird 17 Beta. Normal deleting with mail.imap.expunge_after_delete=true results in the mail immediately disappearing in other clients, shift-deleting the mail doesn't do so.

Comment 14

[Gerald]

Not that I had expected anything else from an organisation that prefers to discuss each bug for at least 10 years before deciding fixing/not fixing it. But just for the record: In Thunderbird 45.2.0 this behavior is unchanged and shift-deleted mails still don't get expunged until you close Thunderbird.

Comment 15

[Matthew Jurgens]

Still a problem in Thunderbird 91

Comment 16

[Wayne Mery (:wsmwk)]

m-wada is no longer active

Comment 19

[monperrus]

FTR, https://phabricator.services.mozilla.com/D220057 contains the fix.