379231 - Omnibus ad-blocking bug for May

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment 1

[Chris Lawson (gone)]

Banner ad across the top here, along with some more ads in the sidebar:

http://www.dorsetecho.co.uk/news/local/display.var.1362517.0.pig_sick.php

/banners/ is in the source of the banner ad image, and click2find.co.uk seems like a likely target for blocking as well.

Comment 2

[Chris Lawson (gone)]

Some ads here that we can probably nuke too:

http://www.wlos.com/template/inews_wire/wires.national/2427c023-www.wlos.com.shtml

Either the host -- sbgwebas.sbgnet.com -- or the /phpAds/ string can probably be safely blocked.

Comment 3

[Chris Lawson (gone)]

Some Flash ads on This Old House:

http://www.thisoldhouse.com/toh/tohnews/gallery/0,25895,1587613-21,00.html

adremote.timeinc.net is the server, I think.

Comment 4

[Simon Fraser [no longer active]]

Neatorama.com is showing Flash ads like http://neatorama.cachefly.net/img4/Dangerous-Books-for-Boys-728x90-Banner.swf

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Simon, did you mean to pull the blocking1.8.1.4? flag here?  We don't need it for Camino-only code....

Comment 6

[Simon Fraser [no longer active]]

I don't think I touched the flags. User error I guess.

Comment 7

[Simon Fraser [no longer active]]

Lots of ads on http://www.radaronline.com/, served from http://radaronline.advertserve.com/advertpro

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Ads in iframes from http://cm.homestore.overture.com/ on pages like http://homes.realtor.com/search/listingdetail.aspx?zp=33706&mxp=26&bd=3&bth=2&typ=2&pg=4&lid=1073939483&lsn=39&srcnt=108

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www.gazette.com/articles/church_21997___article.html/pie_grace.html we can get some of the ads; they're <div id="loweradswrapper2">

Comment 10

[Chris Lawson (gone)]

The images on

http://www.cooking.com/

are all coming from an edgesuite.net server, specifically:

www.cooking.com.edgesuite.net

We might want to whitelist that particular server, as the site is pretty unusable without the images (it doesn't seem to have any ads on it).

cl

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www.ajc.com/gwinnett/content/metro/gwinnett/index.html

An annoying Flash ad: http://view.admission.net/admission/spotlight/spotlight.swf  within div[id="adrail"] and div[id="bigad"]

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We need to whitelist wiki.cb.o, too; one of jeff's mockup images in stuck in a directory called "/ad/" :p

Comment 13

[Simon Fraser [no longer active]]

Seeing banners on http://www.mac-forums.com coming from http://juggler.inetinteractive.com/banners/

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: May Omnibus Ad-Blocking

This does everything except comment 1 (/banners/ is waaay to common, and I don't see anything ad-like about the other domain) and comment 4, which is already being blocked here (we added a rule in Feb for cachefly swfs).

Comment 15

[Simon Fraser [no longer active]]

Comment on attachment 267039 [details] [diff] [review]
May Omnibus Ad-Blocking

edgesuite.net isn't an ad server; it's used by Akamai:
<http://www.akamai.com/html/solutions/edgesuite_delivery.html>
I don't think we should block anything at edgesuite.net (and the cooking.com stuff looks more like product promotion that ads to me).

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yieldmanager is actually using edgesuite.net for ads (bug 372612 comment 2 and bug 376270 comment 5), as is adinterax (bug 372612 comment 4); I'll change those rules to block just the yieldmanager- and adinterax-specific subdomains, and then remove the whitelist rule for cooking.com.

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: May Omnibus v2

This does comment 16.

Comment 18

[froodian (Ian Leue)]

Checked in on trunk and MOZILLA_1_8_BRANCH.

Comment 21

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Approved for 1.5.1 per irc; nominating for 1.0.6.

Comment 22

[Stuart Morgan]

Landed on CAMINO_1_5_BRANCH.

Comment 23

[Stuart Morgan]

This was landed on MOZILLA_1_8_0_BRANCH as part of a sync-up through bug 383016.

Comment 24

[MoodyBlanco]

Where is this original bug? Im starting to see it across a number of my websites at the following links:

http://luxuryflooringinc.com/
http://www.agcmedia.ca/
http://kongafitness.ca/
http://agcelectronicsplus.com/
http://www.weddingsnmedia.com/

If you have come across this bug and know what the fix was. please inform me.