380305 - Dictionary page is not localizable

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Jesper Kristensen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; da; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

Bits of the dictionary page is not localizable.

The following texts should be localizable:
Install
Install dictionary
(<size> KB)
Dictionary: <name>

Reproducible: Always

Comment 1

[Jesper Kristensen]

Attachment: Patch v1

This patch includes this bug, bug 380306 and bug 370751

It also changes display of language names so that all names are displayed without the non human readable language code, not just languages with regional variations.

Comment 2

[Jesper Kristensen]

Attachment: Patch v2

Woops, half a fix for bug 371010 sneaked its way into the previous patch, including the whole fix.

I hope it is OK to have many small fixes in one patch.

Comment 3

[Justin Scott [:fligtar]]

Comment on attachment 264377 [details] [diff] [review]
Patch v2

These changes all look good, I'm excited to get these bugs fixed and that you're helping out.

The only issue I encountered was that when you click on a link to install a dictionary, the name displayed in the xpinstall dialog is "Dictionary: %1".

Also, one little thing:
> msgid "addons_dictionaries_size_kb"
> msgstr " (%1 KB)"

Can you remove that space in front and have it be non-localized instead please?

With those changes, we can include this in the next update. Also, just to confirm - you'll need this checked in, right?

Comment 4

[Jesper Kristensen]

> The only issue I encountered was that when you click on a link to install a
> dictionary, the name displayed in the xpinstall dialog is "Dictionary: %1".

Is the %1 sign html-encoded at you? I cannot reproduce the problem here, but also I cannot reproduce the problem seen on remora.stage.mozilla.com where "-" is being html-encoded, so i guess it might be related.

> Can you remove that space in front and have it be non-localized instead
> please?

I will do that, through i do not agree in that it should be done.

> Also, just to confirm - you'll need this checked in, right?

Yes

Comment 5

[Jesper Kristensen]

Attachment: Patch v3

Removed space from localization

I hope I have solved the %1-problem, but since I am working in total darkness here, I do not know.

Comment 6

[Justin Scott [:fligtar]]

(In reply to comment #4)
> Is the %1 sign html-encoded at you?

Yeah, that was the problem. If I change publish() to set() it works fine. (The only difference between them is that publish() html encodes everything to prevent XSS attacks and is what we use unless we have specific reason to use set().)

I think that set() would be fine to use here, as there's no dynamic data being passed.

So, can you upload another patch changing publish() to set() and undoing the other stuff you were trying to fix the problem in the third patch? (Still removing the translation space though)

Comment 7

[Jesper Kristensen]

Attachment: Patch v4

Used set instead of publish

Comment 8

[Justin Scott [:fligtar]]

Comment on attachment 264395 [details] [diff] [review]
Patch v4

Great, it's been checked in and will be live next time we update.

Thanks!