Closed Bug 381147 Opened 19 years ago Closed 18 years ago

Move responsibility for correct display of dictionaries from mozilla.com maintainers to dictionary maintainers

Categories

(addons.mozilla.org Graveyard :: Dictionaries, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bugzilla, Unassigned)

References

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; da; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3 Build Identifier: Display of dictionary names has always had problems. Display of dictionary names still have problems. Display of dictionary names will continue to have problems unless we do something. Stop using https://www.mozilla.com/js/download.js and use the AMO database instead. The following info is needed about each dictionary: * Localized dictionary name (In the extension install dialog) * Localized language name (First column on dictionary page) * Local language name (Second column on dictionary page) There is already a field in the addons table for the localized dictionary name. For the local and localized language names we could reuse some of the fields unused for dictionaries. Reproducible: Always
Blocks: 362461
Attached patch Patch v1 — — Splinter Review
Attachment #265251 - Flags: review?
What exactly is the problem? I'm not sure if moving to less languages is the right thing to do, without actually understanding the patch. I only know that we have information on more languages in download.js than localizations on AMO.
Check out https://addons.mozilla.org/da/firefox/browse/type:3 At this moment et-ee, hsb and uk-ua has language codes displayed instead of language names, there is 3 dictionaries with the name Dutch, and there may be other bugs. My assumption is that the localization team that uploads a dictionary, knows what their language is called. If they are able to enter that name directly, they wouldn't have to wait months before someone fixes the JS code on mozilla.com and/or AMO to support the new dictionary locale.
The dutch stuff seems to be a different bug, two of those actually refer to the same file. Regarding the actual patch, I can't really tell what the outcome of this patch would be, so I can't comment further.
The basic way to go sounds like a good idea to me, though I'm not sure the direct usage of the Add-on name is what we can go with, as I expect that people will go on defining long names for them that don't fit into the dictionaries page.
I thought we could just make a policy on how to name dictionaries and make that policy a requirement for the dictionary to be published.
We've moved to using product-details to ensure proper names on the dictionary page (https://addons.mozilla.org/en-US/firefox/browse/type:3). I'm filling in the last of the locale names in bug 425341 and then that page should be consistent. I feel like WONTFIXing this bug - thoughts?
Still happy to hear objections, but just in case no one does, I don't want this to get lost in my mail.
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Resolution: --- → WONTFIX
We're still waiting for a resolve in bug 362414, but we probably want a change to the Slovene language name, CCed you there.
In bug 425386 comment 1 Wil Clouser wrote: > The idea is to require the correct values [in the target locale field in the db] to get from the sandbox->public. That is almost the same thing as this bug, and it seems to solve the problem. So I am fine with WONTFIX.
Attachment #265251 - Flags: review?
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: