381405 - Menu item icons for Livemarks/RSS feeds on the bookmarks toolbar have a drop arrow

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Wayne Woods]

Attachment: Screenshot of the problem

The menu item icons for RSS feeds on the bookmarks toolbar bear a drop arrow, suggesting that they're a submenu. See attached screenshot.

I presume this is due to Places being switched on, and comes from chrome://browser/skin/places/livemarkItem.png, which maybe should look like chrome://browser/skin/page-livemarks.png instead?

Comment 1

[Steve Won (stevewon on irc)]

Attachment: Proposed patch

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 265680 [details] [diff] [review]
Proposed patch

steve, this didn't fix all instances of the icon. please check that the feed icon is updated in all visible locations.

Comment 3

[Steve Won (stevewon on irc)]

Attachment: Attached

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: fix

so, there were a few things wrong, that this patch addresses:

- livemarkItem.png file contained the wrong image. it was the folder icon w/ the dropmarker. i've updated that file with the one used in the old bookmarks: http://lxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/bookmarks/livemark-item.png

- the livemark service was using the livemark item image instead of the livemark folder image for livemark folders

Comment 5

[Dietrich Ayala (:dietrich)]

Attachment: fix revised

uses file in existing location, filed bug 380095 for consolidating the theme files. also removes some unused feed strings.

Comment 6

[Steve Won (stevewon on irc)]

Attachment: bug revised

Fixed all hopefully =]

Comment 7

[Steve Won (stevewon on irc)]

Attachment: patch

Comment 8

[Steve Won (stevewon on irc)]

Mm, changing all the page-livemarks.png images to http://lxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/bookmarks/livemark-item.png seem to result in blank icons in the build.

Comment 9

[Steve Won (stevewon on irc)]

Attachment: Fix

This should fix the problem for the Macs.
For windows, I don't have a windows machine set up with build environment set up yet. But it should be able to be fixed by changing one or more of the 6 lines with livemark-item.png in themes/winstripe/browser/browser.css

Comment 10

[Wayne Woods]

Just noting bug 378901, though the two bugs should hopefully not interfere.

Comment 11

[Steve Won (stevewon on irc)]

This only seems to be a mac problem.
I just compared the icons between Fx2 and Minefield in Win Vista, the icons are the same in both apps.

Comment 12

[Steve Won (stevewon on irc)]

Attachment: Patch (Mac)

A couple of things.
1. chrome://browser/skin/places/livemarkItem.png isn't actually being used anywhere other than parts removed from this patch. In the patch, added in chrome://browser/skin/places/livemark-item.png and a new pnh file, but just replacing the old png with the new one might be an option too.
2. In Fx2 Bookmark Orgznier, the "Latest Headlines" have a http://mxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/bookmarks/bookmark-folder.png as its icon rather than http://mxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/page-livemarks.png.  Should we keep using the folder icon or a livemarks icon in the bookmark organizer?

Comment 13

[Steve Won (stevewon on irc)]

Attachment: New png file for http://mxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/page-livemarks.png

Comment 14

[Steve Won (stevewon on irc)]

Comment on attachment 269125 [details] [diff] [review]
Patch (Mac)

Missed something on Windows.. getting to the fix right now.

Comment 15

[Steve Won (stevewon on irc)]

Comment on attachment 269125 [details] [diff] [review]
Patch (Mac)

Bookmarks toolbar drop arrow problem on menu item icons is fixed.

Comment 16

[Dietrich Ayala (:dietrich)]

WFM in nightly build.

Comment 17

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv