385425 - getting the quit prompt when restarting firefox after installing an add on

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[(not reading, please use [e-mail] instead)]

getting the quit prompt when restarting firefox after installing an add on.

for restart from the EM, I don't think we should prompt you, since it will restart with the open tabs, right?

I'll attach a screen shot.

Comment 1

[(not reading, please use [e-mail] instead)]

I'm using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070620 Minefield/3.0a6pre

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of the prompt from the EM

Comment 3

[Robert Strong (they/them - no direct email)]

Is this also true for software update? If not then we should use the same method it uses... if not, is there a bug also filed for that?

Comment 4

[Simon Bünzli]

It's still unclear whether the quit prompt should be shown or not when the session will be resumed (see bug 348471 and bug 384907). An earlier request to that end was WONTFIXED in bug 341248.

Comment 6

[(not reading, please use [e-mail] instead)]

> Is this also true for software update? If not then we should use the same
> method it uses... if not, is there a bug also filed for that?

Sorry for the delayed response.  Software update has the same problem.  I've logged bug #385853 for that.

Comment 7

[Mike Connor [:mconnor]]

In Fx2 we would prompt before closing windows with multiple tabs, in both cases, so I'm thinking this might be WONTFIX for the same reasoning, but I need to talk through this dialog with beltzner in general, so I'll leave the nom for now.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Regardless of the solution, this bug needs to be fixed, since the user clicks "restart" yet sees "quit". That's just wrong.

Possible solutions include:

 - only prompt if we detect the presence of tabs with form data or post data that will not be restored after restart, and in that case, refer explicitly to those tabs (I think there's a bug on this already?)

 - create a restart confirmation dialog to be used here instead, saying "Firefox will try to restore your N windows and M tabs when it restarts. [Restart] [Cancel]"

Comment 9

[Robert Strong (they/them - no direct email)]

beltzner, does the same possible solutions also apply to fixing this for Software Update (see bug #385853)?

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #9)
> beltzner, does the same possible solutions also apply to fixing this for
> Software Update (see bug #385853)?

Yes.

Comment 11

[Michael Wu [:mwu]]

Attachment: Add special case for restarts

Comment 12

[Michael Wu [:mwu]]

Attachment: Add special case for restarts, v2

Slightly better implementation.

Comment 13

[Asaf Romano (gone)]

Comment on attachment 273853 [details] [diff] [review]
Add special case for restarts, v2

r=mano, but please declare |message| outside of the if/else blocks.

Comment 14

[Michael Wu [:mwu]]

Attachment: As checked in

Comment 15

[Michael Wu [:mwu]]

Checking in browser/components/nsBrowserGlue.js;
/cvsroot/mozilla/browser/components/nsBrowserGlue.js,v  <--  nsBrowserGlue.js
new revision: 1.33; previous revision: 1.32
done
Checking in browser/locales/en-US/chrome/browser/quitDialog.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/quitDialog.properties,v  <--  quitDialog.properties
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <--  extensions.js
new revision: 1.129; previous revision: 1.128
done

Comment 18

[Marcia Knous [:marcia]]

Litmus triage team: tchung will create a test case for this bug.

Comment 19

[PikeUK]

Disabling the warning on restart disables the warning on quit as well (they use the same pref), is that considered a bug or by design?

Comment 20

[Francesco Lodolo [:flod]]

The string with key "NeverAsk" is "Do not ask next time".

This checkbox is used in combination with (at least) two other strings:
    * "messageNoWindows" when you try to close a window 
    * "messageRestart" when you press the button Restart in the
      Add-ons Manager

While the first message is a question ("Do you want %S to save your tabs and windows for the next time it starts?"), the second message 
is a statement ("%S will try to restore your tabs and windows when it restarts.
"), so "ask" doesn't fit.

Maybe we should have a second string to use with a statement like messageRestart.

Comment 21

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050906 Minefield/3.0pre

Comment 22

[Tony Chung [:tchung]]

Edited litmus test: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=6906 to include this behavior.