The "no entry" icon is aligned on the left side of the web forgery popup (Persian locale)

RESOLVED FIXED

Status

RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: mana.ghavifekr, Assigned: Ehsan)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fa-IR; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fa-IR; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7

The "no entry" icon is aligned on the left side of the web forgery popup.  This icon should be places at the right side of the popup, besides the title.

Reproducible: Always
(Assignee)

Updated

12 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 1

12 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; fa-IR; rv:1.8.1.7)
Gecko/20070914 Firefox/2.0.0.7

Confirmed.
(Assignee)

Updated

12 years ago
Blocks: 285718
(Assignee)

Updated

12 years ago
No longer blocks: 285718
(Assignee)

Updated

12 years ago
Blocks: 349207
(Assignee)

Comment 2

12 years ago
Created attachment 284615 [details] [diff] [review]
Right-align the title icon

The patch to right-align the title icon.

This patch is tested against FF 2.0.0.7.
Assignee: behnam → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #284615 - Flags: review?(behnam)
(Assignee)

Updated

12 years ago
Blocks: 399581
(Assignee)

Updated

12 years ago
Blocks: 399582
(Assignee)

Comment 3

12 years ago
I tested this with the ar (Arabic) and he (Hebrew) locales, and they were affected with the same problems.  Submitted bug 399581 for ar and bug 399582 for he.  These localizations can use a similar patch as well.

If there are any other RTL locales as well, we need to test against those as well.
(Assignee)

Comment 4

12 years ago
Editing the summary to differentiate with the same bug in other RTL locales...
Summary: The "no entry" icon is aligned on the left side of the web forgery popup → The "no entry" icon is aligned on the left side of the web forgery popup (Persian locale)
Could you please attach screenshots?
(Assignee)

Comment 6

11 years ago
Created attachment 289126 [details]
Screenshot of the problem
(Assignee)

Comment 7

11 years ago
Created attachment 289127 [details]
Screenshot of my fix
(Assignee)

Comment 8

11 years ago
Ping...
(Assignee)

Updated

11 years ago
Blocks: 412273
(Assignee)

Comment 9

11 years ago
Re-ping... :-)
(Assignee)

Comment 10

11 years ago
Mass edit of the QA Contact --> <persian.fa@localization.bugs>
QA Contact: nobody → persian.fa
(Assignee)

Comment 11

11 years ago
This patch was checked in for ar (bug 399581) and has r+ for he (not sure if it's checked in, see bug 399582).  I think we can take this.
(Assignee)

Updated

11 years ago
Blocks: 415597
(Assignee)

Updated

11 years ago
No longer blocks: 412273
Blocks: 412273
(Assignee)

Updated

11 years ago
Attachment #284615 - Flags: review?(bugs+behnam)
(Assignee)

Comment 12

11 years ago
Checking in toolkit/chrome/global/intl.css;
/l10n/l10n/fa/toolkit/chrome/global/intl.css,v  <--  intl.css
new revision: 1.4; previous revision: 1.3
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
No longer blocks: 415597
(Assignee)

Updated

10 years ago
Blocks: 285718
You need to log in before you can comment on or make changes to this bug.