400925 - Reftests for live changes to gradients and patterns

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: patch to add reftests

These reftests are intended as tests for bug 276316, bug 309924, bug 308589, bug 327764, and bug 372574.

I couldn't get them to fail by reverting the patches for bug 309924 or bug 327764, though, which is strange.  I even tried using reftest-wait instead of direct onload.  Could the problem be that the bugs are painting bugs and reftest's forced painting hides them?

Comment 1

[tor]

(In reply to comment #0)
> I couldn't get them to fail by reverting the patches for bug 309924 or bug
> 327764, though, which is strange.  I even tried using reftest-wait instead of
> direct onload.  Could the problem be that the bugs are painting bugs and
> reftest's forced painting hides them?

Those bugs came about because we weren't invalidating the area to repaint, so a forced paint would indeed probably hide them.

Comment 2

[Jesse Ruderman]

Should I add these as reftests anyway?  Will a future version of reftest will be able to catch painting-invalidation bugs?

Comment 3

[tor]

I can't speak for the future features of the reftest framework, but having tests for various invalidations would be useful.  I don't think the onload approach used in these tests is the way to go, since that will probably get executed before the first paint.

Comment 4

[Jonathan Griffin (:jgriffin)]

Attachment: updated reftests

Updated Jesse's original reftests with the new MozReftestInvalidate event; see http://weblogs.mozillazine.org/roc/archives/2009/01/invalidation_re.html.

Comment 5

[Jesse Ruderman]

Comment on attachment 384917 [details] [diff] [review]
updated reftests

Please request review from dbaron or roc, since I don't know the subtleties of MozReftestInvalidate.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

There are no real subtleties. You just set reftest-wait on the root element, listen for the MozReftestInvalidate with document.addEventListener("MozReftestInvalidate", doTest, false), and in doTest do your dynamic changes and then remove reftest-wait.

Comment 7

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/d4bd5186451e