401247 - Assertion Failed (assert:null node) when middle-clicking on blank space in Bookmarks Toolbar

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[pal-moz]

Attachment: screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102605 Minefield/3.0a9pre ID:2007102605

see attachment.

maybe regression between 20071024-20071025 nightly.(caused by Bug 399729 ?)

Comment 1

[pal-moz]

correct range,
happens after 20071024_1906_firefox-3.0a9pre.en-US.win32.zip
so check-in for Bug 399729 cause this.

Comment 5

[Asaf Romano (gone)]

Attachment: patch

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 293181 [details] [diff] [review]
patch

r=sspitzer, but please fix that typo before checking in:

+ this._selection = this._selection = this.getResult().root;

should be:

+ this._selection = this.getResult().root;

Comment 7

[Asaf Romano (gone)]

Attachment: for checkin

Comment 8

[Asaf Romano (gone)]

mozilla/browser/components/places/content/toolbar.xml 1.112

Comment 9

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre)
Gecko/2007121805 Minefield/3.0b3pre

Comment 11

[Fabs]

Actual contents of error box:

ASSERT: null mode
Stack Trace:
0:PU_nodeIsFolder(null)
1:BT_onClick([object MouseEvent])
2:onclick([object MouseEvent])

Comment 12

[Elmar Ludwig]

restoring CC list...

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv