401936 - tracking bug for moving 1.8 nightlies to release automation

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Meta bug for tracking a Q4 goal.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: simple "nightly mode" for en-US build

With this patch, if "version = nightly" in bootstrap.cfg then a bunch of things in Build.pm are skipped:

* no force-clobber (by removing last-built)
* no storing the buildID info.txt files on FTP
* no verify, push or announce

This leaves Tinderbox in charge of determining if a build is a nightly (clobber) or depend, so only multi-tinderbox is replaced and nothing else at the buildslave level.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 291921 [details] [diff] [review]
simple "nightly mode" for en-US build


>+    if ($version eq 'nightly') {
>+        $this->Log(msg => 'Skip Push for nightly mode');
>+        return;
>+    }
>+

This one should be 'Skip Announce for nightly mode', I believe. r=bhearsum with that change.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to comment #2)
> (From update of attachment 291921 [details] [diff] [review])
> 
> >+    if ($version eq 'nightly') {
> >+        $this->Log(msg => 'Skip Push for nightly mode');
> >+        return;
> >+    }
> >+
> 
> This one should be 'Skip Announce for nightly mode', I believe. r=bhearsum with
> that change.
> 

Er, yeah :) copypasta ftw. thanks.

Comment 4

[Robert Helmer [:rhelmer]]

Attachment: [checked in] simple "nightly mode" for en-US build as-landed

Same as before plus "skip Announce" logging fix:

Checking in Bootstrap/Step/Build.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Build.pm,v  <--  Build.pm
new revision: 1.22; previous revision: 1.21
done

Comment 5

[Robert Helmer [:rhelmer]]

Attachment: [checked in] enable nightly/depend builders on staging-trunk-automation

Add nightly and depend build support to trunk staging automation.

Comment 6

[Robert Helmer [:rhelmer]]

Attachment: [checked in] nightly bootstrap.cfg

Most of the variables in here are unused so I left them the same as the staging config, so you can diff against that to get an idea of what actually changed.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 292529 [details] [diff] [review]
[checked in] enable nightly/depend builders on staging-trunk-automation

Looks good, but don't you want to lock during update_verify and l10nverify?

Comment 8

[Robert Helmer [:rhelmer]]

(In reply to comment #7)
> (From update of attachment 292529 [details] [diff] [review])
> Looks good, but don't you want to lock during update_verify and l10nverify?

Hm, not sure. I wanted to lock builds specifically because they are so resource-intensive, but I want to free up the depend builds as much as possible. The verify steps use mostly disk space and a little bit of memory, it doesn't seem to have any significant impact on the nightly builds.

Comment 9

[[e-mail] (:bhearsum)]

(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 292529 [details] [diff] [review] [details])
> > Looks good, but don't you want to lock during update_verify and l10nverify?
> 
> Hm, not sure. I wanted to lock builds specifically because they are so
> resource-intensive, but I want to free up the depend builds as much as
> possible. The verify steps use mostly disk space and a little bit of memory, it
> doesn't seem to have any significant impact on the nightly builds.
> 

Sounds fine to me, then.

Comment 10

[Robert Helmer [:rhelmer]]

Comment on attachment 292558 [details] [diff] [review]
[checked in] nightly bootstrap.cfg

RCS file: /cvsroot/mozilla/tools/release/configs/fx-moz19-nightly-bootstrap.cfg,v
done
Checking in fx-moz19-nightly-bootstrap.cfg;
/cvsroot/mozilla/tools/release/configs/fx-moz19-nightly-bootstrap.cfg,v  <--  fx-moz19-nightly-bootstrap.cfg
initial revision: 1.1
done

Comment 11

[Robert Helmer [:rhelmer]]

Comment on attachment 292529 [details] [diff] [review]
[checked in] enable nightly/depend builders on staging-trunk-automation

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/automation/staging-1.9/master.cfg,v  <--  master.cfg
new revision: 1.2; previous revision: 1.1
done

Comment 12

[Robert Helmer [:rhelmer]]

Attachment: [checked in] mozilla 1.8 nightly config

This gets nightlies running on Mozilla1.8 branch (with not-included-here tinderbox-configs patches)

Comment 13

[[e-mail] (:bhearsum)]

Comment on attachment 293258 [details] [diff] [review]
[checked in] mozilla 1.8 nightly config

>+c['bots'] = [("linux-1.8-console1","mozilla"),
>+             ("linux-1.8-console2","mozilla"),
>+             ("linux-1.8-slave1", "mozilla"),
>+             ("linux-1.8-slave2", "mozilla"),
>+             ("macosx-1.8-slave1", "mozilla"),
>+             ("macosx-1.8-slave2", "mozilla"),
>+             ("win32-1.8-slave1", "mozilla"),
>+             ("win32-1.8-slave2", "mozilla"),
>+             ("linux-trunk-slave1", "mozilla"),
>+             ("linux-trunk-slave2", "mozilla"),
>+             ("macosx-trunk-slave1", "mozilla"),
>+             ("macosx-trunk-slave2", "mozilla"),
>+             ("win32-trunk-slave1", "mozilla"),
>+             ("win32-trunk-slave2", "mozilla")]

To be consistent, you should take out the passwords here. r=bhearsum with that changes.

Comment 14

[Robert Helmer [:rhelmer]]

Comment on attachment 293258 [details] [diff] [review]
[checked in] mozilla 1.8 nightly config

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/automation/staging/master.cfg,v  <--  master.cfg
new revision: 1.11; previous revision: 1.10
done

Comment 15

[Robert Helmer [:rhelmer]]

Returning this to the pool. 

Comment 16

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Triaged.

Comment 17

[Chris AtLee [:catlee]]

Mozilla 1.9 / Firefox 3.0.x nightlies are staying on Tinderbox (see bug 421411).

Mozilla 1.9.1 and beyond are already on release automation (buildbot).

Comment 18

[[e-mail] (:bhearsum)]

We did this for 1.8 and decided not to for 1.9, I'm adjusting the summary and resolution.