Closed Bug 401936 Opened 12 years ago Closed 11 years ago

tracking bug for moving 1.8 nightlies to release automation

Categories

(Release Engineering :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: joduinn, Assigned: catlee)

References

Details

Attachments

(4 files, 1 obsolete file)

Meta bug for tracking a Q4 goal.
Blocks: end2end-bld
Priority: -- → P3
Assignee: nobody → rhelmer
With this patch, if "version = nightly" in bootstrap.cfg then a bunch of things in Build.pm are skipped:

* no force-clobber (by removing last-built)
* no storing the buildID info.txt files on FTP
* no verify, push or announce

This leaves Tinderbox in charge of determining if a build is a nightly (clobber) or depend, so only multi-tinderbox is replaced and nothing else at the buildslave level.
Attachment #291921 - Flags: review?(bhearsum)
Comment on attachment 291921 [details] [diff] [review]
simple "nightly mode" for en-US build


>+    if ($version eq 'nightly') {
>+        $this->Log(msg => 'Skip Push for nightly mode');
>+        return;
>+    }
>+

This one should be 'Skip Announce for nightly mode', I believe. r=bhearsum with that change.
Attachment #291921 - Flags: review?(bhearsum) → review+
(In reply to comment #2)
> (From update of attachment 291921 [details] [diff] [review])
> 
> >+    if ($version eq 'nightly') {
> >+        $this->Log(msg => 'Skip Push for nightly mode');
> >+        return;
> >+    }
> >+
> 
> This one should be 'Skip Announce for nightly mode', I believe. r=bhearsum with
> that change.
> 

Er, yeah :) copypasta ftw. thanks.
Status: NEW → ASSIGNED
Same as before plus "skip Announce" logging fix:

Checking in Bootstrap/Step/Build.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Build.pm,v  <--  Build.pm
new revision: 1.22; previous revision: 1.21
done
Attachment #291921 - Attachment is obsolete: true
Priority: P3 → P2
Add nightly and depend build support to trunk staging automation.
Attachment #292529 - Flags: review?(bhearsum)
Most of the variables in here are unused so I left them the same as the staging config, so you can diff against that to get an idea of what actually changed.
Attachment #292558 - Flags: review?(bhearsum)
Comment on attachment 292529 [details] [diff] [review]
[checked in] enable nightly/depend builders on staging-trunk-automation

Looks good, but don't you want to lock during update_verify and l10nverify?
Attachment #292529 - Flags: review?(bhearsum) → review+
Attachment #292558 - Flags: review?(bhearsum) → review+
(In reply to comment #7)
> (From update of attachment 292529 [details] [diff] [review])
> Looks good, but don't you want to lock during update_verify and l10nverify?

Hm, not sure. I wanted to lock builds specifically because they are so resource-intensive, but I want to free up the depend builds as much as possible. The verify steps use mostly disk space and a little bit of memory, it doesn't seem to have any significant impact on the nightly builds.
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 292529 [details] [diff] [review] [details])
> > Looks good, but don't you want to lock during update_verify and l10nverify?
> 
> Hm, not sure. I wanted to lock builds specifically because they are so
> resource-intensive, but I want to free up the depend builds as much as
> possible. The verify steps use mostly disk space and a little bit of memory, it
> doesn't seem to have any significant impact on the nightly builds.
> 

Sounds fine to me, then.
Comment on attachment 292558 [details] [diff] [review]
[checked in] nightly bootstrap.cfg

RCS file: /cvsroot/mozilla/tools/release/configs/fx-moz19-nightly-bootstrap.cfg,v
done
Checking in fx-moz19-nightly-bootstrap.cfg;
/cvsroot/mozilla/tools/release/configs/fx-moz19-nightly-bootstrap.cfg,v  <--  fx-moz19-nightly-bootstrap.cfg
initial revision: 1.1
done
Attachment #292558 - Attachment description: nightly bootstrap.cfg → [checked in] nightly bootstrap.cfg
Comment on attachment 292529 [details] [diff] [review]
[checked in] enable nightly/depend builders on staging-trunk-automation

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/automation/staging-1.9/master.cfg,v  <--  master.cfg
new revision: 1.2; previous revision: 1.1
done
Attachment #292529 - Attachment description: enable nightly/depend builders on staging-trunk-automation → [checked in] enable nightly/depend builders on staging-trunk-automation
Blocks: 299909
This gets nightlies running on Mozilla1.8 branch (with not-included-here tinderbox-configs patches)
Attachment #293258 - Flags: review?(nrthomas)
Attachment #293258 - Flags: review?(nrthomas) → review?(bhearsum)
Comment on attachment 293258 [details] [diff] [review]
[checked in] mozilla 1.8 nightly config

>+c['bots'] = [("linux-1.8-console1","mozilla"),
>+             ("linux-1.8-console2","mozilla"),
>+             ("linux-1.8-slave1", "mozilla"),
>+             ("linux-1.8-slave2", "mozilla"),
>+             ("macosx-1.8-slave1", "mozilla"),
>+             ("macosx-1.8-slave2", "mozilla"),
>+             ("win32-1.8-slave1", "mozilla"),
>+             ("win32-1.8-slave2", "mozilla"),
>+             ("linux-trunk-slave1", "mozilla"),
>+             ("linux-trunk-slave2", "mozilla"),
>+             ("macosx-trunk-slave1", "mozilla"),
>+             ("macosx-trunk-slave2", "mozilla"),
>+             ("win32-trunk-slave1", "mozilla"),
>+             ("win32-trunk-slave2", "mozilla")]

To be consistent, you should take out the passwords here. r=bhearsum with that changes.
Attachment #293258 - Flags: review?(bhearsum) → review+
Whiteboard: testing, waiting for feedback
Priority: P2 → P3
Comment on attachment 293258 [details] [diff] [review]
[checked in] mozilla 1.8 nightly config

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/automation/staging/master.cfg,v  <--  master.cfg
new revision: 1.11; previous revision: 1.10
done
Attachment #293258 - Attachment description: mozilla 1.8 nightly config → [checked in] mozilla 1.8 nightly config
Depends on: 410806
Blocks: 408117
Depends on: 410869
Depends on: 397554
Blocks: 411629
No longer depends on: 410869
Whiteboard: testing, waiting for feedback → waiting for 2.0.0.12 release to ship
Priority: P3 → P2
Whiteboard: waiting for 2.0.0.12 release to ship
Depends on: 417147
Whiteboard: start with bug 417147
No longer blocks: 411629
Whiteboard: start with bug 417147
Depends on: 421411
Summary: Migrate nightly builds to be done using same automation, hardware as release automation → tracking bug for moving nightlies to release automation
Whiteboard: waiting on blockers
Priority: P2 → P3
Returning this to the pool. 
Assignee: robert → nobody
Status: ASSIGNED → NEW
QA Contact: build → release
Triaged.
Component: Release Engineering → Release Engineering: Future
Component: Release Engineering: Future → Release Engineering
Assignee: nobody → catlee
Mozilla 1.9 / Firefox 3.0.x nightlies are staying on Tinderbox (see bug 421411).

Mozilla 1.9.1 and beyond are already on release automation (buildbot).
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Resolution: FIXED → WONTFIX
We did this for 1.8 and decided not to for 1.9, I'm adjusting the summary and resolution.
Resolution: WONTFIX → FIXED
Summary: tracking bug for moving nightlies to release automation → tracking bug for moving 1.8 nightlies to release automation
Whiteboard: waiting on blockers
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.