402625 - popup menus for <select>s don't have a native popup menu appearance

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect, P4)

Description

[Sindre Aarsaether]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-us) AppleWebKit/523.10.3 (KHTML, like Gecko) Version/3.0.4 Safari/523.10
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8) Gecko/2007091211 GranParadiso/3.0a8

The appearance of the form-elements themselves look like native cocoa-elements in Gran Paradiso (finally), but the select-dropdown does not look like it should in OS X (tiger).

Will this be implemented before the final version, or are there no plans to change the (odd ) dropdown?

Reproducible: Always

Steps to Reproduce:
1. Open any select-box
2. Open any select-box in Camino/Safari or any other OS X application to see how it is supposed to look.
Actual Results:  
http://www.identu.no/selects.jpg

Expected Results:  
Should show native dropdown (semitransparent rounded in OS X Leopard).

I do understand that this is not about skinning the box so that it looks like it does in OS X, and that Camino and Safari probably use the elements in some native way that Gran Paradiso does not. But I was wondering if it is possible / probable that the dropdowns will be implemented the 'right' way before final release.

Comment 1

[Sindre Aarsaether]

Attachment: Image showing the difference

Comment 2

[Jesse Ruderman]

Sindre, is the rounded look for popup menus only in Leopard, or is it in Tiger too?  I don't see it in Tiger, but I might not be looking in the right place.

Josh, do you know whether we're planning to fix the transparency and rounding for 1.9?  (I assume we're not planning to change the dropdown menu into an in-place popup menu.)

Comment 3

[Sindre Aarsaether]

No, I don't believe it's rounded in Tiger, and that is part of the problem. It seems that GranParadiso for mac has menus/contextmenus etc that match the Tiger-look, but looks out of place in Leopard.

Atleast, if you will not use native cocoa-menus (for selectbox), make it a little more mac-like than it is now with the black/white shadowy borders etc :-)

Comment 4

[gav]

No I am running on Tiger 10.4 and it's incorrect there too.  It doesn't look like the developers have implemented the native dropdowns from the OS yet.

One of the key improvements in Firefox 3 for many mac users will be its use of native widgets.  So far with every nightly build this is the first thing I check.  I certainly hope that this gets fixed soon.

Comment 5

[gav]

Attachment: comparison (to safari)

Comment 6

[Sindre Aarsaether]

(In reply to comment #5)
> Created an attachment (id=293458) [details]
> comparison (to safari)
> 

That comparison is from Tiger. The biggest difference in style is with Leopard (which is shown in the first attachment).

Comment 8

[gav]

is anyone working on this bug?

if so,  please let me know how i can help.

Comment 10

[Justin Dolske [:Dolske]]

Seems like this is one of the few remaining things that really stands out as non-native on OS X... We should really try to fix this for 1.9.2, IMO.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also bug 430745, on which this probably depends, about the position/height (i.e., layout) part of this; the preference in that bug seems to be for making this bug cover the native theming of the appearance of the menu once layout had the positioning working. Hopefully the new summary better expresses that?

Comment 13

[u382323]

Will there be a fix sometime?  This is annoying for Mac OS X users...

Comment 14

[Markus Stange [:mstange]]

Some time, yes. At the moment necessary groundwork is being in bug 558072.

Comment 16

[İsmail Dönmez]

This is still not fixed in Firefox 4.0 nightlies.

Comment 18

[Max, @maxart]

This is still not fixed in Aurora (5.0a2)
For reference, capture of Safari vs Firefox 4: http://cl.ly/0i2S2s2O022O2j0K1r1x

Comment 19

[David Hsu]

I don't think anyone's working on this, not even a WIP, no, which is sad.
Because although it's subtle, it gives a great deal of non-nativeness to Firefox on Mac.

We can only hope that someone may get really bored in his/her tea break and finally want to take a look at this, thanks a million to whoever that's gonna be...

Comment 20

[Drew Willcoxon :adw]

I'm noodling around with this and bug 430745.  If someone who knows what they're doing is actively working on it, please feel free to take it.

Comment 21

[Mounir Lamouri (:mounir)]

(In reply to Drew Willcoxon :adw from comment #20)
> I'm noodling around with this and bug 430745.  If someone who knows what
> they're doing is actively working on it, please feel free to take it.

I have a patch that more or less fix the issue on Linux but there is a small bug to fix in addition of making things worse on MacOS. I looked at what was happening on MacOS but wasn't able to find why we are not using the native theme for the dropdown. If you can find what is happening here we could try to find a fix that would work for all systems.

Comment 22

[Mounir Lamouri (:mounir)]

(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #21)
> I have a patch that more or less fix the issue on Linux [...]

See bug 674443.

Comment 23

[Justin Dolske [:Dolske]]

(In reply to Drew Willcoxon :adw from comment #20)
> I'm noodling around with this and bug 430745.

<3

zpao has been working on some Cocoa things recently, he might be a good local source of help lest ye be needing it.

Comment 24

[Steven Michaud [:smichaud] (Retired)]

Any progress? :-)

Comment 25

[Sierk Bornemann]

I side with Steven Michaud and ask: Any progress in this issue? *nudge* :-)

Comment 26

[Sierk Bornemann]

Any progress in this issue? :)

Comment 27

[Drew Willcoxon :adw]

No, and I'm not working on this anymore.

Comment 28

[Florian Bender]

Quick update: Looks like Bug 674443 has some preliminary work going on, according to Bug 674443 Comment 0, Mounir Lamouri will then go on fixing this bug.

Comment 31

[dan]

:(

Comment 32

[Mike Conley (:mconley) (:⚙️)]

Note that this bug is actually fixed for users with e10s enabled.

Users without e10s can force enable that mode by setting dom.select_popup_in_parent.enabled to true - though I don't believe we've ironed all of the bugs out of it yet (especially accessibility-wise).

Comment 33

[staleydyla.n]

I'm still seeing this bug on Firefox 57. Notable examples include facebook.com (when logged out) and the "Create a new AWS Account" page on AWS.

Comment 34

[staleydyla.n]

Ah, sorry, the popup menu itself has the correct appearance. It's the <select> element that looks like it's from Windows 95.

Comment 35

[Dan]

It's actually Windows 3.1, I think :)  This may seem trivial but it makes Firefox seem less polished given that many, many sites show partially restyled select inputs.  A good example is the default Bootstrap select style -- http://getbootstrap.com/docs/4.0/components/forms/. Just taking away the gray "3D" button would work.  (And maybe remove or give a proper way via CSS to restyle the dotted focus rectangle.)  Is there another existing bug for this?

Comment 36

[:Gijs (he/him)]

e10s is now enabled everywhere, so we can close this.