402729 - [10.5] Unified window color is too light in Firefox and Thunderbird

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Patrick]

Attachment: Screenshot showing that the title bar of the active window is too light.

Using version 3.0a1pre (2007110603) on PPC, the title bar of Thunderbird doesn't blend in with the new uniform look of Leopard. The attached screenshot shows an active Thunderbird window in the front, with a very light title bar. The window in the back is from Minefield, with a much darker title bar. 

In leopard, the active window should be the darkest.

FWIW: Minefield  Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O 10.5; en-US; rv:1.9a9pre) Gecko/2007110104 Minefield/3.0a9pre  looks ok though

Comment 1

[Reed Loden [:reed]]

Dupe of bug 402660?

Comment 2

[Patrick]

(In reply to comment #1)
> Dupe of bug 402660?
> 

Unsure. That bug deals with Tiger, this one with Leopard. Looks like TB is off on both :o

However, it looks like the patch for bug 402660 fixes both?

Comment 3

[Patrick]

The light window also showed up in Minefield  Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O 10.5; en-US; rv:1.9a9pre) Gecko/2007110604 Minefield/3.0a9pre --> moving to core.

So regression window is then between Gecko/2007110104 and Gecko/2007110604

Comment 4

[Håkan Waara]

I think highlighting when a window is focused and not is very important. 

This makes Firefox's windows feel very odd to work with, since they always use the "unfocused" look, even when in front.

Comment 5

[Colin Barrett [:cbarrett]]

Seems this was intentional. bug 402125. This isn't a core bug.

There is another issue where we don't do the *background* state correctly, which you can see in this screenshot, but that's been known, and I just filed bug 404096 about it.

Comment 6

[Colin Barrett [:cbarrett]]

I'd move this to toolkit, but there's not toolkit/themes product/component, despite there being themes there. :(

Comment 7

[Philip Hofstetter]

the shade of color I'm seeing on my freshly installed Beta 1 is exactly the color of an inactive window - despite FF being in the foreground.

Also, when putting another application in the foreground, the window color of FF doesn't change (it should get lighter)

Comment 10

[u49640]

(In reply to comment #7)
> the shade of color I'm seeing on my freshly installed Beta 1 is exactly the
> color of an inactive window - despite FF being in the foreground.

I think its even lighter than a normal inactive window. see the attachments in my bug 405287 

Comment 11

[Joe Drew (not getting mail)]

This has changed as of b3/current trunk. We're now the right colour in the foreground, but when Firefox gets sent to the background it stays dark grey when it should be light.

Comment 12

[Samuel Sidler (old account; do not CC)]

Joe, please file a new bug on that. We typically don't re-purpose bugs for opposite behavior.

This bug was actually fixed by the switch to proto on trunk. Resolving as such.

Comment 13

[Joe Drew (not getting mail)]

Sorry about that. Bug 417119 is the bug for Cocoa widgets always looking like they're in the foreground.