404689 - "TokensToQueries(), ignoring unknown key" / "resolveNullBookmarkTitles" warnings to the console when I search in bookmarks organizer

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

warnings to the console when I search in bookmarks organizer

note, this is even after mano's fix for bug #404446

WARNING: TokensToQueries(), ignoring unknown key: : file /Users/sspitzer/Desktop/trunk/mozilla/toolkit/components/places/src/nsNavHistoryQuery.cpp, line 771
WARNING: resolveNullBookmarkTitles: file /Users/sspitzer/Desktop/trunk/mozilla/toolkit/components/places/src/nsNavHistoryQuery.cpp, line 772
WARNING: TokensToQueries(), ignoring unknown key: : file /Users/sspitzer/Desktop/trunk/mozilla/toolkit/components/places/src/nsNavHistoryQuery.cpp, line 771
WARNING: resolveNullBookmarkTitles: file /Users/sspitzer/Desktop/trunk/mozilla/toolkit/components/places/src/nsNavHistoryQuery.cpp, line 772

Comment 1

[(not reading, please use [e-mail] instead)]

note, searching seems to work fine.

Comment 2

[Asaf Romano (gone)]

I would bet this happens because you've had that search already saved. We cannot remove this option from saved queries.

Comment 3

[Dietrich Ayala (:dietrich)]

this will occur for any pre-b2 profiles w/ that since-removed key. we ignore (but warn, obviously) when we encounter unknown keys in places queries, so it shouldn't break anything.

(In reply to comment #2)

> I would bet this happens because you've had that search already saved. We
> cannot remove this option from saved queries.
> 

we could, but cost of doing so outweighs the benefits.

Comment 4

[(not reading, please use [e-mail] instead)]

you guys are both right.

1) I had two old saved searches (from the special Places folder).
2) The work around was to manually edit the urls from within the organizer.
3) I'm glad we gracefully handle keys we don't understand (see bug #399367)
4) we could fix this, but I agree with dietrich, risk > reward.

based on all this, marking as WONTFIX.

updating summary, as I'm sure our excellent nightly testers will run into this and query for it.

Comment 5

[(not reading, please use [e-mail] instead)]

note, we'll be doing some migration for bugs #399477 and bug #404871.

when we fix those issues, we'll be indirectly fixing this bug.

Comment 6

[(not reading, please use [e-mail] instead)]

> when we fix those issues, we'll be indirectly fixing this bug.

actually, this is not true, as we removing the old "Places" folder is wontfixed.

see bug #406696

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv