407399 - Disable prebinding for trunk builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Mentovai]

The default mozconfigs still specify this for trunk builds:

ac_add_app_options ppc --enable-prebinding

These lines should be removed now that the minimum supported OS version is 10.4 on all architectures.  Prebinding is not a performance improvement on 10.4.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

As I discovered tonight, the plague of useless prebinding has spread far-and-wide across the Mozilla world as Firefox has replicated its mozconfig for buildbot, the try-server, etc.

Comment 3

[Phil Ringnalda (:philor)]

I should have known that just treating the infection in Thunderbird, without giving Typhoid Firefox a course of antibiotics too, wouldn't last.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: [checked in] Fix buildbot-configs, v.1

I'm going to need some handholding, since I don't have a clue how the buildbot configs actually work and get pulled and whatnot, but counting on someone else to get rid of prebinding apparently isn't going to work out.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Adding Apple doc to URL as confirmation.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 341865 [details] [diff] [review]
[checked in] Fix buildbot-configs, v.1

r+ for the mozilla2/ and mozilla2-staging/ changes, which will be picked up the first build after you push the changes to the repo. Try server config is at mozilla/tools/buildbot-configs/tryserver/mozconfig-mac in cvs; it'll need a helping hand from us to deploy.

Setting r? for Seamonkey and Thunderbird.

Comment 7

[Phil Ringnalda (:philor)]

Attachment: Remove --enable-prebinding in mozilla-central

Make the bad things go away!

Comment 8

[Phil Ringnalda (:philor)]

Attachment: Remove --enable-prebinding in comm-central

And the clone of the bad thing, too.

Comment 9

[Philippe M. Chiasson (:gozer)]

Comment on attachment 341865 [details] [diff] [review]
[checked in] Fix buildbot-configs, v.1

Works for me.
Plus, the closer our mozconfigs get between different architectures, the better.

Comment 10

[Phil Ringnalda (:philor)]

Attachment: [checked in] Fix tryserver config

The last one, I hope.

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 341875 [details] [diff] [review]
Remove --enable-prebinding in mozilla-central

yes plz.

Comment 12

[[e-mail] (:bhearsum)]

Comment on attachment 341878 [details] [diff] [review]
[checked in] Fix tryserver config

Checking in mozconfig-mac;
/cvsroot/mozilla/tools/buildbot-configs/tryserver/mozconfig-mac,v  <--  mozconfig-mac
new revision: 1.3; previous revision: 1.2
done

Comment 13

[Robert Kaiser]

Comment on attachment 341865 [details] [diff] [review]
[checked in] Fix buildbot-configs, v.1

OK, from all I hear this is only on the basis of prebinding being "potentially unhelpful and probably not helpful nowadays" - but there's one argument for the change I can see: it cleans up some buildsystem stuff ;-)

Comment 14

[Robert Kaiser]

Comment on attachment 341876 [details] [diff] [review]
Remove --enable-prebinding in comm-central

cleaning up the buildsystem is usually stuff I like :)

Comment 15

[Phil Ringnalda (:philor)]

Pushed the Thunderbird and SeaMonkey mozconfigs in http://hg.mozilla.org/build/buildbot-configs/rev/8a20c6eae8e6 - I'm holding off on the Firefox ones and the dropping support until mozilla-central reopens, despite Ted's attempts to lead me astray ;)

Comment 16

[Phil Ringnalda (:philor)]

Attachment: [checked in] A dose of penicillin for Sunbird

It's like an STD, only not as much fun to get.

Comment 17

[cmtalbert]

Comment on attachment 342396 [details] [diff] [review]
[checked in] A dose of penicillin for Sunbird

Looks good to me.  r=ctalbert

Thanks for the flu shot philor

Comment 18

[Phil Ringnalda (:philor)]

Comment on attachment 342396 [details] [diff] [review]
[checked in] A dose of penicillin for Sunbird

http://hg.mozilla.org/build/buildbot-configs/rev/cb1e9eb7d250

Now if I could just get a green tree and sea room with mozilla-central...

Comment 19

[Phil Ringnalda (:philor)]

Comment on attachment 341865 [details] [diff] [review]
[checked in] Fix buildbot-configs, v.1

Pushed the mozilla-central mozconfigs in http://hg.mozilla.org/build/buildbot-configs/rev/91476b111b72

Comment 20

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/15996a62596e and http://hg.mozilla.org/comm-central/rev/5d4a98ac7867 and we're done.

Comment 21

[Joe Sabash [:JoeS1]]

I don't see anything else in build config that could have caused bug 459569 'cept this. But, I've been wrong before.

Comment 22

[Phil Ringnalda (:philor)]

Not guilty, Your Honor.