Last Comment Bug 408766 - Apache::DBI is a premature optimization that causes trouble
: Apache::DBI is a premature optimization that causes trouble
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Database (show other bugs)
: 3.0.2
: All All
: -- normal (vote)
: Bugzilla 3.0
Assigned To: Max Kanat-Alexander
: default-qa
:
Mentors:
: 366884 (view as bug list)
Depends on:
Blocks: 441592
  Show dependency treegraph
 
Reported: 2007-12-17 19:20 PST by Max Kanat-Alexander
Modified: 2008-07-29 16:40 PDT (History)
1 user (show)
mkanat: approval+
mkanat: approval3.0+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (2.73 KB, patch)
2007-12-17 19:22 PST, Max Kanat-Alexander
justdave: review+
Details | Diff | Splinter Review

Description Max Kanat-Alexander 2007-12-17 19:20:10 PST
Currently Bugzilla requires and uses Apache::DBI to maintain connections to the database.

However, connecting to the database only takes a tiny fraction of a second, and there isn't load enough on any Bugzilla database anywhere to justify it. 

On the other hand, in certain circumstances the database handles seem to stay open after a request ends, leading to weird "server went away" errors from MySQL.

So overall, we don't need it and it seems to be causing us problems.
Comment 1 Max Kanat-Alexander 2007-12-17 19:22:56 PST
Created attachment 293617 [details] [diff] [review]
v1
Comment 2 Max Kanat-Alexander 2007-12-18 16:40:47 PST
<justdave> and you'll be happy to know that we got the error messages working on the cluster, and there have been no ocurrences whatsoever of "Lost connection to MySQL server during query" since our config change yesterday :)

(He means the change made in this patch.)
Comment 3 Max Kanat-Alexander 2007-12-18 16:45:37 PST
tip:

Checking in mod_perl.pl;
/cvsroot/mozilla/webtools/bugzilla/mod_perl.pl,v  <--  mod_perl.pl
new revision: 1.8; previous revision: 1.7
done
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.107; previous revision: 1.106
done
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.41; previous revision: 1.40
done
Checking in docs/xml/installation.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/xml/installation.xml,v  <--  installation.xml
new revision: 1.148; previous revision: 1.147
done

3.0 branch:

Checking in mod_perl.pl;
/cvsroot/mozilla/webtools/bugzilla/mod_perl.pl,v  <--  mod_perl.pl
new revision: 1.5.2.2; previous revision: 1.5.2.1
done
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.93.2.4; previous revision: 1.93.2.3
done
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.29.2.2; previous revision: 1.29.2.1
done
Checking in docs/xml/installation.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/xml/installation.xml,v  <--  installation.xml
new revision: 1.136.2.7; previous revision: 1.136.2.6
done
Comment 4 Max Kanat-Alexander 2008-06-30 23:55:29 PDT
relnoted for 3.0.3 long ago, removing relnote keyword.
Comment 5 Max Kanat-Alexander 2008-07-29 16:40:31 PDT
*** Bug 366884 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.