441592 - DB connections not closing under mod_perl

Status: RESOLVED FIXED

(Bugzilla :: Database, defect, P1)

Description

[Denis Roy]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.13) Gecko/20080316 SUSE/2.0.0.13-0.2 Firefox/2.0.0.13
Build Identifier: R3.0.4

As discussed on mozilla.support.bugzilla, the Bugzilla 3.0 release/stable stream is missing this line in the Bugzilla::ModPerl::CleanupHandler

Bugzilla::_cleanup();


In CVS, mod_perl.pl with the rtag Bugzilla_Stable, BUGZILLA-3_0_4, BUGZILLA-3_0_3 and BUGZILLA-3_0-STABLE is 1.5.2.2, and that version does not call Bugzilla::_cleanup();

Anyone installing BZ from CVS, using any of those rtags and using mod_perl will likely have a problem with too many DB connections to the master.

The call to Bugzilla::_cleanup() appears in mod_perl.pl 1.6, which is rtagged BUGZILLA-3_1_1 (and BUGZILLA-3_1_2).

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Max Kanat-Alexander]

This is essentially a regression of bug 408766. Or at the least, having Apache::DBI around hid this problem, because when you have persistent connections, you don't need to close them.

Comment 2

[Max Kanat-Alexander]

Attachment: Looks good. r=dkl

Denis, could you tell me if this patch works?

And dkl, I just need a code review on this ridiculously small patch.

Comment 3

[Denis Roy]

I tested the patch on R3.0.4 and my connection count went from 400+ to 30.   I'd set the review flag, but I'm not authorized to.

Comment 4

[Max Kanat-Alexander]

Comment on attachment 326517 [details] [diff] [review]
Looks good.

r=dkl

Okay, I'm setting this for Denis.

Comment 5

[Max Kanat-Alexander]

Checking in mod_perl.pl;
/cvsroot/mozilla/webtools/bugzilla/mod_perl.pl,v  <--  mod_perl.pl
new revision: 1.5.2.3; previous revision: 1.5.2.2
done

Comment 6

[Frédéric Buclin]

Don't forget to relnote this one when releasing 3.0.5. :)

Comment 7

[Peter]

I experienced the same problem in 3.0.5. After using bugzilla for a while i get the "too many connections" error and have to restart mysql.

The changes in the patch provided for this bug are in the mod_perl.pl .

mysql: 5.0.18, for suse-linux (i686)
  maxconnection = 300

Webserver: apache2, keepalive off
  mod_perl

Brwoser: Firefox 3.0.1

What other information could be helpful?

Comment 8

[Max Kanat-Alexander]

(In reply to comment #7)
How many httpd children are there, at the time? Does Bugzilla display its version number as 3.0.5 on the home page?

Comment 9

[Peter]

There are 8 httpd childen. The version shown on the home page is 3.0.5.

Comment 10

[Max Kanat-Alexander]

Okay. When MySQL is locked up, can you get me the output of:

SHOW FULL PROCESSLIST;

And attach it here as an attachment (not a comment)?

Comment 11

[Peter]

Attachment: process list of mysql

maxconnections was not defined in my.cnf (-> default = 100) to produce the error faster. It also occurs with maxconnections=300

Comment 12

[Max Kanat-Alexander]

Okay, can you go to the root of your Bugzilla installation and do a "cvs -q diff -Nu" and attach the results of that?

Comment 13

[Peter]

Attachment: mod_perl diff & apache config

a colleague of me commented out the line with add_config, but added the whole thing directly in the apache config file

Comment 14

[Max Kanat-Alexander]

Okay. If you're not using the mod_perl.pl config (which you're not, since you commented out that line), then your problem comes from that and we can't be held responsible in any way for anything that happens to your installation, including the fact that it's probably going to leak memory like mad.

So anyhow, your issue is not a bug in Bugzilla, and this bug is still validly FIXED.

Comment 15

[Peter]

you are right. sorry for vasting your time.