40879 - Add ident server

Status: VERIFIED FIXED

(Other Applications Graveyard :: ChatZilla, enhancement, P3)

Description

[Daniel Morgan]

Certain operating systems, such as, Windows 95 and NT (I'm not sure about 
98 or 2000) do not come with the Ident Server that adheres to RFC 1413.  Unix 
and GNU/Linux systems typically come with this Identification server.  
Sometimes, this server isn't setup properly on GNU/Linux systems.

There are many IRC hosts that require a running Ident server running, ie., many 
hosts on the EFNet IRC network require a properly configured ident server.  
Because there is no running identd server or there is a improperly configured 
identd server, the user is not allowed to connect to these hosts.

I have a feature request that a built-in RFC 1413 compliant Identification 
server be added to ChatZilla so a ChatZilla user can connect to these 
identd-required hosts.  Both mIRC for Windows and OpenChat/2 for OS/2 have a 
built-in identd server.

By default, the built-in identification server should be disabled for those 
platforms/operating systems that include identd.

I do ask for help on how this could be accomplished.

Comment 1

[Blake Ross]

Removing feature designation from summary, made it sound like a feature w-i-p

Comment 2

[David Krause]

*** Bug 42579 has been marked as a duplicate of this bug. ***

Comment 3

[Robert Ginda]

mass accepting chatzilla bugs and marking "future"

Comment 4

[timeless]

Moving to All/All. Just because os's come w/ identd doesn't mean that the 
admins set it up or want to use it.  This should be an XP feature not win 
specific.  Mac OS also doesn't usually come w/ an identd server so this would 
have to be All/All anyways.

Comment 5

[David Krause]

*MASS SPAM*

Changing QA contact on all open or unverified ChatZilla bugs to me, David
Krause, as I am now the QA contact for this component.

Comment 6

[Garth Wallace]

This is probably dependant on bug #74045.

Comment 7

[Matthias Versen [:Matti]]

*** Bug 87483 has been marked as a duplicate of this bug. ***

Comment 8

[David Krause]

Remove myself from QA of 33 open Chatzilla bugs and change to default QA
contact, since I have no way to verify these easily.  Still no working Mozilla
on my primary platform and it doesn't look like it will happen anytime soon. :(

Comment 9

[Adrian Ulrich]

*** Bug 149188 has been marked as a duplicate of this bug. ***

Comment 10

[Sebastian Späth]

There are several free identd servers for Windows which are standalone.
I propose to just include a download link in the help file to one or two of them
and have the user install it herself if seh needs identd (at least as solution
on Win) Don't bloat the standard distribution with this (my opinion).

see e.g.: http://freeware.teledanmark.no/identd/ (GPL, 330kb zip)
or: http://www.tinyirc.net/identd.shtml
#  Supports IPv4 and IPv6
# Miniscule 22K executable
# Sits inobtrusively in your system tray
# Full logging support
# Built-in setup to create shortcuts

Comment 11

[:Gijs (away/busy until Mar 10)]

> I propose to just include a download link in the help file to one or two of them
> and have the user install it herself if seh needs identd (at least as solution
> on Win)

I like this suggestion, would it not be possible to simply have a FAQ entry for
this?

Comment 12

[Samuel Sieb]

Here's a plugin to do it: http://rdmsoft.com/dlfs/cz/identd.js

Comment 13

[:Gijs (away/busy until Mar 10)]

(In reply to comment #12)
> Here's a plugin to do it: http://rdmsoft.com/dlfs/cz/identd.js

In light of that plugin, I think that it's now up to Rob, James and Samuel to
decide if this should remain a plugin/script, or if this should be integrated.
In the first case, this bug should be wontfixed, in the second, probably
assigned to Robert Marshall (who wrote the plugin) in order to integrate it
(assuming he wouldn't mind doing so).

Rob, James, Samuel, any ideas? :-)

Comment 14

[James Ross]

Since we have a FAQ entry, and it is not nessessary for the majority of servers,
my vote is for WONTFIX.

Comment 15

[timeless]

most of undernet refuses to allow me to connect w/o an identd

Comment 16

[Prognathous]

I can't connect to Dalnet for the very same reason.

Prog.

Comment 17

[James Ross]

So some servers on two networks are stuck in the last decade... doesn't change
my personal opinion.

Comment 18

[Samuel Sieb]

Personally, I think that any server requiring identd is broken.  However, there
are a lot of broken irc servers out there.  I would be inclined to put it in if
someone wants to put it together, including prefs for managing it.  Remember
that it can't break chatzilla on anything back to Mozilla 1.0, so the code will
have to check for server socket support.  See the dcc code for example.

Comment 19

[Rob Marshall [tH]]

Taking, I'll create an ident server based on my plugin that is off by default, and only enables itself during the connection process for user-selected networks.
Adding rfc link so I don't forget. ;)

Comment 20

[Rob Marshall [tH]]

Attachment: js/lib/ident.js

This depends on one small change in connection-xpcom.js (replacing this._serverSock.close() with this.close() in accept()).

Comment 21

[James Ross]

Comment on attachment 210614 [details]
js/lib/ident.js

>IdentListener.prototype.onStreamDataAvailable =
>function ident_listener_sda(request, inStream, sourceOffset, count)
>{
>    var ev = new CEvent ("ident-listener", "data-available", this,
>                         "onDataAvailable");

Nit: no space before parenthesis.


>    if (incomplete)
>        this.savedLine = lines.pop()
>
>    for (i in lines)
>    {
>        ev = new CEvent ("ident-listener", "rawdata", this, "onRawData");

Nit: same.


>IdentListener.prototype.onParsedRequest =
>function ident_listener_request(e)
>{
>    function response(str)
>    {
>        return e.localPort + " , " + e.remotePort + " : " + str + "\r\n";
>    }

Nit: semi-colon after inner functions.


>    var found, responses = this.server.responses;
>    for (var i = 0; i < responses.length; ++i)
>    {
>        if (e.remotePort == responses[i].port &&
>            this.connection._transport.host == responses[i].ip)

Nit: add parens around the binary ops (even though they have higher precedence).


Otherwise, looks good. Perhaps could do with some more comments just explaining that (for example) it keeps a single listening connection open when any network is connecting, and only closes when there are not doing so.

Comment 22

[Rob Marshall [tH]]

Attachment: diff -N

ident.js is the same, except:
- picked nits, added more comments
- removed space after "USERID : CHATZILLA :" because technically it was part
  of the username (RFC1413, section 5, note 1)
- moved var keyword in IdentListener.onDataAvailable, no change in logic

The identd pref defaults to false, and is hidden on Linux and Mac (because it would only work as root, and those OSes should include an identd). removeNetwork is always called, regardless of the pref, just in case the pref was changed during connection.

Comment 23

[James Ross]

Comment on attachment 211188 [details] [diff] [review]
diff -N

>+    client.prefManager.identGroup = ".connect";
>+    // Linux and OS X won't let non-root listen on port 113.
>+    if((client.platform == "Linux") || (client.platform == "Mac"))

I see you're not completely trained yet. ;)

>+        client.prefManager.identGroup = "hidden";

Interesting use of randomly setting a prop - probably shouls put a quick comment to note that this is so that network pref managers get the same group.

r=silver with the nit fixed, and a comment.

Comment 24

[:Gijs (away/busy until Mar 10)]

Checked in --> FIXED