410114 - Simplify nsTransform2D

Status: VERIFIED FIXED

(Core Graveyard :: GFX, defect)

Description

[Alfred Kayser]

Attachment: V1: Remove type and all the corresponding if/switch statements.

Remove 'type' from nsTransform2D, and remove all 'if'/'switch' branching.
This reduces size of nsTransform2D: datasize 16 bytes instead of 20. (although type is short, the class is 4byte padded). codesize: as many functions are now much simplier, and can be inlined in lot of cases.

Comment 1

[Alfred Kayser]

Attachment: V2: Smaller and simpler patch to remove the type and the unused methods

Keep the body of the methods in the .cpp file, and remove the unused methods.
This version saves about 5K objectsize (on Windows).

Comment 2

[Alfred Kayser]

This is a kind of a followup from bug 291636 and bug 290885 where similar cleanups where done.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

ScaleXCoords and ScaleYCoords are not used (gfx/src/windows and gfx/src/mac are not built).

SetToIdentity is not used (the code in nsBulletFrame is #if 0'ed out and should just be removed). Ditto SetToScale.

gfx/src/photon isn't built, so GetX/YTranslation(Coord) can be removed (no point in keeping them just for debug printf in SVG).

I haven't checked all the others ... basically just take a closer look at the users, most of them aren't real.

Comment 4

[Alfred Kayser]

Attachment: V3: Much more cleanup, including removal of "#if 0" from nsBulletFrame

Created bug 419000 to remove the old debug code from SVG.

Comment 5

[Alfred Kayser]

Created bug 419004 to remove /gfx/src/beos.
Bug 384057 is for the removal of /gfx/src/photon.
Bug 418104 is for the removal of /gfx/src/windows

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 304942 [details] [diff] [review]
V3: Much more cleanup, including removal of "#if 0" from nsBulletFrame

a1.9+=damons

Comment 7

[Reed Loden [:reed]]

Checking in gfx/public/nsTransform2D.h;
/cvsroot/mozilla/gfx/public/nsTransform2D.h,v  <--  nsTransform2D.h
new revision: 1.12; previous revision: 1.11
done
Checking in gfx/src/nsTransform2D.cpp;
/cvsroot/mozilla/gfx/src/nsTransform2D.cpp,v  <--  nsTransform2D.cpp
new revision: 3.19; previous revision: 3.18
done
Checking in layout/generic/nsBulletFrame.cpp;
/cvsroot/mozilla/layout/generic/nsBulletFrame.cpp,v  <--  nsBulletFrame.cpp
new revision: 1.169; previous revision: 1.168
done

Comment 8

[Alfred Kayser]

Thanks.

1200 code bytes saved:
 libxul.so
  	Total:	      -1200 (+52/-1252)
  	Code:	      -1195 (+0/+0)
  	Data:	         -5 (+52/-1252)