41404 - Crash in nsHTTPChannel::Authenticate when clicking cancel in HTTP authentication dialog

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Jeffrey Baker]

Mozilla crashes when you try to cancel an HTTP authentication dialog.  This is
Linux Build 2000060221.  To reproduce:

1) Start Moz and go to http://pause.kbx.de/pause/authenquery
2) When prompted for username and password, press the cancel button
3) Mozilla exits with a segmentation fault

This bug is independent of the state of the other widgets on the authentication
dialog.

Comment 1

[Jeffrey Baker]

Adding crash keyword

Comment 2

[Andreas Franke (gone)]

Confirmed on PC/Linux with build 2000060308.

#0  nsHTTPChannel::Authenticate ()                     from libnecko.so
#1  nsHTTPChannel::ProcessAuthentication ()            from libnecko.so
#2  nsHTTPChannel::ProcessStatusCode ()                from libnecko.so
#3  nsHTTPChannel::FinishedResponseHeaders ()          from libnecko.so
#4  nsHTTPServerListener::FinishedResponseHeaders ()   from libnecko.so
#5  nsHTTPServerListener::OnDataAvailable ()           from libnecko.so
#6  nsOnDataAvailableEvent::HandleEvent ()             from libnecko.so

Changing component from XPToolkit/Widgets to Networking, reassigning to default
owner and confirming. Adding name of crashing function to summary.

Comment 3

[Andreas Franke (gone)]

Attachment: stack trace with function symbols (PC/Linux, 6/2 sources)

Comment 4

[Andreas Franke (gone)]

This regressed between 2000053120 and 2000060208. Adding keyword.

Comment 5

[Andreas Franke (gone)]

This seems to be caused by Mike's checkin to nsHTTPChannel.cpp (Rev 1.186) and
nsBasicAuth.cpp (Rev 1.7) on Jun 1 17:23: "make HTTP auth pluggable (bug 39781)"

 

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Yeah, that looks like mine.

Lemme update my tree and build, I'll give it a whirl.

Comment 7

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

*** Bug 41466 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

*** Bug 41467 has been marked as a duplicate of this bug. ***

Comment 9

[Andreas Franke (gone)]

*** Bug 41517 has been marked as a duplicate of this bug. ***

Comment 10

[David Krause]

I reopened 41517 (it was marked as a dup) because this bug is for a crash on
clicking cancel. Bug 41517 is for entering user/pass and clicking ok and crashing.
I guess right now you're screwed either way, ie you will crash no matter what
you do. :-)

Comment 11

[David Krause]

bug 41517 is a dup of 41467 (which is also not a dup of this bug)

i think it's all straightened out now

Comment 12

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Attachment: Fix.

Comment 13

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I gots me a nice patch for this and the entered-username-and-password crash.
Looking for some R & A.

Comment 14

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

In da tree.

Comment 15

[Jeffrey Baker]

Confirmed does not crash when pressing cancel in authentication dialog.  Linux
Build 2000060508.

Comment 16

[Tom Everingham]

verified:
Linux 2000070420