Closed Bug 41404 Opened 26 years ago Closed 26 years ago

Crash in nsHTTPChannel::Authenticate when clicking cancel in HTTP authentication dialog

Categories

(Core :: Networking, defect, P3)

x86
Linux
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: jwbaker, Assigned: shaver)

References

()

Details

(Keywords: crash, regression, Whiteboard: fix attached, waiting for review and approval)

Attachments

(2 files)

Mozilla crashes when you try to cancel an HTTP authentication dialog. This is Linux Build 2000060221. To reproduce: 1) Start Moz and go to http://pause.kbx.de/pause/authenquery 2) When prompted for username and password, press the cancel button 3) Mozilla exits with a segmentation fault This bug is independent of the state of the other widgets on the authentication dialog.
Adding crash keyword
Keywords: crash
Confirmed on PC/Linux with build 2000060308. #0 nsHTTPChannel::Authenticate () from libnecko.so #1 nsHTTPChannel::ProcessAuthentication () from libnecko.so #2 nsHTTPChannel::ProcessStatusCode () from libnecko.so #3 nsHTTPChannel::FinishedResponseHeaders () from libnecko.so #4 nsHTTPServerListener::FinishedResponseHeaders () from libnecko.so #5 nsHTTPServerListener::OnDataAvailable () from libnecko.so #6 nsOnDataAvailableEvent::HandleEvent () from libnecko.so Changing component from XPToolkit/Widgets to Networking, reassigning to default owner and confirming. Adding name of crashing function to summary.
Assignee: trudelle → gagan
Status: UNCONFIRMED → NEW
Component: XP Toolkit/Widgets → Networking
Ever confirmed: true
QA Contact: jrgm → tever
Summary: Crash when clicking cancel in HTTP authentication dialog → Crash in nsHTTPChannel::Authenticate when clicking cancel in HTTP authentication dialog
This regressed between 2000053120 and 2000060208. Adding keyword.
Keywords: regression
This seems to be caused by Mike's checkin to nsHTTPChannel.cpp (Rev 1.186) and nsBasicAuth.cpp (Rev 1.7) on Jun 1 17:23: "make HTTP auth pluggable (bug 39781)"
Yeah, that looks like mine. Lemme update my tree and build, I'll give it a whirl.
Assignee: gagan → shaver
*** Bug 41466 has been marked as a duplicate of this bug. ***
*** Bug 41467 has been marked as a duplicate of this bug. ***
*** Bug 41517 has been marked as a duplicate of this bug. ***
I reopened 41517 (it was marked as a dup) because this bug is for a crash on clicking cancel. Bug 41517 is for entering user/pass and clicking ok and crashing. I guess right now you're screwed either way, ie you will crash no matter what you do. :-)
bug 41517 is a dup of 41467 (which is also not a dup of this bug) i think it's all straightened out now
Attached patch Fix. — — Splinter Review
I gots me a nice patch for this and the entered-username-and-password crash. Looking for some R & A.
Status: NEW → ASSIGNED
Whiteboard: fix attached, waiting for review and approval
In da tree.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Confirmed does not crash when pressing cancel in authentication dialog. Linux Build 2000060508.
verified: Linux 2000070420
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: