415128 - Help→About dialog does not mention any license. (licenses, tri-license, MPL, source, EULA, license agreement)

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b3pre) Gecko/2008013104 Minefield/3.0b3pre

The Help→About dialog says “All rights reserved” twice — about the Contributors’ copyright and about the Mozilla’s trademarks.

Though that’s not scarier than “You must obey THE EULA!”, both the binary distribution’s and the source code’s licenses should be mentioned, IMO.

Comment 1

[[:Aleksej]]

Dupe of bug 366982?

Comment 2

[Gervase Markham [:gerv]]

It's slightly annoying that the two instances have different capitalization, but as per bug 366982, we aren't removing these references.

We should add in a reference to about:licence, but that's another question.

Gerv

Comment 3

[[:Aleksej]]

(In reply to comment #2)
> We should add in a reference to about:licence, but that's another question.

No, that’s what I meant. Cleaning the summary up.

Comment 4

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This patch adds a link to about:license on the About page. 

As well as being the right thing, there is a legal reason. The MPL says that the list of Initial Developers (which is part of about:license) must be included "prominently". The current method of waiting five minutes to scroll past all the credits before you can click on the licensing link does not, to my mind, count as "prominent".

It also fixes bug 368762, moving the Firefox word and logo copyright text to brand.dtd, thereby ensuring that it appears only when the branding itself does.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 328692 [details] [diff] [review]
Patch v.1 

Gavin, as a Firefox peer, can you review this?

The height increase is because the text, when the Firefox logo statement is included, now takes up an extra line. The logoCopyright entities are a single space because if they are entirely blank, it seems that the Firefox version "breaks through" into Minefield. Not sure why that is - some sort of overriding mechanism.

Gerv

Comment 6

[Gervase Markham [:gerv]]

gavin: ping?

Gerv

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 328692 [details] [diff] [review]
Patch v.1 

r=me from a technical standpoint, but I'm not confident that fixing bug 368762 is OK, given that we've not always been successful at removing all instances of "firefox" from non-official-branding builds.

Comment 8

[Gervase Markham [:gerv]]

I spoke to Harvey this afternoon; he's fine with fixing bug 368762. Sometime soon I'll update this patch and get it committed.

Gerv

Comment 9

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Updated for new copyright year. gavin's technical r= still applies. Requesting approval and string review.

Gerv

Comment 10

[Gervase Markham [:gerv]]

If this gets approved, can someone check it in? I have to go to bed... :-|

Thanks :-)

Gerv

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 355056 [details] [diff] [review]
Patch v.2

a191=beltzner

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Checked in on trunk and 1.9.1 branch:
https://hg.mozilla.org/mozilla-central/rev/87590083255c
https://hg.mozilla.org/releases/mozilla-1.9.1/rev/18d46de56913

Comment 13

[Gervase Markham [:gerv]]

Thanks, Gavin :-)

Gerv

Comment 14

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090130 Shiretoko/3.1b3pre Ubiquity/0.1.5 and 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090130 Minefield/3.2a1pre