417985 - Themes/subcategories aren't returning results when searching with "Interface Customizations" as a category filter

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Themes/subcategories aren't returning results when searching with "Interface Customizations" as a category filter

Steps to Reproduce:

1. Load https://preview.addons.mozilla.org/en-US/firefox/search?q=nasa+normal&cat=14 (which searches for the "NASA Normal" theme within the "Interface Customizations" category.

Actual Results:

"NASA Normal" isn't found, presumably because it has the following categories:

"Miscellaneous | Modern" (but doesn't appear bound/included in/mapped to the "Interface Customizations" category.

Expected Results:

It should be found, since it's just a subcategory of the soon-to-be-renamed "Interface Customizations" category.

(I looked, and couldn't find a duplicate, and I think it's worth it to get this fixed sooner rather than later; my apologies if it's already filed.)

Comment 1

[Michael Morgan [:morgamic]]

Might be a db issue with app-specific categories.

Comment 2

[Wil Clouser [:clouserw]]

As Fred explained in bug 417727#3, this is due to the joins for the hybrid categories.  

Comment 3

[Fred Wenzel [:wenzel]]

Laura: Will it break the addon manager if unrestricted (that is, without an explicitly chosen addon type) searches start returning search engines alongside themes and extensions?

If so, I will keep the default list at extensions+themes for now, but it will hardly be expected behavior for people searching that search engines only show up if they choose the search tools category by hand...

Comment 4

[Fred Wenzel [:wenzel]]

Okay I just filed bug 422254 for the issue I brought up in comment 3, because it exceeds the scope of this bug and may need more discussion.

Search results now return themes and search engines in sub-categories, with the restriction made above, meaning that you need to explicitly choose "search tools" in order to find search engines.

Changes are in r11203.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, modulo the search-engine stuff Fred mentions above in comment 4.