422254 - Search engines should show up on search when "all" is chosen as category

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Fred Wenzel [:wenzel]]

Per bug 417985 comment 3, if you don't explicitly choose the "search tools" category, no search engines will be displayed, before we figure out if this behavior would break the Firefox 3 add-on manager.

However, they should, because it's unexpected behavior for a user when a search result does not show up on choosing "all" as a category, but it does show up if you choose "search tools".

Laura, do you know what the Add-on manager asks the API for specifically, and if it can handle getting search engines back, among extensions and themes?

Comment 1

[Basil Hashem [:baz]]

Please add search engines as part of Search Result Page (SRP), don't include search engines as part of API.

Comment 2

[Michael Morgan [:morgamic]]

Laura, can you give Fred some pointers on how to do this so as to not affect the API then we can fix the public search.

Comment 3

[Fred Wenzel [:wenzel]]

Attachment: Return search engines for public but not API searches

This change to the search component returns search engines on searching through the public pages only, but when the API is performing the search, only extensions and themes are being returned, unless explicitly queried otherwise.

Does that seem reasonable, laura?

Comment 4

[Fred Wenzel [:wenzel]]

Thanks for the review. Fixed in r11602.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

https://addons.mozilla.org/en-US/firefox/search?q=a9&cat=all yields https://addons.mozilla.org/en-US/firefox/addon/4594 and others, among its results.

https://addons.mozilla.org/en-US/firefox/search?q=imdb&cat=all also yields https://addons.mozilla.org/en-US/firefox/addon/4605

Verified FIXED.