Closed Bug 418537 Opened 17 years ago Closed 17 years ago

Vista textfield appearance incorrect when focused

Categories

(Core :: Widget: Win32, defect, P2)

Product:
Core
Component:
Widget: Win32
Platform:
x86
Windows Vista
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: faaborg, Assigned: vlad)

References

Details

(Keywords: polish)

Attachments

(2 files, 1 obsolete file)

Examples of Firefox vs. native text fields on Vista
97.52 KB, image/png
Details
patch v2
7.75 KB, patch
pavlov
: review+
Details | Diff | Splinter Review
Our text fields in both chrome and content appear foreign on Vista. Related vista widget bug: every menulist should be a menubutton, bug 390737
Nominating for blocking to pick up wanted.
Flags: blocking1.9?
Blocks: 333484
Assignee: nobody → vladimir
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Depends on: 418552
Flags: tracking1.9+
Fixed by checkin for bug 418552.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
The active state is currently shown when the mouse is down, but should be shown when the field is focused, like native widgets. This looks like the problem with content selects, menubuttons, menu toolbarbuttons, split toolbarbuttons, etc. Reopen?
Sure, let's morph this.
Status: RESOLVED → REOPENED
Flags: blocking1.9+
Priority: P3 → P2
Resolution: FIXED → ---
Summary: Match native appearance of text fields on Vista → Vista textfield appearance incorrect when focused
Attached patch fix (obsolete) — — Splinter Review
The new editborder part uses a different set of style constants than the standard ones, turns out.
Attachment #306912 - Flags: review?
Attachment #306912 - Flags: review? → review?(pavlov)
Attached patch patch v2 — — Splinter Review
Let's go again here. This fixes all the issues with textfields and dropdowns, except for one: in native vista, when a dropdown is open, then dropdown arrow is not highlighted unless you explicitly hover over the dropdown. But in Gecko, we have no way of getting that information, due to content and frame shenanigans. So you'd see the button highlight even when you moused over the dropdown; to avoid that, I now display the button as always "hovered" while the dropdown is active. It looks fine, and it might even look better than the "native".
Attachment #306912 - Attachment is obsolete: true
Attachment #307592 - Flags: review?(pavlov)
Attachment #306912 - Flags: review?(pavlov)
Attachment #307592 - Flags: review?(pavlov) → review+
Checked in.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5 Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050810 Minefield/3.0pre Verified.
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: