Vista textfield appearance incorrect when focused

VERIFIED FIXED

Status

()

Core
Widget: Win32
P2
normal
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: faaborg, Assigned: vlad)

Tracking

({polish})

Trunk
x86
Windows Vista
polish
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

11 years ago
Created attachment 304369 [details]
Examples of Firefox vs. native text fields on Vista

Our text fields in both chrome and content appear foreign on Vista.

Related vista widget bug: every menulist should be a menubutton, bug 390737
(Reporter)

Comment 1

11 years ago
Nominating for blocking to pick up wanted.
Flags: blocking1.9?
(Reporter)

Updated

11 years ago
Blocks: 333484
Assignee: nobody → vladimir
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Depends on: 418552
Flags: tracking1.9+
Fixed by checkin for bug 418552.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 3

10 years ago
The active state is currently shown when the mouse is down, but should be shown when the field is focused, like native widgets. This looks like the problem with content selects, menubuttons, menu toolbarbuttons, split toolbarbuttons, etc. Reopen?
Sure, let's morph this.
Status: RESOLVED → REOPENED
Flags: blocking1.9+
Priority: P3 → P2
Resolution: FIXED → ---
Summary: Match native appearance of text fields on Vista → Vista textfield appearance incorrect when focused
Created attachment 306912 [details] [diff] [review]
fix

The new editborder part uses a different set of style constants than the standard ones, turns out.
Attachment #306912 - Flags: review?
Attachment #306912 - Flags: review? → review?(pavlov)
Created attachment 307592 [details] [diff] [review]
patch v2

Let's go again here.  This fixes all the issues with textfields and dropdowns, except for one: in native vista, when a dropdown is open, then dropdown arrow is not highlighted unless you explicitly hover over the dropdown.  But in Gecko, we have no way of getting that information, due to content and frame shenanigans.  So you'd see the button highlight even when you moused over the dropdown; to avoid that, I now display the button as always "hovered" while the dropdown is active.  It looks fine, and it might even look better than the "native".
Attachment #306912 - Attachment is obsolete: true
Attachment #307592 - Flags: review?(pavlov)
Attachment #306912 - Flags: review?(pavlov)

Updated

10 years ago
Attachment #307592 - Flags: review?(pavlov) → review+
Checked in.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED

Comment 8

10 years ago
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050810 Minefield/3.0pre

Verified.
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.