Omnibus ad-blocking bug for March/April 2008

RESOLVED FIXED

Status

Camino Graveyard
Annoyance Blocking
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: Smokey Ardisson (offline for a while; not following bugs - do not email))

Tracking

({fixed1.8.1.17})

unspecified
PowerPC
Mac OS X
fixed1.8.1.17

Details

Attachments

(1 attachment, 1 obsolete attachment)

Give me your tired, your poor, your annoying ads yearning to be blocked....

Comment 1

10 years ago
There's an ad serving platform called Connextra that mostly does gambling ads. They're all over sites like http://www.livescore.com/, http://bestbetting.com/ and http://www.asianbookie.com/.

These three rules should block pretty much all of their ads:

embed[src*="connextra.com"],
img[src*="connextra.com"],
iframe[src*="connextra.com"],

Comment 2

10 years ago
Lots of fun ads on

http://www.americancoinop.com/article.cfm?articleID=17622

Blocking "/adclick" should take care of all of them, I think.

cl

Comment 3

10 years ago
Version 1.6b3 (1.8.1.13 2008032420)

For some reason I don't get the "Close this ad" box whether block web advertising is off or not:

http://www.adbrite.com/mb/full_page_ad_preview.php?name=Mozilla%20Firefox&logo=&url=http://www.getfirefox.com

It works fine on whatever service 4chan uses, but adbrite is evil.

Comment 4

10 years ago
Very obnoxious corner-peel Flash on sfgate.com, which breaks hit testing even though the Flash is blocked. I think we also need to block divs which ids that start with "adx_".
I've added some news sites to the Swedish localization, here are the ads I've found on them:

dn.se: Both flash and regular ads seems to come from http://ad.adtoma.com
svd.se: Both flash and regular ads seems to come from http://adserver.adtech.de
This got lost in the release cycle :(
Summary: Omnibus ad-blocking bug for March 2008 → Omnibus ad-blocking bug for March/April 2008

Comment 7

10 years ago
Looks like www.foxnews.com has a new ad in the upper-right corner just below the menu bar featuring links to all of their shows. Looks like it's coming from "openx.foxnews.com". Looks like everything else on the page is blocked successfully.

Comment 8

10 years ago
Ad blocking erroneously hides the video here:
http://news.nationalgeographic.com/news/2008/04/080425-elephant-video-wc.html
(In reply to comment #3)
> For some reason I don't get the "Close this ad" box whether block web
> advertising is off or not:
> 
> http://www.adbrite.com/mb/full_page_ad_preview.php?name=Mozilla%20Firefox&logo=&url=http://www.getfirefox.com

I can unblock img[id="AdBriteSkipThisAd"], but I'm not sure that's useful, as clicking the button just takes me back to adbrite instead of making mozilla.com full-content.
(In reply to comment #4)
> Very obnoxious corner-peel Flash on sfgate.com, which breaks hit testing even
> though the Flash is blocked. I think we also need to block divs which ids that
> start with "adx_".

We already are :( Bug 402810 comment 8.  I didn't see any corner-peel when browsing around sfgate today, either.
Created attachment 318971 [details] [diff] [review]
In-progress

This is everything except my last two comments here and bug 430816.  Just attaching it now to thwart any bread-trucks.
Assignee: nobody → alqahira
Status: NEW → ASSIGNED

Comment 12

10 years ago
The BBC news site now has an obscenely huge banner that forces the entire page down, plus a couple of sidebar ads.

I've been able to block them with:

@-moz-document domain("news.bbc.co.uk") {
	/* Fat header */
	.leaderboardcontainer {display: none !important;}
	/* Right sidebar */
	#bbccom_mpu {display: none !important;}
	/* Left sidebar */
	#bbccom_button {display: none !important;}
}

Comment 13

10 years ago
(In reply to comment #12)
> The BBC news site now has an obscenely huge banner that forces the entire page
> down, plus a couple of sidebar ads.
> 
Are you using something older than Camino 1.6 or a nightly build ? Those BBC gaps (place holders for ads) are blocked in Camino 1.6 or nightlies.

Created attachment 320485 [details] [diff] [review]
April-May 08 Omnibus Adblocking patch

This adds the fix for bug 433263 and a rule for State Farm ads for bug 430816.  I'm a little ambivalent about the latter; on the one hand, it's a terribly (site-)specific and ugly rule, but on the other, there are 3 of those ads per ZIP code-page.
Attachment #318971 - Attachment is obsolete: true
Attachment #320485 - Flags: superreview?(sfraser_bugs)

Updated

10 years ago
Attachment #320485 - Flags: superreview?(sfraser_bugs) → superreview+
Landed on the trunk.  I'll get the 1.6.2 flag this afternoon.
Blocks: 430087
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
No longer depends on: 430087
Resolution: --- → FIXED
Landed on 1_8 branch in advance of 1.6.2.
Flags: camino1.6.2? → camino1.6.2+
Keywords: fixed1.8.1.16
You need to log in before you can comment on or make changes to this bug.