Closed
Bug 422991
Opened 14 years ago
Closed 14 years ago
'make distclean' misses some files
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: fta+bugzilla, Assigned: glandium)
References
Details
Attachments
(2 files, 2 obsolete files)
1.29 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
431 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
As a follow-up of bug 333308, here are even more cleanups for: browser/installer/packages-static browser/installer/removed-files other-licenses/branding/firefox/locales/Makefile other-licenses/branding/firefox/Makefile
Attachment #309498 -
Flags: review?(benjamin)
Assignee | ||
Comment 1•14 years ago
|
||
The other-licenses/branding stuff should go in a section specific to --enable-official-branding.
Reporter | ||
Comment 2•14 years ago
|
||
updated to work with --enable-official-branding
Attachment #309498 -
Attachment is obsolete: true
Attachment #309516 -
Flags: review?(benjamin)
Attachment #309498 -
Flags: review?(benjamin)
Comment 3•14 years ago
|
||
Comment on attachment 309516 [details] [diff] [review] cleanup, round 1 rev2 Is there a reason you have to hardcode the MOZ_BRANDING_DIRECTORY check? Why not add_makefiles " $MOZ_BRANDING_DIRECTORY/Makefile $MOZ_BRANDING_DIRECTORY/locales/Makefile "
Attachment #309516 -
Flags: review?(benjamin)
Assignee | ||
Comment 4•14 years ago
|
||
The other-licenses/branding stuff is actually bug #429852 i just filed.
Assignee | ||
Comment 5•14 years ago
|
||
I think this is better than attachment #309516 [details] [diff] [review], for the browser/installer part.
Attachment #316620 -
Flags: review?(benjamin)
Assignee | ||
Comment 6•14 years ago
|
||
Okay, I see that contrary to what i said in bug #429852, the Makefiles aren't generated from configure. This will obviously solve bug #429852 by cheating: Makefiles will be removed twice.
Attachment #309516 -
Attachment is obsolete: true
Attachment #316622 -
Flags: review?(benjamin)
Updated•14 years ago
|
Attachment #316620 -
Flags: review?(benjamin) → review+
Updated•14 years ago
|
Attachment #316622 -
Flags: review?(benjamin) → review+
Updated•14 years ago
|
Assignee: nobody → mh+mozilla
Keywords: checkin-needed
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/886ef76f9efe http://hg.mozilla.org/mozilla-central/rev/dabc1188242e
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1b2
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•