Closed Bug 422991 Opened 13 years ago Closed 12 years ago

'make distclean' misses some files

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: fta+bugzilla, Assigned: glandium)

References

Details

Attachments

(2 files, 2 obsolete files)

cleanup browser/installer
1.29 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
cleanup branding
431 bytes, patch
benjamin
: review+
Details | Diff | Splinter Review
Attached patch cleanup, round 1 (obsolete) — — Splinter Review 
As a follow-up of bug 333308, here are even more cleanups for:

browser/installer/packages-static
browser/installer/removed-files
other-licenses/branding/firefox/locales/Makefile
other-licenses/branding/firefox/Makefile
Attachment #309498 - Flags: review?(benjamin)
The other-licenses/branding stuff should go in a section specific to --enable-official-branding.
Attached patch cleanup, round 1 rev2 (obsolete) — — Splinter Review 
updated to work with --enable-official-branding
Attachment #309498 - Attachment is obsolete: true
Attachment #309516 - Flags: review?(benjamin)
Attachment #309498 - Flags: review?(benjamin)
Comment on attachment 309516 [details] [diff] [review]
cleanup, round 1 rev2

Is there a reason you have to hardcode the MOZ_BRANDING_DIRECTORY check? Why not

add_makefiles "
  $MOZ_BRANDING_DIRECTORY/Makefile
  $MOZ_BRANDING_DIRECTORY/locales/Makefile
"
Attachment #309516 - Flags: review?(benjamin)
The other-licenses/branding stuff is actually bug #429852 i just filed.
I think this is better than attachment #309516 [details] [diff] [review], for the browser/installer part.
Attachment #316620 - Flags: review?(benjamin)
Attached patch cleanup branding — — Splinter Review 
Okay, I see that contrary to what i said in bug #429852, the Makefiles aren't generated from configure. This will obviously solve bug #429852 by cheating: Makefiles will be removed twice.
Attachment #309516 - Attachment is obsolete: true
Attachment #316622 - Flags: review?(benjamin)
Attachment #316620 - Flags: review?(benjamin) → review+
Attachment #316622 - Flags: review?(benjamin) → review+
Assignee: nobody → mh+mozilla
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 461309
Depends on: 461051
Duplicate of this bug: 429852
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.