Closed Bug 424818 Opened 16 years ago Closed 2 years ago

Integrate Dojo Test Suite

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: jeresig, Unassigned)

References

()

Details

Dojo has a good test suite that we should look to integrate with our Mochitest setup.

See previous efforts in bug 375543, bug 379506, bug 381001, and bug 386109.
I haven't been able to make a patch yet of the dojo-thing, for the time being, extract this:
http://martijn.martijn.googlepages.com/dojo-release-1.1.1.zip
into:
C:\mozilla-build\mozilla\dom\tests\mochitest\ajax

And then it's just a matter of adding dojo-release-1.1.1 \ to the Makefile.in

I had to disable some tests. Not really sure why some of those failed, alhtough others like rpc failed because they only seem to work with some kind of php script.
The things I had to change to make dojo test integration work:

I had to remove en-us-new_york-brooklyn in various files named "salutations.js".
The "en-us-new_york-brooklyn" name was causing build failures (because mozilla-build on windows can't handle too long names?)

I have disabled the tests that are failing currently (a couple of those because they need a server), I added a //xxxmw comment to those.

In runner.js I had to change:
			var _shouldRequire = (dojo.isBrowser) ? (dojo.global == dojo.global["parent"]) : true;
into:
			var _shouldRequire = (dojo.isBrowser) ? (dojo.global["parent"] == dojo.global["parent"]) : true;


In _browserRunner.js:

		_addOnEvt("load", 
			function(){
				doh._onEnd = function(){

I added:
		if ( parent.runAJAXTest )
			parent.runAJAXTest();
at the end of doh._onEnd.

At the end of doh._testFinished, I added:
			if (parent.SimpleTest)
			  parent.SimpleTest.is(success, true, fixture.name);
			  
directly at the beginning in (function(){:
change 	if(window.parent == window){ 
into:
	if(window.parent == window || (window.frameElement && window.frameElement.id == 'testframe')){
Assignee: nobody → martijn.martijn
I tried running this on my debug build of mozcentral and it froze on this test: /tests/dom/tests/mochitest/ajax/dojo-release-1.1.1/dojo/tests/dnd/test_box_constraints.html

It never seemed to update after that. Running on: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1a1pre) Gecko/2008062618 Minefield/3.1a1pre
Sorry, I forgot to remove the files that start with 'test_' in the Makefile.in files.

Those were the standalone, manual tests of Dojo, but the names unfortunately make them appear in the Mochikit testsuite. They aren't necessary, only test_Doho.html is necessary, so I removed them from the Makefile.in files now.
I updated the zip file at http://martijn.martijn.googlepages.com/dojo-release-1.1.1.zip .

Btw, I notice that the dojo files are being copied to 2 places:
C:\mozilla-build\mozilla\_firefox\dom\tests\mochitest\ajax\dojo-release-1.1.1
C:\mozilla-build\mozilla\_firefox\_tests\testing\mochitest\tests\dom\tests\mochitest\ajax\dojo-release-1.1.1
Why is that happening? The first one doesn't seem necessary.
Component: Testing → DOM
QA Contact: testing → general
Component: DOM → DOM: Core & HTML

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: martijn.martijn → nobody
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.