429407 - upgrade OG module and include job_queue module

Status: RESOLVED FIXED

(Websites Graveyard :: spreadfirefox.com, defect, P1)

Description

[Alix Franquet [:alix]]

Posting on groups with many members will often result in timeouts, multiple posts, and multiple email notifications. 
It is possible that this is linked to the email notification and the web site doesn't confirm submission of the post in time. Users posting might also be getting impatient and hitting submit multiple times.

This is happening in particular on: Mozilla Sponsored Events, Community@SFx, New Spreadfirefox Design Goes Live groups. These are all large groups so it's hard to test the exact steps to reproduce, as it will send email notifications to the large number of subscribers for each group.

Haven't been able to reproduce it in smaller groups.

Comment 1

[Alex Polvi]

This might be causing bug 418862

Comment 2

[Alex Polvi]

And bug 420338

Comment 3

[Alex Polvi]

and *maybe* bug 418480

Comment 4

[Alex Polvi]

OK -- so, we think a lot of the timeout issues are related to og.module sending out lots of emails 1 by 1. We were thinking disabling emails might be a good option, however, upgrading to the latest og module will probably do the trick.

If the job_queue model is installed, the latest og.module supporting queuing of emails, which are send from cron. This should fix the timeout issues.

Now the problem becomes, how hard is it to upgrade that module? It looks like there are some custom hacks ... 

Comment 5

[Jeremy Orem [:oremj]]

Attachment: Disables OG mail.

This will temporarily disable OG mail until someone takes the time to upgrade OG and install the job_queue module.

Comment 6

[Chris Pollett]

Comment on attachment 321135 [details] [diff] [review]
Disables OG mail.

wfm.

Comment 7

[Jeremy Orem [:oremj]]

Sending        modules/og/og.module
Transmitting file data .
Committed revision 13202.

Comment 8

[Alex Polvi]

14:27 <oremj> tagged with svn merge -c 13202 http://svn.mozilla.org/projects/spreadfirefox.com/trunk .

... just for house keeping.

Leaving open because we need to implement the new og module -- so we can properly solve this bug. 

Comment 9

[Alex Polvi]

we need to update the OG module so it can support the job_queue module. Once we do this, we can re-enable mail on SFX.

Comment 10

[Paul Booker]

@Alex

Good call , i have been working towards this.

https://bugzilla.mozilla.org/show_bug.cgi?id=443353

Comment 11

[Paul Booker]

@Alex

The OG module has now been updated to 5.x-7.3

Ill get the job_queue module working on my local machine and then commit to SVN and test the module again on stage ...

Comment 12

[Alix Franquet [:alix]]

It looks like OG Mail has been turned on again. Sfx members are getting notified of new posts several times. 
It needs to be turned off again asap.

Comment 13

[Reed Loden [:reed]]

(In reply to comment #12)
> It looks like OG Mail has been turned on again. Sfx members are getting
> notified of new posts several times. 
> It needs to be turned off again asap.

Probably got turned on by the upgrade in bug 443353. I can recommit oremj's patch to turn it off, if you would like.

Comment 14

[Alix Franquet [:alix]]

If oremj's patch will work after the upgrade, then yes, please recommit it.

Thanks!

Comment 15

[Alix Franquet [:alix]]

Update: Ian updated the admin settings to disable email notification for group postings, so Sfx should be ok without the patch for now.

Comment 16

[Paul Booker]

Attachment: A patch to OG to enable Job Queue functionality

If we want to install Job Queue @ 
http://drupal.org/project/job_queue we will need to commit this contributed module to SVN and patch the OG module (please see patch)

I couldn't test this module completely on my local machine as i have a mail  out problem that i have not resolved presently but my expectation is that Job Queue will work fine on stage.

Paul.

Comment 17

[Paul Booker]

Attachment: A patch to OG to enable Job Queue functionality

If we want to install Job Queue @ 
http://drupal.org/project/job_queue we will need to commit this contributed module to SVN and patch the OG module (please see patch)

I couldn't test this module completely on my local machine as i have a mail  out problem that i have not resolved presently but my expectation is that Job Queue will work fine on stage.

Paul.

Comment 18

[Paul Booker]

I tested  the OG module + Job Queue on my personal VPS server @
http://drupal5.drupalr.org and it worked perfectly.

Comment 19

[Alex Buchanan [:abuchanan]]

Comment on attachment 334884 [details] [diff] [review]
A patch to OG to enable Job Queue functionality

r-'ing because the TODO there seems simple enough to take care of now, I'd rather not try to revisit it (aka forget that TODO even exists).  Please take care of it and resubmit your patch.  

you can check in the og.module file for job queue, or you can make it a dependency in og.info.  If you check in the module code, make sure to fall back to drupal_mail() if it doesn't exist

Comment 20

[Alex Buchanan [:abuchanan]]

Job queue is a good fix, but it sucks we have to edit og.module to fix this, IMO.  We might look at the Subscriptions module to solve this problem in the future.

http://drupal.org/project/subscriptions

Looks like it lets you limit the number of outgoing mails and also uses the same strategy as job_queue to prevent PHP execution time limits.  This is something to think about for the next version of SFX.  They say it may replace OG's current mail system anyway

Comment 21

[Paul Booker]

Attachment: A patch to OG to enable Job Queue functionality

Comment 22

[Alex Buchanan [:abuchanan]]

added job queue module and patch to trunk in r18178