430948 - Places:Drag & Drop a Favicon or a Link to Bookmarks Toolbar, Bookmarks Menu or Sidebar Bookmarks does not work.

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-us; rv:1.9pre) Gecko/2008042603 Minefield/3.0pre Firefox/2.0.0.14
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-us; rv:1.9pre) Gecko/2008042603 Minefield/3.0pre

Places:Drag & Drop a Favicon or a Link to Bookmarks Toolbar, Bookmarks Menu or Sidebar Bookmarks does not work.


Reproducible: Sometimes

Steps to Reproduce:
1.Start Firefox with New Profile.
2.Drag & Drop a Favicon or a Link to Bookmarks Toolbar, Bookmarks Menu or Sidebar Bookmarks.
3.
Actual Results:  
Nothing happen

Expected Results:  
Should add a bookmark item to the dropped zone.


In Console2 window.

Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.getFolderIdForItem]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/places/controller.js :: PCDH_canMoveContainer :: line 1387"  data: no]

This may be Regression.

Comment 1

[Alice0775 White]

Regression window is:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042515 Minefield/3.0pre -- Works fine

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042517 Minefield/3.0pre -- Not Works

Bonsai:
 http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1209159120&maxdate=1209165839

Comment 2

[Marco Bonardo [:mak] (Away July 4-13)]

so if regwindow is correct is most likely bug 423515

in error console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.getFolderIdForItem]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/places/controller.js :: PCDH_canMoveContainer :: line 1387"  data: no]
Source File: chrome://global/content/nsDragAndDrop.js
Line: 397

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

dup of https://bugzilla.mozilla.org/show_bug.cgi?id=428411 ??  or visa-versa ?

Comment 4

[Marco Bonardo [:mak] (Away July 4-13)]

(In reply to comment #3)
> dup of https://bugzilla.mozilla.org/show_bug.cgi?id=428411 ??  or visa-versa ?

no, they are completely different things

Comment 5

[Dietrich Ayala (:dietrich)]

Attachment: fix

Comment 6

[Asaf Romano (gone)]

Where do we call this without an id?

Comment 7

[Dietrich Ayala (:dietrich)]

(In reply to comment #6)
> Where do we call this without an id?
> 

in the 2nd hunk of the patch.

Comment 8

[Asaf Romano (gone)]

But you null-check unwrapped.id id there, as you should.

I don't think there's much sense in making this argument optional.

Comment 9

[Dietrich Ayala (:dietrich)]

ah right, i see. yes, then just review on the 2nd hunk please.

Comment 10

[Asaf Romano (gone)]

Comment on attachment 317939 [details] [diff] [review]
fix

r=mano for the second hunk only :)

Comment 12

[Dietrich Ayala (:dietrich)]

Comment on attachment 317939 [details] [diff] [review]
fix

drivers: low-impact regression fix

Comment 13

[Damon Sicore (:damons)]

Comment on attachment 317939 [details] [diff] [review]
fix

a1.9+=damons

Comment 14

[snowcrash+mozilla]

it's unclear to me whether the 'approval' above indicates that the patch is already applied to trunk, or not ...

so, just fyi, this morning's latest:

Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042904 Minefield/3.0pre ID:2008042904

still exhibits the problem.  i.e., no bookmark created on drag to toolbar.

Comment 15

[Marco Bonardo [:mak] (Away July 4-13)]

(In reply to comment #14)
> it's unclear to me whether the 'approval' above indicates that the patch is
> already applied to trunk, or not ...

the patch is applied when a bug is marked as FIXED, so no, an approved patch is still not in the tree.

Comment 17

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/controller.js;
/cvsroot/mozilla/browser/components/places/content/controller.js,v  <--  controller.js
new revision: 1.234; previous revision: 1.233
done

Comment 18

[Tracy Walker [:tracy]]

Verified with:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008043004 Minefield/3.0pre
and 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008043007 Minefield/3.0pre

Comment 19

[u235898]

Is there a reason for drag'n'drop taking the "security identifier" on SSL sites does not behave like taking the favicon itself??

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please file a new bug. This one has been fixed for Firefox 3.

Dietrich, do we already have an automated test for this regression?

Comment 21

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv