434354 - CalDAV provider should cope with multiple principal-collection-sets

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Bruno Browning]

The CalDAV provider does various types of discovery concerning the remote calendar on the first call to getItems(), including a principal-collection-set query. The current code assumes that only one href will be returned by this query, and that is not necessarily the case. This is the underlying cause of the "pcs.charAt is not a function" error console message reported in bug 433906. The provider should cope with a response locating multiple principal-collection-sets, querying as many of them as necessary to achieve the next discovery step.

Comment 2

[Martin Schröder [:mschroeder]]

Requesting blocking-calendar0.8. As described in bug 441611, this can look like Lightning isn't loading anything after start up.

Comment 3

[Bruno Browning]

a fix for this is included in the draft caldav-sched patch in bug 409921

Comment 4

[Bruno Browning]

probably also worth noting that currently Kerio is the only CalDAV server that triggers this bug

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

If this bug is not fixed by bug 409921 (which is assigned to bruno), please reassign if needed.

Comment 7

[Bruno Browning]

Attachment: handle multiple principal-collection paths

pulled this patch out of the bigger caldav-sched patch since it's unrelated; makes for easier review and better code history

Comment 8

[Daniel Boelzle [:dbo]]

Comment on attachment 332383 [details] [diff] [review]
handle multiple principal-collection paths

looks good; r=dbo (though I haven't tested it)

Comment 9

[Tony Fairbanks]

The latest patch seems to make Lightning happy with Kerio, from my brief testing so far.

Comment 10

[Bruno Browning]

patch checked in on HEAD and MOZILLA_1_8_BRANCH

->FIXED

Comment 12

[Jelle de Jong]

I can confirm this issue with iceowl (sunbird )0.8.6 on debian sid with darwin calendar server and multiple calendar. I hope it is resolved with version 0.9.