Closed Bug 435804 Opened 12 years ago Closed 12 years ago

Remaining rdf cleanup for FilterListDialog

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: jminta, Assigned: jminta)

References

Details

Attachments

(1 file)

Attached patch patch v1Splinter Review
Now that nsMsgFilterDataSource is gone, there's no reason that functions in the filter-dialog should need to deal with URIs.  Rather, they can just pass around servers/folders, which removes the need for the RDF service.
Attachment #322581 - Flags: review?(philringnalda)
Comment on attachment 322581 [details] [diff] [review]
patch v1

You had me at "-    // see bug #XXXXXX"
Attachment #322581 - Flags: review?(philringnalda) → review+
Patch checked in.  For regression testing, focus on the two drop-down menus in the filter dialog.  The server one should properly update the filter list, and the bottom one should select the right folder for running filters.

Checking in mail/base/content/FilterListDialog.js;
/cvsroot/mozilla/mail/base/content/FilterListDialog.js,v  <--  FilterListDialog.js
new revision: 1.18; previous revision: 1.17
done
Checking in mail/base/content/FilterListDialog.xul;
/cvsroot/mozilla/mail/base/content/FilterListDialog.xul,v  <--  FilterListDialog.xul
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
Depends on: 437056
Depends on: 441666
Depends on: 422474
Depends on: 413781
Depends on: 527629
You need to log in before you can comment on or make changes to this bug.