436718 - Only convert from a uri to a folder through GetMsgFolderForUri, not by using the rdf service directly

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Joey Minta]

Attachment: part 1 v1

widgetglue.js provides a function to convert from a uri to an nsIMsgFolder, and we should centralize all conversions there, to make it easier to remove rdf when it gets to that point.  This will also make it easier to remove the global RDF objects that are floating around.

This first patch gets rid of the low-hanging fruit.  I'm more concerned about removing a few others, because the files are included in a bunch of dialogs.  Once I confirm whether widgetglue is (a) necessary and (b) included in those dialogs, they can be converted as well.

Comment 1

[Phil Ringnalda (:philor)]

Comment on attachment 323242 [details] [diff] [review]
part 1 v1

r=me, but while you're touching it, please kill the trailing space in

>   //if it's a server, clear the threadpane and don't bother trying to load.
>-  if(msgfolder.isServer) 
>+  if(folder.isServer)

Comment 2

[Joey Minta]

Part 1 checked in.

Checking in mail/base/content/commandglue.js;
/cvsroot/mozilla/mail/base/content/commandglue.js,v  <--  commandglue.js
new revision: 1.92; previous revision: 1.91
done
Checking in mail/base/content/mailWindowOverlay.js;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.js,v  <--  mailWindowOverlay.js
new revision: 1.203; previous revision: 1.202
done
Checking in mail/base/content/messageWindow.js;
/cvsroot/mozilla/mail/base/content/messageWindow.js,v  <--  messageWindow.js
new revision: 1.65; previous revision: 1.64
done
Checking in mail/base/content/messageWindow.xul;
/cvsroot/mozilla/mail/base/content/messageWindow.xul,v  <--  messageWindow.xul
new revision: 1.41; previous revision: 1.40
done
Checking in mail/base/content/msgHdrViewOverlay.js;
/cvsroot/mozilla/mail/base/content/msgHdrViewOverlay.js,v  <--  msgHdrViewOverlay.js
new revision: 1.105; previous revision: 1.104
done
Checking in mail/base/content/msgMail3PaneWindow.js;
/cvsroot/mozilla/mail/base/content/msgMail3PaneWindow.js,v  <--  msgMail3PaneWindow.js
new revision: 1.149; previous revision: 1.148
done

Comment 3

[Kent James (:rkent)]

I have a regression from this patch (more precisely, the checkin from 2008-06-10 17:34) Basically, saved searches over a single folder quit working.

Steps to reproduce:

1) Select a folder with some email in it (IMAP and Local Folders both show the effect)
2) Create a search that matches some email (for example Subject Contains test)
3) Clear "search Subfolders" checkbox
4) Save the search as a virtual folder.
5) Open the new saved search folder.

Expected results: messages are displayed
Actual results: no messages are displayed.

I have confirmed that backing out the patch submitted at that time makes the issue disappear. But I do not know the specific lines in that patch that cause it.

Comment 4

[Magnus Melin [:mkmelin]]

Better to file as a new dependent bug, but now there is already bug 438786.

Comment 5

[Joey Minta]

Attachment: part 2 v1

This finishes things off.  Need bienvenu to look at this, due to the overlapping newFolderDialog stuff...

Comment 6

[Joey Minta]

Patch checked in. I'm leaving this open until I audit some of the people who have their own copies of the rdfService.  At this point, the global consumers have all been migrated.

Checking in mail/base/content/mail3PaneWindowCommands.js;
/cvsroot/mozilla/mail/base/content/mail3PaneWindowCommands.js,v  <--  mail3PaneWindowCommands.js
new revision: 1.48; previous revision: 1.47
done
Checking in mail/base/content/mailCommands.js;
/cvsroot/mozilla/mail/base/content/mailCommands.js,v  <--  mailCommands.js
new revision: 1.52; previous revision: 1.51
done
Checking in mail/base/content/mailWindowOverlay.js;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.js,v  <--  mailWindowOverlay.js
new revision: 1.205; previous revision: 1.204
done
Checking in mail/base/content/mailWindowOverlay.xul;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.xul,v  <--  mailWindowOverlay.xul
new revision: 1.247; previous revision: 1.246
done
Checking in mail/base/content/messageWindow.js;
/cvsroot/mozilla/mail/base/content/messageWindow.js,v  <--  messageWindow.js
new revision: 1.67; previous revision: 1.66
done
Checking in mail/base/content/msgMail3PaneWindow.js;
/cvsroot/mozilla/mail/base/content/msgMail3PaneWindow.js,v  <--  msgMail3PaneWindow.js
new revision: 1.152; previous revision: 1.151
done
Checking in mail/base/content/widgetglue.js;
/cvsroot/mozilla/mail/base/content/widgetglue.js,v  <--  widgetglue.js
new revision: 1.27; previous revision: 1.26
done
Checking in mailnews/base/resources/content/mailCommands.js;
/cvsroot/mozilla/mailnews/base/resources/content/mailCommands.js,v  <--  mailCommands.js
new revision: 1.116; previous revision: 1.115
done
Checking in mailnews/base/resources/content/newFolderDialog.js;
/cvsroot/mozilla/mailnews/base/resources/content/newFolderDialog.js,v  <--  newFolderDialog.js
new revision: 1.10; previous revision: 1.9
done