444913 - Port |Bug 413781 – XBLify folder-selection menus| to SeaMonkey

Status: RESOLVED DUPLICATE of bug 1677365

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Serge Gautherie (:sgautherie)]

Per bug 360488 dependency.

***

Bug 438647 already ported the backend/common part of it;
the frontend/separated part remains to be ported.

Remember to take into account all the (fixed) regressions too.
(Currently, there are still 2 open ones.)

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Depends on Bug 467249

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Updated patch

Comment 3

[Robert Kaiser]

Getting us to same same API as Thunderbird 3 is surely something we want.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 362880 [details] [diff] [review]
Updated patch


(In reply to comment #1)
> Depends on Bug 467249

That bug is now fixed.

*****

This patch doesn't apply anymore as the files have moved from /mailnews to /suite.

Frank, can you resume work on this bug?
Or shall I try and take over?

Comment 5

[Frank Wein [:mcsmurf]]

I already have an updated version locally. The "problem" is just at the moment I don't see what this bug would be good for in the next SeaMonkey 2 release. So I planned to request review when we have more free reviewing resources.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)

A short answer would be comment 3 "kairo: wanted‑seamonkey2+"...
Please, proceed :-)

Comment 7

[Frank Wein [:mcsmurf]]

Many bug are wanted, we just don't have the reviewing resources, I'm quite sure of that.

Comment 8

[Serge Gautherie (:sgautherie)]

Fwiw, bug 507601 comment 1:
{
From  Robert Kaiser   2009-07-31 04:55:34 PDT

we probably should only take it for 2.0 if it has patch and reviews for the
last beta
}

I'd think you could ask and see what the reviewer does.
Anyway, I asked you and that's all I intended to do...
Maybe discuss this at tomorrow meeting?

Comment 9

[Robert Kaiser]

(In reply to comment #8)
> we probably should only take it for 2.0 if it has patch and reviews for the
> last beta

I think we can take a careful look at it in any case. I'd feel better if we'd have branched, have unit tests for this stuff, have them running on trunk and could bake an eventual patch there for at least a cycle, but we don't have any of that, so let's take a careful look when a patch is there and going through reviews.

Comment 10

[Serge Gautherie (:sgautherie)]

I just discovered that bug 510793 "depends" on
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mail/base/content/mailWindow.js&mark=1.63#1.64

Frank, could you port (at least) that (and whatever else goes with it)?

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)
> I just discovered that bug 510793 "depends" on

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mail/base/content/msgMail3PaneWindow.js&rev=HEAD&mark=1.146#1.147
too.

See
http://mxr.mozilla.org/comm-central/search?string=SetupMoveCopyMenus&case=on&find=%2Fsuite%2Fmailnews%2F.*Window%5C.js%24

Comment 12

[Robert Kaiser]

Not wanted for 2.0 any more at this stage, let's push it to 2.1

Comment 13

[Serge Gautherie (:sgautherie)]

Frank, any update status of yours?

Comment 14

[Frank Wein [:mcsmurf]]

Attachment: New patch

This one applies again, still need to check if I missed anything.

Comment 15

[Justin Wood (:Callek)]

(In reply to comment #14)
> Created attachment 419822 [details] [diff] [review] [review]
> New patch
> 
> This one applies again, still need to check if I missed anything.

Dropped off your radar?

Comment 16

[Serge Gautherie (:sgautherie)]

Franck, do you intend to complete this bug? Or could you unassign yourself?

Comment 17

[Frank Wein [:mcsmurf]]

Won't finish this patch in the foreseeable future.

Comment 18

[Wayne Mery (:wsmwk)]

this blocks several non-trivial bugs, so -> normal